From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966EF1EFF8D for ; Tue, 18 Nov 2025 23:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763507276; cv=none; b=rJgUI5SU5s7Lkr7xDHkX1uASNGkDJR016WuSlS4V+MxtGzCRaRoGqR2AeUNV1DGWlM1xQ0O5bCF0tweOihhRfXLviYUw5yKi6O9wpqoi08WHQbr1M34vgut0P7ui77vLkPJqS6SU1e373XUry7yiYaU4btqiwYA0WGJtEDO4oXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763507276; c=relaxed/simple; bh=UV4kfXClE+xCHv+QlyU8g76Mw1tlU5ihIVPqXS0j4A4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SfjSDb+/Mtd4l0RUauX6F3uZlJW7s6N67SCm1vkgS5iZp4xNskp67XDIPjNUu544rvIsNuZ5+6ehxe6qnM9R6Hh+sAQQVdOCwCA2pz9Ri2mWNGSfQ+cmnGR65lDw+SIHrewJqkbnvNVtX7n6jku1XqEyEe9BlguKXgWRVsremok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QxM4LUBY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QxM4LUBY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6EB9C16AAE; Tue, 18 Nov 2025 23:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763507275; bh=UV4kfXClE+xCHv+QlyU8g76Mw1tlU5ihIVPqXS0j4A4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QxM4LUBYMVuVEl85dHmHayfeE8Tj11o6ZffP9iZM9dH3Ys/dEjhY5Q8MqvYylGDxm pAtFV4coD8MsuFuYGGxQi0nA5sRXiNFhrKfwuIIEE1khhRSZ4qXY+abnoNQ3+XI5gJ IrskPXg+5ND612QxJtqIGDTUq+0SC2UBt0gakHal9+1VXPIFIiGlWdWZXmZmei/6WA HD4d+K9OHVX9pRSOymy4GuzudPLunVIDpaBycb7tQjRk7YbSvVajuh44MplV9ZCZpJ n3yHxXlv3bU5MO1JQQL9zyLIQyBuUmtPrfettVLh/F+nWatbO3j++hPfhAVYGIiodN Ee0ffRj1vnMGw== Date: Tue, 18 Nov 2025 16:07:50 -0700 From: Nathan Chancellor To: Yang Shi Cc: ryan.roberts@arm.com, dev.jain@arm.com, cl@gentwo.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] arm64: mm: make linear mapping permission update more robust for patial range Message-ID: <20251118230750.GA1451312@ax162> References: <20251023204428.477531-1-yang@os.amperecomputing.com> <20251118164115.GA3977565@ax162> <7147bd7c-f4b2-4757-96f5-d9b61405ec91@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7147bd7c-f4b2-4757-96f5-d9b61405ec91@os.amperecomputing.com> On Tue, Nov 18, 2025 at 09:35:08AM -0800, Yang Shi wrote: > Thanks for reporting this problem. It looks like I forgot to use untagged > address when calculating idx. > > Can you please try the below patch? > > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c > index 08ac96b9f846..0f6417e3f9f1 100644 > --- a/arch/arm64/mm/pageattr.c > +++ b/arch/arm64/mm/pageattr.c > @@ -183,7 +183,7 @@ static int change_memory_common(unsigned long addr, int > numpages, >          */ >         if (rodata_full && (pgprot_val(set_mask) == PTE_RDONLY || >                             pgprot_val(clear_mask) == PTE_RDONLY)) { > -               unsigned long idx = (start - (unsigned long)area->addr) >> > PAGE_SHIFT; > +               unsigned long idx = (start - (unsigned > long)kasan_reset_tag(area->addr)) >> PAGE_SHIFT; >                 for (; numpages; idx++, numpages--) { > __change_memory_common((u64)page_address(area->pages[idx]), >                                                PAGE_SIZE, set_mask, > clear_mask); Yes, that appears to resolve the issue for me, thanks for the quick fix! If a formal tag helps: Tested-by: Nathan Chancellor Cheers, Nathan