From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8E125771 for ; Wed, 19 Nov 2025 04:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763525877; cv=none; b=eeOJrEDuGRQ8/yro7nSR1PaeqlVNACvhXm+lJ565qhCtlpGrxlKoYPxLsm2qR1ofmA4qymS3QvuS/fGrBraK4fjgywxKiiPY+1L4Prx7O7de0Otekdk4GAT4krBTHYa/ctr6vTaC4rrVG7TPQMw2ixQFvx1HrMM+thAVIYezzDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763525877; c=relaxed/simple; bh=k9XgYvXg+wjYK9oGaaaJfHYNam3rcMc0Uh8RTTWVT5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U/X7P9wjNLb5I6amw3oA2/yVKgkB343XM4CfrNRL+pf6GBxrN3anPSIMCiA/AIvZWMtEnQ2A3xBK66c5h3Kz8SlH+jNkzyh0lkkPqCW4/lyo4ZJCuzZm25CPaO5yZW8Q6o0Y2qQ1pih5Ma8E5sR4pIe3uhD93MesFZEKvtMfcPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=wMOj4w0t; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wMOj4w0t" Received: from pendragon.ideasonboard.com (unknown [205.220.129.225]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CD2D7DD9; Wed, 19 Nov 2025 05:15:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763525749; bh=k9XgYvXg+wjYK9oGaaaJfHYNam3rcMc0Uh8RTTWVT5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wMOj4w0tcYckHL1uLbD4I68O4YFcO2oAUfrEyfyPHXv95KApnfu3oTyZkA9doTCeo erWWZqXi/ufzaUkv8FS2j3TTK85DVPRy1o9QOlpvvYkyxzlT4kIWWL643fEVn/wEwR 8h4B0+K0SviyCdj7VEhSntQn2abmkr3QgVEjIQsY= Date: Wed, 19 Nov 2025 13:17:26 +0900 From: Laurent Pinchart To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v4 05/10] drm/bridge: dw-hdmi-qp: Set bridge supported_formats Message-ID: <20251119041726.GE10711@pendragon.ideasonboard.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-5-0ded72bd1b00@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251117-color-format-v4-5-0ded72bd1b00@collabora.com> On Mon, Nov 17, 2025 at 08:11:49PM +0100, Nicolas Frattaroli wrote: > The drm_bridge "supported_formats" member stores a bitmask of supported > HDMI output formats if the bridge is in fact an HDMI bridge. It would be nice to convert the supported_formats field to a bitmask of DRM_MODE_COLOR_FORMAT_* values. > > However, until now, the synopsys dw-hdmi-qp driver did not set this > member in the bridge it creates. > > Set it based on the platform data's supported_formats member, and > default to BIT(HDMI_COLORSPACE_RGB) if it's absent, which preserves the > previous behaviour. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > index fe4c026280f0..cf888236bd65 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > @@ -1269,6 +1269,11 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev, > dev_warn(dev, "Set ref_clk_rate to vendor default\n"); > } > > + if (plat_data->supported_formats) > + hdmi->bridge.supported_formats = plat_data->supported_formats; > + else > + hdmi->bridge.supported_formats = BIT(HDMI_COLORSPACE_RGB); > + > dw_hdmi_qp_init_hw(hdmi); > > ret = devm_request_threaded_irq(dev, plat_data->main_irq, -- Regards, Laurent Pinchart