Re: [PATCH v7 5/6] btrfs: move inode_to_path higher in backref.c

David Sterba
2025-11-19T12:49:38Z

On Wed, Nov 19, 2025 at 12:21:52PM +0000, Filipe Manana wrote:
> On Tue, Nov 18, 2025 at 4:16 PM Daniel Vacek <neelx@suse.com> wrote:
> >
> > From: Josef Bacik <josef@toxicpanda.com>
> >
> > We have a prototype and then the definition lower below, we don't need
> > to do this, simply move the function to where the prototype is.
>
> According to our development notes here:
>
> https://btrfs.readthedocs.io/en/latest/dev/Development-notes.html
>
> Under the "Function declarations" section we have:
>
> "avoid prototypes for static functions, order them in new code in a
> way that does not need it
>
> but don’t move static functions just to get rid of the prototype"
>
> So what's the motivation for moving the function?

Right, I thought the other fscrypt patches needed that for some reason
but after checking again they don't, I'll drop the patch. Thanks.