From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364562F998A for ; Wed, 19 Nov 2025 16:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570828; cv=none; b=tY6X0bv4A7I4H1CRYLb6jgg/ViWz3AroRXydYDPoAD5qpgO0vogxiPDdLX+H2xHfDx1jn8NxOycPezD8gSASQbY+LxjbXDFPOyQyEC5M96sb7wpxOD5UZSAF8jbsQompnPp5iFuK/awtBl6NISMoh5ltz7eXR3zLQjPaTFhI9m0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570828; c=relaxed/simple; bh=nmuC5jdVbQYXMDjMSUsSLfg/opJxILeHzFYtEe6e8ek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HmWMSZ/Ij31E7Je5OtJxB07ZUBbEc0u1KZ+xE3SiGJa7AgXcBtBN6T2zZ8JOmGraCsGldXtkO0U/VyGQZtVkOqRTGeeTihtsrO+HeC2kTG+uXqEM95a/fWduQoW0vHyqSsyqcYWxDVbIZd6MRu7XYBtIupML4yThK5lvcAujzug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RTSR72fm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RTSR72fm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64D53C4CEF5; Wed, 19 Nov 2025 16:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763570827; bh=nmuC5jdVbQYXMDjMSUsSLfg/opJxILeHzFYtEe6e8ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RTSR72fmnB+UmTrKkI92xXV3HdoVBDIvXPwEjrcNIrqRv9sxC4m3k3bPQDoGJ+7Vy hgl8Z7/ZCLixnh5xut+1bc66fMB/OSs86iM0oV4kY/1IZo1eDiPdaAYSTUNVyeJVvp 0LrJRKWPsJwQouyeLBJbeVjX5qXDiQG4b27fJQvvgW24WkQOfi/9iFsRm/Hslb5srD kseUfM0ug/5JC+6aDF1GVGsnCkOOG3pqbtcGub2afY7xSXO75U9UXWPlZNUSz5yiNH XJ4Do5TLATRytJ97mbKG0HYhYek4UHP7lHlkEW8dmZJyu5W7UOIDgg9+HrGNvjB+LW 632eFplnNMH0A== Date: Wed, 19 Nov 2025 16:47:03 +0000 From: Lee Jones To: Andy Shevchenko Cc: Binbin Zhou , linux-kernel@vger.kernel.org, Chong Qiao Subject: Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources Message-ID: <20251119164703.GU1949330@google.com> References: <20251113162713.3143777-1-andriy.shevchenko@linux.intel.com> <20251113162713.3143777-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251113162713.3143777-2-andriy.shevchenko@linux.intel.com> On Thu, 13 Nov 2025, Andy Shevchenko wrote: > The mixing of managed and non-managed resources may lead to possible > use-after-free bugs. In this driver the problematic part is the device > functionality that may just have gone behind the functions back, e.g., > when interrupt is being served. Fix this by switching to managed resources > for PCI. > > Fixes: 91a3e1f5453a ("mfd: ls2kbmc: Check for devm_mfd_add_devices() failure") > Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support") > Reviewed-by: Binbin Zhou > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/ls2k-bmc-core.c | 28 +++++++--------------------- > 1 file changed, 7 insertions(+), 21 deletions(-) Still doesn't apply. I'm getting lots of conflicts. What base are you on? % git --no-pager log --oneline drivers/mfd/ls2k-bmc-core.c 3696ac1d0db2 mfd: ls2kbmc: Remove unneeded semicolon from ls2k_bmc_recover_pci_data() d952bba3fbb5 mfd: ls2kbmc: Add Loongson-2K BMC reset function support 0d64f6d1ffe9 mfd: ls2kbmc: Introduce Loongson-2K BMC core driver -- Lee Jones [李琼斯]