From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E34E233C1AD for ; Wed, 19 Nov 2025 11:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763552369; cv=none; b=s20rcXwHvnfHe934Fr9YBOQ7rdNEJwSATKQCsS/U5AtuH6cMn/HSmJyif4zpEiJPgQERVmPFM0ALyKlEt2Vf1R7kQSyREf6IGKzEFghQXZcYAdkk/6ud2w1froAWNjgAR5Sb3IDwfiBftdylEqO+l47cVE/3iB8YwTJDQXcN3Sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763552369; c=relaxed/simple; bh=UM9INyxyuJVSYVO3rVZYPCdEeNlMNoNnBRz+IvQdnpE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Rp74oKLuYuz/1rhTN2HKwBi3tgzdBIqTpvKtOPHOiwaqYusE+8Y5T2z0cMDLNYqDMfMRmSvXkOBQBWm3NgPFjyl1kxlHT4MqnRhjW0bgBELpiOPILBpnEEKerhc77pFckAsaupwrOU3T386IKXYazTbgJFX24nHq3PP/UopY4dU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E8EDIuRt; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E8EDIuRt" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42b3c965ca9so3406350f8f.1 for ; Wed, 19 Nov 2025 03:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763552364; x=1764157164; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gwJG9GJDfyq4+RD2BDGOinZg52cTnz6+3CySEDanXDg=; b=E8EDIuRtVWvH3GhtbQVpo4qfCgt6xxLKLHasregH+FsaIsTwaeUTfXjPkgbMvuwugt D6nrwLhqu8IYbIMG1S/2GAmtuWmg/vnOZTOstf8CNEnqDgYdgF6py21saesZh89mCtQ5 DgpzYMsBPd0XzU3kUp+rHSh8GvE5IPa/fYyhRI9B3NIk+5foM5P2QzWmpAp/UwQMQzky FFQdSHKB+EspHJWjmVantjv4KHcbEoQ4Q8pR8b41KI9sva2iwojfbMjjNfzYFGBI/pLZ kXOFyJCjzH+fWqe7ZZZ0m+JttIfMeIFzoF2b/jINuX1g8r7n4dnwX0WY8WI8psQ+hF0f 5MVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763552364; x=1764157164; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gwJG9GJDfyq4+RD2BDGOinZg52cTnz6+3CySEDanXDg=; b=p9qn/7tYTj4nmRlRBQ/DFP4+KkuH4Dm8jJL+3iUK1JM88vTHh2icqcPjVDeoGy1N/a 1ZlN+mEO2lmNghS6tJt4A6yItqUDofdWsa93JDc5UEo4qEQAbBYIKLPvljAhVk/5r8+d ITwD27cqszBEcva+UjC3nr/oBbbhTOIAV6qI0c6KE7wjUvMCFdlkRwc+NeTDYRvmyBZI Wtwg2qtXLYEULV8rBvZQa6E6FP/gQUZ45NxoyX36p9NgZut9k4J6Tc/dqjhdq4XqCzLS u5CNlJ3oJCsOdIyW7PaLnqkCXDIFWLxtrsqqKtwP8PP0KlEhXICAobtvVfs3CKeVM4xK YmNA== X-Forwarded-Encrypted: i=1; AJvYcCX0XbIRU89eeMzwCrEPX7Ib8nRKFxCgfISMUAP2/N248B9NNf7abhTCq1m471v+OCaP04JAGE+O33/3pQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxZmGkAsDYv0MaB3iQ25NEIDneS3X2LRTSSDpqy7ewZDDmoZL0H CfIOBA7Y9cc8K9iD84DHVtJPjNHnDdOLZ8YeZk7PxticCRalnPxNhZlCNFePkuqzVKY= X-Gm-Gg: ASbGncsnEYbndhtyNEg2XljtZtLA2q8cXVM22dKWHaELJ62G0KaA2gkEfKhBU4idmOy cOgf/tnGyk5YXcyRUrOn6OmZNeGGbWr4dkGOMA6ZtZLwbHU6Hkdm/ndSZda/8e3UvTuCeGPNCPN di1ELfT2zJJWrRir3XQJhppgZuxhcfzBOnMIkKik6mMCcN+kOM/8ELkLk5SvvNxCSpvCSRUfp9w azoVN6hpU38SSw3rqjnnFw0ossxzk+zd8iScc3bChSZ5Oo9Zt1QZN+FTYn3/Rtokckezp/oCT4k KeRtCs23Rn2vU72MGIL/Kk1TVD8YpK/9y6HFPh9KWOf8mJLhUs2a0qDq7AQpcSSgQgbOwMagAId gAqpQtyRlJ6FfjNG1B2uRFsonkNwQy4ajQaRYowkez/FhIUHkfd5bf3bLUO+TBnIHybnpTiwEgi fqG2Gt+l7K/J7ajtMc X-Google-Smtp-Source: AGHT+IG0+nc2u44sOAgm3B9nfVuClMzbG47n0TMuwtBie7ZMDQ8A+R83vkbvW2yFaDixREsq5GJsjA== X-Received: by 2002:a05:6000:2310:b0:42b:3661:305c with SMTP id ffacd0b85a97d-42cb1fc8f6cmr2298825f8f.55.1763552364075; Wed, 19 Nov 2025 03:39:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42b53e85627sm39489729f8f.16.2025.11.19.03.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 03:39:23 -0800 (PST) Date: Wed, 19 Nov 2025 14:39:20 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Haotian Zhang , herbert@gondor.apana.org.au, davem@davemloft.net Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: Re: [PATCH v2] crypto: sa2ul: Add error handling for DMA metadata retrieval Message-ID: <202511191706.iBCITtX2-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251117023117.90-1-vulab@iscas.ac.cn> Hi Haotian, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Haotian-Zhang/crypto-sa2ul-Add-error-handling-for-DMA-metadata-retrieval/20251117-103258 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master patch link: https://lore.kernel.org/r/20251117023117.90-1-vulab%40iscas.ac.cn patch subject: [PATCH v2] crypto: sa2ul: Add error handling for DMA metadata retrieval config: m68k-randconfig-r073-20251119 (https://download.01.org/0day-ci/archive/20251119/202511191706.iBCITtX2-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202511191706.iBCITtX2-lkp@intel.com/ smatch warnings: drivers/crypto/sa2ul.c:1064 sa_aes_dma_in_callback() warn: 'mdptr' can also be NULL drivers/crypto/sa2ul.c:1394 sa_sha_dma_in_callback() warn: 'mdptr' can also be NULL drivers/crypto/sa2ul.c:1709 sa_aead_dma_in_callback() warn: 'mdptr' can also be NULL vim +/mdptr +1064 drivers/crypto/sa2ul.c 7694b6ca649fea Keerthy 2020-07-13 1039 static void sa_aes_dma_in_callback(void *data) 7694b6ca649fea Keerthy 2020-07-13 1040 { aedf818b1f1965 Yu Zhe 2023-03-17 1041 struct sa_rx_data *rxd = data; 7694b6ca649fea Keerthy 2020-07-13 1042 struct skcipher_request *req; 7694b6ca649fea Keerthy 2020-07-13 1043 u32 *result; 7694b6ca649fea Keerthy 2020-07-13 1044 __be32 *mdptr; 7694b6ca649fea Keerthy 2020-07-13 1045 size_t ml, pl; 7694b6ca649fea Keerthy 2020-07-13 1046 int i; 7694b6ca649fea Keerthy 2020-07-13 1047 00c9211f60db2d Peter Ujfalusi 2020-09-23 1048 sa_sync_from_device(rxd); 7694b6ca649fea Keerthy 2020-07-13 1049 req = container_of(rxd->req, struct skcipher_request, base); 7694b6ca649fea Keerthy 2020-07-13 1050 7694b6ca649fea Keerthy 2020-07-13 1051 if (req->iv) { 7694b6ca649fea Keerthy 2020-07-13 1052 mdptr = (__be32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl, 7694b6ca649fea Keerthy 2020-07-13 1053 &ml); The Kconfig file should probably enforce that CONFIG_DMA_ENGINE is set. Otherwise dmaengine_desc_get_metadata_ptr() returns NULL. 90d79e983588a8 Haotian Zhang 2025-11-17 1054 if (IS_ERR(mdptr)) { 90d79e983588a8 Haotian Zhang 2025-11-17 1055 dev_err(rxd->ddev, "Failed to get AES RX metadata pointer: %ld\n", 90d79e983588a8 Haotian Zhang 2025-11-17 1056 PTR_ERR(mdptr)); 90d79e983588a8 Haotian Zhang 2025-11-17 1057 sa_free_sa_rx_data(rxd); 90d79e983588a8 Haotian Zhang 2025-11-17 1058 skcipher_request_complete(req, PTR_ERR(mdptr)); 90d79e983588a8 Haotian Zhang 2025-11-17 1059 return; 90d79e983588a8 Haotian Zhang 2025-11-17 1060 } 7694b6ca649fea Keerthy 2020-07-13 1061 result = (u32 *)req->iv; 7694b6ca649fea Keerthy 2020-07-13 1062 7694b6ca649fea Keerthy 2020-07-13 1063 for (i = 0; i < (rxd->enc_iv_size / 4); i++) 7694b6ca649fea Keerthy 2020-07-13 @1064 result[i] = be32_to_cpu(mdptr[i + rxd->iv_idx]); 7694b6ca649fea Keerthy 2020-07-13 1065 } 7694b6ca649fea Keerthy 2020-07-13 1066 00c9211f60db2d Peter Ujfalusi 2020-09-23 1067 sa_free_sa_rx_data(rxd); 7694b6ca649fea Keerthy 2020-07-13 1068 7694b6ca649fea Keerthy 2020-07-13 1069 skcipher_request_complete(req, 0); 7694b6ca649fea Keerthy 2020-07-13 1070 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki