linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Nicolas Ferre <nicolas.ferre@microchip.com>,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	 Russell King <linux@armlinux.org.uk>
Cc: linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing
Date: Thu, 20 Nov 2025 15:37:50 -0600	[thread overview]
Message-ID: <20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org> (raw)
In-Reply-To: <20251120-at91-probe-v2-0-8c8592f02e8e@kernel.org>

The Atmel NAND controller driver depends on an SRAM pool and has an
implicit assumption that the SRAM pool has already been created.
Changing the initcall ordering can break this. Unfortunately, fw_devlink
can't save us here as there's not a standard property to track the
dependency. So it's up to deferring probe to save us.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index 83ba4ebd02d4..e60998eb754b 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -2306,7 +2306,7 @@ atmel_hsmc_nand_controller_init(struct atmel_hsmc_nand_controller *nc)
 					 "atmel,nfc-sram", 0);
 	if (!nc->sram.pool) {
 		dev_err(nc->base.dev, "Missing SRAM\n");
-		return -ENOMEM;
+		return -EPROBE_DEFER;
 	}
 
 	nc->sram.virt = (void __iomem *)gen_pool_dma_alloc(nc->sram.pool,

-- 
2.51.0


  reply	other threads:[~2025-11-20 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 21:37 [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls Rob Herring (Arm)
2025-11-20 21:37 ` Rob Herring (Arm) [this message]
2025-11-21 14:15   ` [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing Miquel Raynal
2025-11-20 21:37 ` [PATCH v2 2/3] ARM: at91: Move PM init functions to .init_late hook Rob Herring
2025-11-22 15:37   ` Claudiu Beznea
2025-12-09 22:39     ` Rob Herring
2025-12-10  8:04       ` Claudiu Beznea
2025-11-20 21:37 ` [PATCH v2 3/3] ARM: at91: remove unnecessary of_platform_default_populate calls Rob Herring (Arm)
2025-11-22 15:37   ` Claudiu Beznea
2025-12-12 17:37 ` [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).