Re: [RFC net-next v1 0/7] highly rfc macb usrio/tsu patches

Conor Dooley
2025-11-20T16:31:19Z

[-- Attachment #1: Type: text/plain, Size: 3357 bytes --]

On Thu, Nov 20, 2025 at 04:26:02PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Hey folks,
>
> After doing some debugging of broken tsu/ptp support on mpfs, I've come
> up with some very rfc patches that I'd like opinions on - particularly
> because they impact a bunch of platforms that I have no access to at all
> and have no idea how they work. The at91 platforms I can just ask
> Nicolas about (and he already provided some info directly, so I'm not
> super worried at least about the usrio portion there) but the others
> my gut says are likely incorrect in the driver at the moment.
>
> These patches *are* fairly opinionated and not necessarily technically
> correct or w/e. The only thing I am confident in saying that they are is
> more deliberate than what's being done at the moment.
>
> At the very least, it'd be good of the soc vendor folks could check
> their platforms and see if their usrio stuff actually lines up with what
> the driver currently calls "macb_default_usrio". Ours didn't and it was
> a nasty surprise.
>
> Cheers,
> Conor.
>
> CC: Valentina.FernandezAlanis@microchip.com
> CC: Andrew Lunn <andrew+netdev@lunn.ch>
> CC: David S. Miller <davem@davemloft.net>
> CC: Eric Dumazet <edumazet@google.com>
> CC: Jakub Kicinski <kuba@kernel.org>
> CC: Paolo Abeni <pabeni@redhat.com>
> CC: Rob Herring <robh@kernel.org>
> CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
> CC: Conor Dooley <conor+dt@kernel.org>
> CC: Daire McNamara <daire.mcnamara@microchip.com>
> CC: Paul Walmsley <pjw@kernel.org>
> CC: Palmer Dabbelt <palmer@dabbelt.com>
> CC: Albert Ou <aou@eecs.berkeley.edu>
> CC: Alexandre Ghiti <alex@ghiti.fr>
> CC: Nicolas Ferre <nicolas.ferre@microchip.com>
> CC: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> CC: Richard Cochran <richardcochran@gmail.com>
> CC: Samuel Holland <samuel.holland@sifive.com>
> CC: netdev@vger.kernel.org
> CC: devicetree@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: linux-riscv@lists.infradead.org
> CC: Neil Armstrong <narmstrong@baylibre.com>

The perils of grabbing addresses from git blame..
+CC Neil @ linaro.

> CC: Dave Stevenson <dave.stevenson@raspberrypi.com>
> CC: Sean Anderson <sean.anderson@linux.dev>
> CC: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
> CC: Abin Joseph <abin.joseph@amd.com>
>
> Conor Dooley (7):
> riscv: dts: microchip: add tsu clock to macb on mpfs
> net: macb: warn on pclk use as a tsu_clk fallback
> net: macb: rename macb_default_usrio to at91_default_usrio as not all
> platforms have mii mode control in usrio
> net: macb: np4 doesn't need a usrio pointer
> dt-bindings: net: macb: add property indicating timer adjust mode
> net: macb: afaict, the driver doesn't support tsu timer adjust mode
> net: macb: add mpfs specific usrio configuration
>
> .../devicetree/bindings/net/cdns,macb.yaml | 15 +++
> arch/riscv/boot/dts/microchip/Makefile.orig | 26 ++++
> arch/riscv/boot/dts/microchip/mpfs.dtsi | 8 +-
> drivers/net/ethernet/cadence/macb.h | 3 +
> drivers/net/ethernet/cadence/macb_main.c | 123 +++++++++++-------
> 5 files changed, 125 insertions(+), 50 deletions(-)
> create mode 100644 arch/riscv/boot/dts/microchip/Makefile.orig
>
> --
> 2.51.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]