From: Shivank Garg <shivankg@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
Zach O'Keefe <zokeefe@google.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>,
Shivank Garg <shivankg@amd.com>
Subject: [PATCH V2 0/2] mm/khugepaged: fix dirty page handling for MADV_COLLAPSE
Date: Thu, 20 Nov 2025 06:50:46 +0000 [thread overview]
Message-ID: <20251120065043.41738-6-shivankg@amd.com> (raw)
MADV_COLLAPSE on file-backed mappings fails with -EINVAL when TEXT pages
are dirty. This may affect real scenarios: package/container updates,
executing binaries immediately after writing them, etc.
The issue is that collapse_file() triggers async writeback and returns
SCAN_FAIL (maps to -EINVAL), expecting khugepaged to revisit later. But
MADV_COLLAPSE is synchronous and userspace expects immediate success or a
clear retry signal.
Reproduction:
- Copy 2MB-aligned executable to freshly mounted XFS/ext4
- Call MADV_COLLAPSE on .text section
- First call fails with -EINVAL (text pages dirty from copy)
- Second call succeeds (async writeback completed)
Issue Report:
https://lore.kernel.org/all/4e26fe5e-7374-467c-a333-9dd48f85d7cc@amd.com
v2:
- Move writeback to madvise_collapse() (better abstraction, proper
mmap_lock handling and does VMA revalidation after I/O) (Lorenzo)
- Rename to SCAN_PAGE_DIRTY to SCAN_PAGE_NOT_CLEAN and extend its use
for all dirty/writeback folio cases that previously returned incorrect
results (Dev)
v1: https://lore.kernel.org/all/20251110113254.77822-1-shivankg@amd.com
Shivank Garg (2):
mm/khugepaged: do synchronous writeback for MADV_COLLAPSE
mm/khugepaged: map dirty/writeback pages failures to EAGAIN
include/trace/events/huge_memory.h | 3 ++-
mm/khugepaged.c | 34 +++++++++++++++++++++++++++---
2 files changed, 33 insertions(+), 4 deletions(-)
base-commit: 4a3f8fc3adb7046e44bd1feb2f5c5fe95296894f
--
2.43.0
next reply other threads:[~2025-11-20 6:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 6:50 Shivank Garg [this message]
2025-11-20 6:50 ` [PATCH V2 1/2] mm/khugepaged: do synchronous writeback for MADV_COLLAPSE Shivank Garg
2025-11-20 13:01 ` Lance Yang
2025-11-21 6:27 ` Garg, Shivank
2025-11-20 13:35 ` David Hildenbrand (Red Hat)
2025-11-21 6:27 ` Garg, Shivank
2025-11-20 6:50 ` [PATCH V2 2/2] mm/khugepaged: map dirty/writeback pages failures to EAGAIN Shivank Garg
2025-11-20 8:03 ` Dev Jain
2025-11-20 8:17 ` Garg, Shivank
2025-11-20 9:55 ` Dev Jain
2025-11-20 12:24 ` Lance Yang
2025-11-20 13:29 ` David Hildenbrand (Red Hat)
2025-11-21 6:15 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120065043.41738-6-shivankg@amd.com \
--to=shivankg@amd.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=npache@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox