From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E502F60A1 for ; Thu, 20 Nov 2025 08:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763628847; cv=none; b=L0pKpMTo+X/7NssI84yZNxnV5t67oL2Ko/z0bIzhAT7ZwEaYWl0gsI1760F+Ukqb0JWImalkCmytyaabSSB5/LSVWcmHf9JctmHPe69sE/SbrwKUtQkTUeGfX5Vw2D55uT0Hr0T8xYABeJp70eluWGFNShlgjB6Tjuo+EMk0K1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763628847; c=relaxed/simple; bh=t0/eluiTxYqv6jtszoBxWT288+RvH7GK0pgRm2w0bxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WzHnXLZm+hylEMEqxI+rVy56y9velar5DTjMMIRb2yV6iyQFpEGdIy5kvVP0Q3SsolZ8aCT9Vvpu8XJHgynacl70adaKv8plvTnGGyQadWHN5rOVgs0e7Lr7lBC0DANmsYvDXvKLeOzkM8L/1eEAo/FBGInj3KLFbC7fXO8N51Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pbx2fygN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pbx2fygN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D650C4CEF1; Thu, 20 Nov 2025 08:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763628846; bh=t0/eluiTxYqv6jtszoBxWT288+RvH7GK0pgRm2w0bxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pbx2fygNzco0KWkXDtTPJEUKmS7RfZ/ahcvRbC+h8WYM5a71B7b/yOt1TXCJDQ84E a9AFDU3NCCvwYdKp72uMMEj6tQ9Q98mhZlb5uYyIj83WW6/QIEsVcNgMzc80hmocL7 Xmod85B7/5xbshB2B5lIBIccGIZfrQ4lTluGQMCVmRF2I1OgvNqVYyR1b7AcuisvHS sI10dbRzxoJULr73aQcdzzvGf1BPtK5xnnjEEVDgeuekoGbKjiStsnKdDJv1SOsqV9 X9c1oWJhhhKGBLU00/4xpdrjSXhKex7QLEBDA0ZU68YuBLXN3mtXiVAWie+LcDURUH rZybjWnrNE4wg== Date: Thu, 20 Nov 2025 08:54:02 +0000 From: Lee Jones To: Andy Shevchenko Cc: Binbin Zhou , linux-kernel@vger.kernel.org, Chong Qiao Subject: Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources Message-ID: <20251120085402.GW1949330@google.com> References: <20251113162713.3143777-1-andriy.shevchenko@linux.intel.com> <20251113162713.3143777-2-andriy.shevchenko@linux.intel.com> <20251119164703.GU1949330@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, 19 Nov 2025, Andy Shevchenko wrote: > On Wed, Nov 19, 2025 at 04:47:03PM +0000, Lee Jones wrote: > > On Thu, 13 Nov 2025, Andy Shevchenko wrote: > > > > > The mixing of managed and non-managed resources may lead to possible > > > use-after-free bugs. In this driver the problematic part is the device > > > functionality that may just have gone behind the functions back, e.g., > > > when interrupt is being served. Fix this by switching to managed resources > > > for PCI. > > > > > > Fixes: 91a3e1f5453a ("mfd: ls2kbmc: Check for devm_mfd_add_devices() failure") > > > Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support") > > > Reviewed-by: Binbin Zhou > > > Signed-off-by: Andy Shevchenko > > > --- > > > drivers/mfd/ls2k-bmc-core.c | 28 +++++++--------------------- > > > 1 file changed, 7 insertions(+), 21 deletions(-) > > > > Still doesn't apply. I'm getting lots of conflicts. > > > > What base are you on? > > Linux Next which includes your -fixes branch. You probably need to merge either > it or v6.18-rc6 to the -next. Then the v1 will be okay to apply. Ah, yes, that explains it. > The bottom line is that without doing that we will have conflicts either in > Linux Next followed by merging by Linus or in your branches locally before > going to the above mentioned. > > Another possibility is cherry-pick patches from -fixes to -next. > > And alternative is to wait for -rc1 and rebase this on top of and > apply then. Yes, if there is no urgency, we can wait for the next merge window. -- Lee Jones [李琼斯]