From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Waiman Long <longman@redhat.com>
Cc: Gabriele Monaco <gmonaco@redhat.com>
Subject: [PATCH v16 3/7] timers/migration: Use scoped_guard on available flag set/clear
Date: Thu, 20 Nov 2025 15:56:49 +0100 [thread overview]
Message-ID: <20251120145653.296659-4-gmonaco@redhat.com> (raw)
In-Reply-To: <20251120145653.296659-1-gmonaco@redhat.com>
Cleanup tmigr_clear_cpu_available() and tmigr_set_cpu_available() to
prepare for easier checks on the available flag.
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
kernel/time/timer_migration.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
index 3325ca7989b3..a01c7f8bdf52 100644
--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -1440,17 +1440,17 @@ static int tmigr_clear_cpu_available(unsigned int cpu)
u64 firstexp;
cpumask_clear_cpu(cpu, tmigr_available_cpumask);
- raw_spin_lock_irq(&tmc->lock);
- tmc->available = false;
- WRITE_ONCE(tmc->wakeup, KTIME_MAX);
+ scoped_guard(raw_spinlock_irq, &tmc->lock) {
+ tmc->available = false;
+ WRITE_ONCE(tmc->wakeup, KTIME_MAX);
- /*
- * CPU has to handle the local events on his own, when on the way to
- * offline; Therefore nextevt value is set to KTIME_MAX
- */
- firstexp = __tmigr_cpu_deactivate(tmc, KTIME_MAX);
- trace_tmigr_cpu_unavailable(tmc);
- raw_spin_unlock_irq(&tmc->lock);
+ /*
+ * CPU has to handle the local events on his own, when on the way to
+ * offline; Therefore nextevt value is set to KTIME_MAX
+ */
+ firstexp = __tmigr_cpu_deactivate(tmc, KTIME_MAX);
+ trace_tmigr_cpu_unavailable(tmc);
+ }
if (firstexp != KTIME_MAX) {
migrator = cpumask_any(tmigr_available_cpumask);
@@ -1469,13 +1469,13 @@ static int tmigr_set_cpu_available(unsigned int cpu)
return -EINVAL;
cpumask_set_cpu(cpu, tmigr_available_cpumask);
- raw_spin_lock_irq(&tmc->lock);
- trace_tmigr_cpu_available(tmc);
- tmc->idle = timer_base_is_idle();
- if (!tmc->idle)
- __tmigr_cpu_activate(tmc);
- tmc->available = true;
- raw_spin_unlock_irq(&tmc->lock);
+ scoped_guard(raw_spinlock_irq, &tmc->lock) {
+ trace_tmigr_cpu_available(tmc);
+ tmc->idle = timer_base_is_idle();
+ if (!tmc->idle)
+ __tmigr_cpu_activate(tmc);
+ tmc->available = true;
+ }
return 0;
}
--
2.51.1
next prev parent reply other threads:[~2025-11-20 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 14:56 [PATCH v16 0/7] timers/migration: Exclude isolated cpus from hierarchy Gabriele Monaco
2025-11-20 14:56 ` [PATCH v16 1/7] timers/migration: Rename 'online' bit to 'available' Gabriele Monaco
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Gabriele Monaco
2025-11-20 14:56 ` [PATCH v16 2/7] timers/migration: Add mask for CPUs available in the hierarchy Gabriele Monaco
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Gabriele Monaco
2025-11-20 14:56 ` Gabriele Monaco [this message]
2025-11-20 19:22 ` [tip: timers/core] timers/migration: Use scoped_guard on available flag set/clear tip-bot2 for Gabriele Monaco
2025-11-20 14:56 ` [PATCH v16 4/7] cgroup/cpuset: Rename update_unbound_workqueue_cpumask() to update_isolation_cpumasks() Gabriele Monaco
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Gabriele Monaco
2025-11-20 14:56 ` [PATCH v16 5/7] sched/isolation: Force housekeeping if isolcpus and nohz_full don't leave any Gabriele Monaco
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Gabriele Monaco
2025-11-20 14:56 ` [PATCH v16 6/7] cpumask: Add initialiser to use cleanup helpers Gabriele Monaco
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Yury Norov
2025-11-20 14:56 ` [PATCH v16 7/7] timers/migration: Exclude isolated cpus from hierarchy Gabriele Monaco
2025-11-20 15:21 ` Thomas Gleixner
2025-11-20 15:23 ` Gabriele Monaco
2025-11-20 15:34 ` Thomas Gleixner
2025-11-20 16:12 ` Frederic Weisbecker
2025-11-20 19:18 ` Thomas Gleixner
2025-11-20 19:22 ` [tip: timers/core] " tip-bot2 for Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120145653.296659-4-gmonaco@redhat.com \
--to=gmonaco@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox