From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7551CEAC2 for ; Thu, 20 Nov 2025 17:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763658469; cv=none; b=hxFK/XttHjyrC0713qVFK4e3kqZTgEqtNqOHJgkNHXm92MUv7/UKFyXqvTmSm/7p6SOJK/BkWpnxbyxMYFuLmHQwcjs7i7wksHledQQw9/4xlY5LYcs+2vOv0RiFO8vuenYaMOu0IXqO2csq5GfZ6vwfuiVROdF/1XcPijUkUho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763658469; c=relaxed/simple; bh=nYHZ0ZJewemOT8qDaTBfHHrFX8DaMBM2yLpg6PNR6MU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZRgiPYbrCFaJA2/odpCIcT4qo9OlDJ1QtwwsnYHdT5O7aEMEEbBzDd7ORmWAHFXzJX5retb/VHEOgkZ6u463sk5kPi/+FM5U5HWDQ+vWE8F82foKXvKF1JTQEMm0O3Aq5BikVs4r+OO7hglreV+ebX28iIj9YO+Yy77YmOEuPfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=WvHLMXCR; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="WvHLMXCR" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8804650ca32so9447476d6.0 for ; Thu, 20 Nov 2025 09:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1763658465; x=1764263265; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tuzsEMawQKHicA8bY4mlwm9qmzQtvglQsEjWLmxJJkE=; b=WvHLMXCRd3jf3As59wIejANUO3XkygcSEzY2OxpKci140YEguSwOLq84LLOq6mku4z eBPdhdL1lxJ3K1GI2hFYRbRIX8+878vDUXhe8eIxq3d5rQ2q9RZl34SFRo6die6wXxA5 6Tv9O9KwutEeS0RJN6iOrNrr2L8676lgY7Rg5OYO0XcGDHW480RRhJuCItAxLwOiBZFj ImxC7/Ry41yyWth5j8nFAHfDOkzMPq1ybgvEVLEz2gyGIllKD6OA5U7IkIXy95aY8DBY vAwXQq2s5iSZFmalApIrt7tHy57z+e3rfB/SA3fngSiZFiwZMf+iN1KuRPk39Nc9TMQr AoTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763658465; x=1764263265; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tuzsEMawQKHicA8bY4mlwm9qmzQtvglQsEjWLmxJJkE=; b=aA+TT750DgqhQvmZrZBlblFLFIzEvFegSC1i1hzh5yzM+Mcx8O2mc2nicp0TZ052LS 9O1+P4jq8SbwUE5PsE5cGoiqmN2Em1JBEeivyHYtSQ9hT6n6OvZb6ppegnw00FnJ54DU geWeoK4BtOicM1/QttFAaeM7IJHNAmtN7K2klPzMJF1bySWEz5L4stHe0a1wlHg3JqMr 7pPPAathDkTaRBmkV1lALD1io7f/WSbWGDCkN9nhpn6bazdZfiwFlDKtxoCp/yWvj8sF 3TjeUBJr3uk6QSATYv4lPZn7VkEQl+/Q+ruuoQSl8+qfNTlo8O4v4sGtYT8bIC6pZyDf J7BQ== X-Forwarded-Encrypted: i=1; AJvYcCVCKLCsN3lJJ1lMFv5iC/JYxhzVVMQ6mK+WrzHCP/6j1/62gNIm+49Ftr/3JQxVDZAjHsZ575xFfO1zQrI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd+uXJ2aoXRRIU1mdi4cbwRdkdqUqURsk0phwsICswUZNy5Nm1 GzzTJq0OnSNGU6c5zvgM6RNcPGG8Sg6UokCJLPqhS4m6pjwVW2hWyEGdbLpnz/Glk5U= X-Gm-Gg: ASbGnctfYMWqR6Ch3Qw65OWjHcjf/M14u3EzYIcMhbaLL7MNBMPgcgiovupRWJzS3j7 c8XBl/fE6FdhwVvdjc7uvgKkNvi6wX3P1AN79NcPNcx/qiTYBl1hNA7sGCr6Nn9MKI2Dw8ouisJ TzLAHLQpRjLtw8BW613qBa1JVBb5lKgf5JmnlOzU51rRjxSPPLQJNPSS/gltXT6HvGTjGeKIIS6 WaUbYeU7L3FBTGgJl8VtVAMnqVrg0ZiDGugKNcXYrnNeMTRYgWABpIYgV70vu+R7wQQIRVAWwAP leUwgzIyziM/FIJEzQV9ZUBNJcAWDZWgLnCTaRE5uZiE30LkkXLBIoqearxBV5sBclvUz5ETfmY FXX+Nju7NVFzRniXVFhiGs32uTuWhShEwjZC65uRDemcJMIm/aTyMK5XfIO3wgIa0agn1it686s kypVQ4F5/R9i4/DOparstwcgU7XjPPKuWDNUiJK2u1roHKkQVkEKpCzLb0 X-Google-Smtp-Source: AGHT+IEqjS4uS4xfyJNnG+y2iffk7Jh5hggdrDyF6w+tVPTXp3+LUWZ5E2fj48EBD86SRpKWdaJn2g== X-Received: by 2002:a05:6214:2f01:b0:880:4961:3aef with SMTP id 6a1803df08f44-88471735cd4mr37815256d6.5.1763658465313; Thu, 20 Nov 2025 09:07:45 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8846e59ec1dsm20926156d6.50.2025.11.20.09.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 09:07:44 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vM88G-000000012QY-0Ibm; Thu, 20 Nov 2025 13:07:44 -0400 Date: Thu, 20 Nov 2025 13:07:44 -0400 From: Jason Gunthorpe To: Geert Uytterhoeven Cc: Joerg Roedel , Will Deacon , Robin Murphy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] genpt: Make GENERIC_PT invisible Message-ID: <20251120170744.GA236839@ziepe.ca> References: <48381c47930d98380871458ca471ea5a7a89aafc.1762956447.git.geert+renesas@glider.be> <20251120164933.GV17968@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251120164933.GV17968@ziepe.ca> On Thu, Nov 20, 2025 at 12:49:33PM -0400, Jason Gunthorpe wrote: > On Wed, Nov 12, 2025 at 03:08:05PM +0100, Geert Uytterhoeven wrote: > > There is no point in asking the user about the Generic Radix Page > > Table API: > > - All IOMMU drivers that use this API already select GENERIC_PT when > > needed, > > - Most users probably do not know what to answer anyway. > > > > Fixes: 7c5b184db7145fd4 ("genpt: Generic Page Table base API") > > Signed-off-by: Geert Uytterhoeven > > --- > > drivers/iommu/generic_pt/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Jason Gunthorpe Actually, it doesn't work :\ $ tools/testing/kunit/kunit.py run --build_dir build_kunit_x86_64 --arch x86_64 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig [13:01:26] Configuring KUnit Kernel ... [13:01:26] Building KUnit Kernel ... Populating config with: $ make ARCH=x86_64 O=build_kunit_x86_64 olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=x86_64 O=build_kunit_x86_64 --jobs=20 ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_IOMMUFD_TEST=y, CONFIG_DEBUG_GENERIC_PT=y, CONFIG_IOMMU_PT_VTDSS=y, CONFIG_IOMMU_PT=y, CONFIG_IOMMU_PT_AMDV1=y, CONFIG_IOMMU_PT_X86_64=y, CONFIG_GENERIC_PT=y, CONFIG_IOMMU_PT_KUNIT_TEST=y Can you add this hunk and send a v2? --- a/drivers/iommu/generic_pt/.kunitconfig +++ b/drivers/iommu/generic_pt/.kunitconfig @@ -1,4 +1,5 @@ CONFIG_KUNIT=y +CONFIG_COMPILE_TEST=y CONFIG_GENERIC_PT=y CONFIG_DEBUG_GENERIC_PT=y CONFIG_IOMMU_PT=y Thanks, Jason