From: Sukrut Heroorkar <hsukrut3@gmail.com>
To: Helge Deller <deller@gmx.de>,
Sukrut Heroorkar <hsukrut3@gmail.com>,
linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER),
dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER),
linux-kernel@vger.kernel.org (open list)
Cc: shuah@kernel.org, david.hunter.linux@gamil.com
Subject: [RFC/RFT PATCH] fbdev: q40fb: request memory region
Date: Thu, 20 Nov 2025 23:32:27 +0530 [thread overview]
Message-ID: <20251120180233.763975-1-hsukrut3@gmail.com> (raw)
The q40fb driver uses a fixed physical address but never reserves
the corresponding I/O region. Reserve the range as suggested in
Documentation/gpu/todo.rst ("Request memory regions in all fbdev drivers").
If the memory cannot be reserved, fail probe with -EBUSY to avoid
conflicting with another user of the same address.
Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
---
Testing: This patch is sent as RFT since Q40 hardware is unavilable and
QEMU does not emulated a Q40 platform. The change is therefore compile-tested
only.
drivers/video/fbdev/q40fb.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/video/fbdev/q40fb.c b/drivers/video/fbdev/q40fb.c
index 1ff8fa176124..7b5c31745041 100644
--- a/drivers/video/fbdev/q40fb.c
+++ b/drivers/video/fbdev/q40fb.c
@@ -101,6 +101,13 @@ static int q40fb_probe(struct platform_device *dev)
info->par = NULL;
info->screen_base = (char *) q40fb_fix.smem_start;
+ if (!request_mem_region(q40fb_fix.smem_start, q40fb_fix.smem_len,
+ "q40fb")) {
+ dev_err(&dev->dev, "cannot reserve video memory at 0x%lx\n",
+ q40fb_fix.smem_start);
+ return -EBUSY;
+ }
+
if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) {
framebuffer_release(info);
return -ENOMEM;
--
2.43.0
next reply other threads:[~2025-11-20 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 18:02 Sukrut Heroorkar [this message]
2025-11-21 10:03 ` [RFC/RFT PATCH] fbdev: q40fb: request memory region Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120180233.763975-1-hsukrut3@gmail.com \
--to=hsukrut3@gmail.com \
--cc=david.hunter.linux@gamil.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox