From: Conor Dooley <conor@kernel.org>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
biju.das.jz@bp.renesas.com, "Peter Rosin" <peda@axentia.se>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v4 01/22] dt-bindings: mux: Remove nodename pattern constraints
Date: Fri, 21 Nov 2025 18:24:03 +0000 [thread overview]
Message-ID: <20251121-spring-slot-ec9fb6887565@spud> (raw)
In-Reply-To: <cb7c28ccf3a1b136e793b48720f816de7d5f75b2.1763737324.git.tommaso.merciai.xr@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]
On Fri, Nov 21, 2025 at 04:11:50PM +0100, Tommaso Merciai wrote:
> The nodename pattern in created an unnecessary restriction that forced
> all mux nodes to be named with the 'mux-controller' prefix.
> This prevented valid use cases where mux functionality is part of other
> hardware blocks that should use more specific naming conventions.
>
> Remove the $nodename pattern constraints from both the 'select' keyword
> and the properties section of the mux-controller schema.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Funnily enough, there's another patch that I saw today that hit this
same thing:
https://lore.kernel.org/all/176373269741.263545.10849918874919174841.robh@kernel.org/
> ---
> v3->v4:
> - New patch.
>
> Documentation/devicetree/bindings/mux/mux-controller.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mux/mux-controller.yaml b/Documentation/devicetree/bindings/mux/mux-controller.yaml
> index 78340bbe4df6..6defb9da10f7 100644
> --- a/Documentation/devicetree/bindings/mux/mux-controller.yaml
> +++ b/Documentation/devicetree/bindings/mux/mux-controller.yaml
> @@ -63,18 +63,12 @@ description: |
>
> select:
> anyOf:
> - - properties:
> - $nodename:
> - pattern: '^mux-controller'
> - required:
> - '#mux-control-cells'
> - required:
> - '#mux-state-cells'
>
> properties:
> - $nodename:
> - pattern: '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
I need to apologise, I told you to delete the wrong thing in my DM
earlier. Only deleting this part was actually required, deleting the
select portion doesn't really do anything for your problem.
What you've done is probably fine though, since anything actually acting
as a mux-controller will have the cells properties.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
> -
> '#mux-control-cells':
> enum: [ 0, 1 ]
>
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-21 18:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 15:11 [PATCH v4 00/22] Add USB2.0 support for RZ/G3E Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 01/22] dt-bindings: mux: Remove nodename pattern constraints Tommaso Merciai
2025-11-21 18:24 ` Conor Dooley [this message]
2025-11-24 8:57 ` Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 02/22] phy: renesas: rcar-gen3-usb2: Use devm_pm_runtime_enable() Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 03/22] phy: renesas: rcar-gen3-usb2: Factor out VBUS control logic Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 04/22] reset: rzv2h-usb2phy: Keep PHY clock enabled for entire device lifetime Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 05/22] dt-bindings: reset: renesas,rzv2h-usb2phy: Add '#mux-state-cells' property Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 06/22] mux: Add driver for Renesas RZ/V2H USB VBUS_SEL mux Tommaso Merciai
2025-11-27 2:28 ` Jian Hui Lee
2025-11-27 9:07 ` Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 07/22] reset: rzv2h-usb2phy: Add support for VBUS mux controller registration Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 08/22] dt-bindings: phy: renesas,usb2-phy: Document USB VBUS regulator Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 09/22] dt-bindings: phy: renesas,usb2-phy: Document mux-states property Tommaso Merciai
2025-11-21 15:11 ` [PATCH v4 10/22] phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 11/22] phy: renesas: rcar-gen3-usb2: Use mux-state for phyrst management Tommaso Merciai
2025-11-25 14:10 ` Geert Uytterhoeven
2025-11-25 15:57 ` Tommaso Merciai
2025-11-26 7:43 ` Geert Uytterhoeven
2025-11-21 15:12 ` [PATCH v4 12/22] dt-bindings: usb: renesas,usbhs: Add RZ/G3E SoC support Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 13/22] dt-bindings: phy: renesas,usb2-phy: Document RZ/G3E SoC Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 14/22] dt-bindings: reset: Document RZ/G3E USB2PHY reset Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 15/22] arm64: dts: renesas: r9a09g057: Add USB2.0 VBUS_SEL mux-controller support Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 16/22] arm64: dts: renesas: r9a09g056: " Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 17/22] arm64: dts: renesas: r9a09g056: Add USB2.0 PHY VBUS internal regulator node Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 18/22] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2 PHY0 VBUS support Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 19/22] arm64: dts: renesas: r9a09g057: Add USB2.0 PHY VBUS internal regulator node Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 20/22] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable USB2 PHY0 VBUS support Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 21/22] arm64: dts: renesas: r9a09g047: Add USB2.0 support Tommaso Merciai
2025-11-21 15:12 ` [PATCH v4 22/22] arm64: dts: renesas: r9a09g047e57-smarc: Enable " Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121-spring-slot-ec9fb6887565@spud \
--to=conor@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan.cameron@huawei.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=ukleinek@kernel.org \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox