From: Greg KH <gregkh@linuxfoundation.org>
To: Sameeksha Sankpal <sameekshasankpal@gmail.com>
Cc: sumanth.gavini@yahoo.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_uac1: fix coding style warnings
Date: Fri, 21 Nov 2025 17:26:48 +0100 [thread overview]
Message-ID: <2025112110-faculty-subtly-84a3@gregkh> (raw)
In-Reply-To: <20251121161240.25818-1-sameekshasankpal@gmail.com>
On Fri, Nov 21, 2025 at 09:42:40PM +0530, Sameeksha Sankpal wrote:
> Fix several checkpatch.pl warnings in f_uac1.c including:
> - replace NULL comparisons with !ptr
> - remove unnecessary parentheses around simple equality checks
> - remove a redundant 'else' after a return statement
> - clean up superfluous blank lines
> - use 'unsigned int' instead of bare 'unsigned'
> - enclose a macro with complex value (USBDHDR) in parentheses
>
> These changes clean up coding style and improve readability without
> altering the behavior of the driver.
>
> Signed-off-by: Sameeksha Sankpal <sameekshasankpal@gmail.com>
Please do not do coding style cleanups all in one patch, nor for
subsystems that maintainers do not explicitly state they want them for,
as it can cause unneeded constant churn.
please do this in drivers/staging/ first.
thanks,
greg k-h
prev parent reply other threads:[~2025-11-21 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 16:12 [PATCH] usb: gadget: f_uac1: fix coding style warnings Sameeksha Sankpal
2025-11-21 16:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112110-faculty-subtly-84a3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sameekshasankpal@gmail.com \
--cc=sumanth.gavini@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox