From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 595E02C08BB for ; Fri, 21 Nov 2025 10:48:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722116; cv=none; b=C4RglIqMMnVxJM6ChWRw9TR0Xvp05KrOYyxcSQfag3k89Hp26RnmKWdpL8hC4nfOoutlXEuawQ0Ovw2Zwh25hjoylQMG5gBqwT9xRDiUFYcIeYu1LQby+X8dVwv9cZoU6M2ym30gSQO1GB/qGPZiNscZFV97sAeW+To7pSeSR74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722116; c=relaxed/simple; bh=seBe1bvRyicocyOUPb1W3SjJkIbWf05QbySGgMDd3w4=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JYuotWcqqOLvkZ7OU8hEwixbzF9ECkbAMXY4+3dRzR6pzq8Xmf/fcCu/xq9aRLzeiDJHBSI+ccaIhauEuYNFsu8E+jzMVBdD6eUhT1x0GOHZka4d85jqB6EvuxoR6JT9qsdpatxNZY2e4OWXS5ZDuWCxAAf8QEhubLQJCccqEYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dCX3y3zXdzJ46bL; Fri, 21 Nov 2025 18:47:42 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 896481402EF; Fri, 21 Nov 2025 18:48:29 +0800 (CST) Received: from localhost (10.122.19.247) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Fri, 21 Nov 2025 10:48:28 +0000 Date: Fri, 21 Nov 2025 10:48:27 +0000 From: Jonathan Cameron To: Randy Dunlap CC: Catalin Marinas , Conor Dooley , , Conor Dooley , Will Deacon , , Arnd Bergmann , Subject: Re: [PATCH v1] arm64, lib: make ARM64 select ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION not GENERIC_CPU_CACHE_MAINTENANCE Message-ID: <20251121104827.00005033@huawei.com> In-Reply-To: References: <20251119-zippy-distinct-1e2a7da7b69b@spud> <20251120-ruined-liability-9ecbf53affd1@spud> <669d4bbb-4011-493c-b056-34e682a1ac26@infradead.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500010.china.huawei.com (7.191.174.240) To dubpeml100005.china.huawei.com (7.214.146.113) On Thu, 20 Nov 2025 15:25:46 -0800 Randy Dunlap wrote: > On 11/20/25 1:40 PM, Catalin Marinas wrote: > > On Thu, Nov 20, 2025 at 12:13:10PM -0800, Randy Dunlap wrote: > >> On 11/20/25 11:29 AM, Conor Dooley wrote: > >>> On Thu, Nov 20, 2025 at 05:30:46PM +0000, Catalin Marinas wrote: > >>>> On Wed, Nov 19, 2025 at 07:08:27PM +0000, Conor Dooley wrote: > >>>>> index 09aec4a1e13f..ac223e627bc5 100644 > >>>>> --- a/lib/Kconfig > >>>>> +++ b/lib/Kconfig > >>>>> @@ -544,8 +544,9 @@ config ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION > >>>>> bool > >>>>> > >>>>> config GENERIC_CPU_CACHE_MAINTENANCE > >>>>> - bool > >>>>> - select ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION > >>>>> + def_bool y > >>>>> + depends on ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION > >>>>> + depends on ARM64 > >>>> > >>>> That's what we do if GENERIC_CPU_CACHE_MAINTENANCE depends on some arch > >>>> code but that's not the case here. GENERIC_CPU_CACHE_MAINTENANCE is an > >>>> alternative implementation that an arch can select if it does not > >>>> provide its own. I find the current code without the above patch better. > >>> > >>> Right, I am going to leave it as-is for now then. That's both you and I > >>> (and presumably Jonathan) finding the current form more natural. Sorry > >>> Randy! > >> > >> Thanks. I tried. > >> > >> I still say that it makes no sense for something generic > >> (GENERIC_CPU_CACHE_MAINTENANCE in lib/Kconfig) to inform the > >> config system that the config has something $ARCH-specific > >> (ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION). > > > > Yes, that's not great either but the solution with the GENERIC depending > > on ARCH does work since there's no actual dependency between them. > > > > As an alternative, I'm happy for arm64 to select both the ARCH and > > GENERIC options if you think that works better. > > > > Yes, I think that would be much better. > Thanks. > I'm fine with that as well (was where we were in earlier versions). I'm offline for 10 days from tomorrow, but wangyushan +CC has been heavily involved in this series throughout if we need to test anything etc. For a patch that is basically just (this to me seems fine to squash as well if that is easier) Acked-by: Jonathan Cameron diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 893e0af0bc51..b4507eeabc4c 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -20,6 +20,7 @@ config ARM64 select ARCH_ENABLE_SPLIT_PMD_PTLOCK if PGTABLE_LEVELS > 2 select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE select ARCH_HAS_CACHE_LINE_SIZE + select ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION select ARCH_HAS_CC_PLATFORM select ARCH_HAS_CURRENT_STACK_POINTER select ARCH_HAS_DEBUG_VIRTUAL diff --git a/lib/Kconfig b/lib/Kconfig index e11136d188ae..2923924bea78 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -544,7 +544,6 @@ config ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION config GENERIC_CPU_CACHE_MAINTENANCE bool - select ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION config ARCH_HAS_MEMREMAP_COMPAT_ALIGN bool If not I'm guessing no one will mind too much if we tidy this up post or late in merge window. Thanks, Jonathan