Re: [PATCH v2] kbuild: Support directory targets for building DTBs

Nathan Chancellor
2025-11-21T22:20:35Z

On Fri, Nov 21, 2025 at 08:42:34PM +0100, Nicolas Schier wrote:
> Using '$(filter )' instead of '$(findstring )' reduces the risk of false
> positives, e.g.:
>
> dtb-targets := %/dts %.dtb %.dtbo dtbs dtbs_check
> ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)

Oh yeah, that would seem to clear up my concerns.

> With (something like) that:
> Tested-by: Nicolas Schier <nsc@kernel.org>
> Acked-by: Nicolas Schier <nsc@kernel.org>

Agreed.

Acked-by: Nathan Chancellor <nathan@kernel.org>

> But [1] seems to break this patch.
>
> [1]: https://lore.kernel.org/linux-kbuild/20251120140645.478623-1-thomas.de_schampheleire@nokia.com

Yeah, that will need to be coordinated, I cc'd Rob on that change for
him to take a look as well.

Cheers,
Nathan