[PATCH] platform/x86: asus-armoury: fix only DC tunables being available

[PATCH] platform/x86: asus-armoury: fix only DC tunables being available

[Denis Benato]

Module asus-armoury must use  AC tunables to check availability
of power-related firmware attributes: fix missing attributes
by using AC attributes instead of DC.

Signed-off-by: Denis Benato <denis.benato@linux.dev>
---
 drivers/platform/x86/asus-armoury.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 5106e8a41e25..9c1a9ad42bc4 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
 
 static int asus_fw_attr_add(void)
 {
-	const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
+	const struct rog_tunables *const ac_rog_tunables =
+		asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
 	const struct power_limits *limits;
 	bool should_create;
 	const char *name;
-- 
2.52.0

Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available

[Denis Benato]

On 11/23/25 16:05, Denis Benato wrote:
> Module asus-armoury must use  AC tunables to check availability
No idea why I missed the double space here.

Do I resend a corrected version? Should checkpatch.pl also check for this?
> of power-related firmware attributes: fix missing attributes
> by using AC attributes instead of DC.
>
> Signed-off-by: Denis Benato <denis.benato@linux.dev>
> ---
>  drivers/platform/x86/asus-armoury.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5106e8a41e25..9c1a9ad42bc4 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
>  
>  static int asus_fw_attr_add(void)
>  {
> -	const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
> +	const struct rog_tunables *const ac_rog_tunables =
> +		asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
>  	const struct power_limits *limits;
>  	bool should_create;
>  	const char *name;

Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available

[Ilpo Järvinen]

On Sun, 23 Nov 2025, Denis Benato wrote:
> On 11/23/25 16:05, Denis Benato wrote:
> > Module asus-armoury must use  AC tunables to check availability
> No idea why I missed the double space here.
> 
> Do I resend a corrected version? Should checkpatch.pl also check for this?

Thanks for the heads up.

I can take care of it while applying (and if I happen to forget the sky 
is not going to fall :-)).

-- 
 i.


> > of power-related firmware attributes: fix missing attributes
> > by using AC attributes instead of DC.
> >
> > Signed-off-by: Denis Benato <denis.benato@linux.dev>
> > ---
> >  drivers/platform/x86/asus-armoury.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> > index 5106e8a41e25..9c1a9ad42bc4 100644
> > --- a/drivers/platform/x86/asus-armoury.c
> > +++ b/drivers/platform/x86/asus-armoury.c
> > @@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
> >  
> >  static int asus_fw_attr_add(void)
> >  {
> > -	const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
> > +	const struct rog_tunables *const ac_rog_tunables =
> > +		asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
> >  	const struct power_limits *limits;
> >  	bool should_create;
> >  	const char *name;
> 

Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available

[Ilpo Järvinen]

On Sun, 23 Nov 2025 16:05:35 +0100, Denis Benato wrote:

> Module asus-armoury must use  AC tunables to check availability
> of power-related firmware attributes: fix missing attributes
> by using AC attributes instead of DC.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: asus-armoury: fix only DC tunables being available
      commit: f72c8ab57927653199da6e35405eadffb40d7e54

--
 i.