From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-b6-smtp.messagingengine.com (flow-b6-smtp.messagingengine.com [202.12.124.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF684154BF5; Sun, 23 Nov 2025 06:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763878969; cv=none; b=d9OhG2VjDHKpl/HuIDNZS+RzUuwaSm8lqk9Jzlj9Lq/u+CAxF3Qr3SEIgwjuftUOH8X2NQg9JRWRlYIIQH9hlX1zkk6L+cki+ZGD5C6NlIw2R8t1/9V5+TiSdnJMn1ndBvQrsfEpVCXPLZUa/uDKjWkxtJl58KVf5n4/ZzyR9CA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763878969; c=relaxed/simple; bh=NpJ2TrZ2fxiFa64xgKbdpladtq8k2tsnrOySZln8RFY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d1q4Ttt6CnWNubXmvQH0ICG+tW1YotKCDTVlLP+4e8PGQeTxypekC57QgnzztlUnLwhFGPJ0oa6zgiI7T9/G0tQi2C1G/kQH7XgtuZ0ab+B12A+oeGsrz7jS1cg2auEmYqEPJWWaf4XjZiQyE61kle/mdSmyPtZ8akrs7TGbAHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b=KCKXSbqt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=eXWq3xTW; arc=none smtp.client-ip=202.12.124.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="KCKXSbqt"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="eXWq3xTW" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id E25D5130010A; Sun, 23 Nov 2025 01:22:44 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 23 Nov 2025 01:22:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1763878964; x=1763886164; bh=F68B6sDYvZaZruZD9EYtEFdkvU0b/sWEl4wjKc2fc/o=; b= KCKXSbqtghoGkk33nPGn/n09Q8/A6aKpIU5wFLUrI3uxJxLDRYsdb8o73C8iJ2/O fDLD9xq+NDaofsQd/pGbw4Ghy+UFbuYNN++rEAfinc/DfXZ/Tgzr5P2NFzTj3HiJ La/eSPJWOorUjKaJNCwgw8G78lfetMmpgS7Om2LA1jo415S+OYkKTaUXD8HBUOS3 eU0B+VhAV1HmIB16zZncL9s2OhskgFNznx84s4Mq4V8ptHejFbMcMI19zAC+TpZn YwGkwb6U00u6+S5a0g9T1b3LObRzoHPB0JA9BvCQQhyFJHvVRRid0+qcaPO9YSYT jVFWuVnHdE8TBr2HFaMRuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763878964; x= 1763886164; bh=F68B6sDYvZaZruZD9EYtEFdkvU0b/sWEl4wjKc2fc/o=; b=e XWq3xTWlVRdH2/ipSSmxESRyasrjxZp73yYYe3HlaYTBvTMMNR+jq+U2PBfCJdZG Z3N2wxW39vxeJ7hsgX1RdRUWVgMG5WuTYMB4jpmo2+bszpFMcO4a+z4VGJCgmCAd YYNdb2ZxKfOkF6DNxwZQNuUpk9XnJkGUR/doVS3Vq13Xp3uBvfwgLbxS2n+keIPL gYIOh124uBa0WOVbxq4ixndx/cxLetqFrYl1f7vrnVtZuUiX8FuWzdJAnhmGDEiQ e88bup/L4UKJYurS9Jud+8CdaGb9Z+6dgbsOCN++sqHjVE43Bhl/1Yreg96nOeuK D+Ke9dtjFFhKY1Kr7Ap+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvfeegleelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeelkeehje ejieehjedvteehjeevkedugeeuiefgfedufefgfffhfeetueeikedufeenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmpdhnsggprhgtphhtthhopeef vddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgrrhhkuhhsrdgvlhhfrhhinh hgseifvggsrdguvgdprhgtphhtthhopehmrghkvgdvgeesihhstggrshdrrggtrdgtnhdp rhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtth hopegrnhgurhgvfieslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehflhhorhhirghnrdhfrghinhgvlhhlihessghrohgruggtohhmrdgt ohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprg gsvghnihesrhgvughhrghtrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Nov 2025 01:22:42 -0500 (EST) Date: Sun, 23 Nov 2025 07:22:38 +0100 From: Greg KH To: Markus Elfring Cc: make24@iscas.ac.cn, netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Rob Herring , Simon Horman , Stephen Hemminger , Vladimir Oltean , stable@vger.kernel.org, LKML , Andrew Morton Subject: Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse_of Message-ID: <2025112332-moonscape-varmint-86b1@gregkh> References: <20251121035130.16020-1-make24@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Nov 22, 2025 at 08:58:12PM +0100, Markus Elfring wrote: > … > > returned structure, which should be balanced with a corresponding > > put_device() when the reference is no longer needed. > … > > * Would a corresponding imperative wording become helpful for an improved change description? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94 > > * How do you think about to omit an extra check for the variable “err” > in the affected if branch because it can always be returned here? > > * Would it be helpful to append parentheses to the function name in the summary phrase? > > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot