From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9D672628 for ; Mon, 24 Nov 2025 18:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764008276; cv=none; b=WMzP/Cq2m1R2DwDAULrx+/yqD6kF6AfC5zuspD0H3o4wLm6NKCd/zL4pni1PrtWK2thBz9c4AYgRUCYJsXvywAACttjkdbrqGrfv1EEFIAc1lw8J8keSrTFf5RCBNRcqxMRzOvZFdd/YJtoVqO5jRL12p+50H/auWBOYoUrE5s4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764008276; c=relaxed/simple; bh=SE3enJ3+tdceVCfps+NDycMuiznsYPCmCITL3XMF+YY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FnL66tMjRdP9niP0W0OeHU7kynoUUJ71SiGTLl+X10Ij9UUFQyEia5LqWVXmkOfL9qs8a3NxWkx5VGY2bMLL4uVTDD5EQIy5L0e7wi28S1iJljr+3LIB6Lu/sqQxxciHOT8qNVOJeYPp+NBhbA68cEFThXR5MOh/UmRrlXjvSU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=bDgpdIHU; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="bDgpdIHU" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4ee0084fd98so38716681cf.3 for ; Mon, 24 Nov 2025 10:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1764008274; x=1764613074; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3Q4XGWFZAsNM37R1rQ1ombVOOPPk7RCpjRWEUHwD+PE=; b=bDgpdIHUvtkzyV9DG4/sV5MWV8P3p3E2Xck2GytyeHhAIxgTjzSuDSWj4nSqnZD6La drsNMb7sJ+k53CZDGfbZY4ze01nwHtSq9xsa7PBGbpO7qdBG9M47o1kEt5EuhxMSvwaK NtBrCRCHH/mNubkiHeqQZ/AOsHzJcwbZ4NMcuHIVLJLtqgM3/Q+jhokgixw4Jn3h9HrJ XMXxBdDriTGXnIAj/aLA8Z8m5pWuxFDtrw33nQNcOXG+vzdG6hpvgvNdmuGJKJ6wSjJ3 aX5XE2/CoTG6Y+z6rwEw6PQY75DkNTrvdB4p/vPxJyL6BYAlM5lhp/CeyychHpc6Ji4t A/Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764008274; x=1764613074; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Q4XGWFZAsNM37R1rQ1ombVOOPPk7RCpjRWEUHwD+PE=; b=cBZNJMajXqRwi0F0s6sICthrcU/SjUA4nK278hRS/8fi5qEh50KxqGCafOGTb95YYl qvuoTkYTxcNS0vSoqqA1y1+7HKybraI7+S+ngzsUQ78Vf+2G0Up6xrli+sNtkGL6Traj arD8UM36ZMKaKpPbBfFjzp7KLzeb2aq0YmiII3UpxgyH0R9FN1GqKEi6J/Fa/bUQzo58 uzuZtPEP00dJZspkTEAWBQivF5FAmOPdE7vCjJI+tezH30GNo8sWwWkvGBvXeqtSQLNg zVWfII5VLuse2JutEXhGqzLW33wIVc6YduxvZTNJOjs9Akyeebow8BEA+cn77O/XpCk/ 0qDw== X-Forwarded-Encrypted: i=1; AJvYcCVy56leCFf9IEDHVPtxE7SFmoXSkAwBNGP6zQdsOFmIQGPenFBpMdEd7vtGTIYs/SKzUp2jGEttzYQ0ZCY=@vger.kernel.org X-Gm-Message-State: AOJu0YyVRzI3cmEUwDdxBQlv9Yog/se1kkl045Fc334TFrbfEpt7R0bU pxSFXbunn3u8PkY3kyu8FHTsWVwwweSdixyhbDS35CBaK1/X2jG+E+U57N5XXvk3FGc1GGYoTJ5 4tFCK X-Gm-Gg: ASbGncvVylBxUoYKaSB9JO8zRbrqlVT3LVDt7jwU8RQ/YTktDa3oWW1MqC7wdj4WdHs +ugimkDm/X8TwwTDpd8WdPb/7wgcIRjsoOTulKYjsWQUjedbAPqZL2UyHOyfATO7cAO7GXMSAyL ZvD+Xd1YJzWo9qE++ehGOxteGA+r/+nudB2gY8nAu2/OwVaKY+/nZgZ6HunIkS5ehkduEXJtMnm 0ehMkgamPOLIYXpGO95th/8IZTZIn/T4zZkzOG6MEFbBl/yptKHNeCVtS/Q+Blb65dqvm80vk1l +0v/pt+a7HRr9cy5RvikuAOyZLcDkjJkJ2mHeeWQRSj4z+EJYfiNgWWx48Qkl2wxYjIP2zivFbA Z02zVcCE7rjUpioWLvDZAn7xtQupA3T2SYqCq6vPXGH7j94oFoTBB/hLxhnzL0SLk5ycPCdhAZx GV2cbpTpFOFxlQXi+yzFfPiAZiTygdi6LV0xPCJQ7ILmTIDGPX/iiqHnuB X-Google-Smtp-Source: AGHT+IGrymCLbu6XzxcbFP6b8oUrfAOz3stICSOnVBiZzQk2Uy4On+diDpNFffli+zQ7ZB0/aTDqYg== X-Received: by 2002:a05:622a:64f:b0:4e8:9ad9:f3da with SMTP id d75a77b69052e-4ee58ab0047mr160373601cf.30.1764008273775; Mon, 24 Nov 2025 10:17:53 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295db58fsm997483085a.37.2025.11.24.10.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 10:17:53 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vNb8K-00000001xCt-3GkR; Mon, 24 Nov 2025 14:17:52 -0400 Date: Mon, 24 Nov 2025 14:17:52 -0400 From: Jason Gunthorpe To: Marek Szyprowski Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Robin Murphy , Joerg Roedel , Will Deacon , Leon Romanovsky Subject: Re: [PATCH] iommu/dma: add missing support for DMA_ATTR_MMIO for dma_iova_unlink() Message-ID: <20251124181752.GX233636@ziepe.ca> References: <20251124170955.3884351-1-m.szyprowski@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124170955.3884351-1-m.szyprowski@samsung.com> On Mon, Nov 24, 2025 at 06:09:55PM +0100, Marek Szyprowski wrote: > Commit c288d657dd51 added support for DMA_ATTR_MMIO attribute in the > dma_iova_link() code path, but missed that the CPU cache is being also > touched in the dma_iova_unlink() path. Fix this. > > Fixes: c288d657dd51 ("iommu/dma: implement DMA_ATTR_MMIO for dma_iova_link().") > Signed-off-by: Marek Szyprowski > --- > drivers/iommu/dma-iommu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Did you find it by code inspection? Jason