RE: [PATCH v14 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters

Luck, Tony
2025-12-02T23:22:21Z

> Thank you. On a high level this looks good to me. I am concerned about the architecture
> "SNC" term creeping deeper into fs code when it (the fs) aims to generalize it as
> "summing domains". Mentioning SNC in the comment may be useful though since it
> helps to understand what is going on by being specific.
> As a nit could the user space message not refer to SNC though? How about something like:
> "Summing domains using assignable counters is not supported."

That looks good. I'll use that.

Thanks

-Tony