Re: [PATCH v14 12/32] x86,fs/resctrl: Support binary fixed point event counters

Reinette Chatre
2025-12-02T16:12:01Z

Hi Tony,

On 11/24/25 10:53 AM, Tony Luck wrote:
> resctrl assumes that all monitor events can be displayed as unsigned decimal
> integers.
>
> Hardware architecture counters may provide some telemetry events with greater
> precision where the event is not a simple count, but is a measurement of
> some sort (e.g. Joules for energy consumed).
>
> Add a new argument to resctrl_enable_mon_event() for architecture code
> to inform the file system that the value for a counter is a fixed-point
> value with a specific number of binary places.

The final paragraph of changelog seems to actually form part of above, and did so
in v13. This new split seems unnecessary and confusing to me.

>
> Display fixed point values with values rounded to ceil(binary_bits * log10(2))
> decimal places. Special case for zero binary bits to print "{value}.0".
>
> Only allow architecture to use floating point format on events that the file
> system has marked with mon_evt::is_floating_point.

Considering some questions surrounding this name this could append something like:
"... which reflects the contract with user space on how the event values are displayed."

>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> ---

Reinette