From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFAC36D500 for ; Mon, 24 Nov 2025 19:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764012953; cv=none; b=IsP9Ts6yyTMzeOM0HUp/VpRPn/Jq0Ui06Qm2KQP5yMNMgiYC03GR/6O/AlH/u6bEaCN9DN+1u2Bil3G1kxwCsmH0WO7BOjxkXfxMeHERSW0kPjCckpmU5Ze9V719NQVlxwaiyHpRIJV7mkS/fWVVABI6WRlHYW5iQe2nYQNWtxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764012953; c=relaxed/simple; bh=32T4aKlR6zbddC2N3W0/lKbTySxbKTGQxmkwHTcmEPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BTr7r2CKsz+8takn1nrNOiAMwmW1a4U12i9BfJSJ9U8Zn8HVXER9Ci4Zxs2sOgtTCEEtyPVHYPOO4fS9mNPVM0uVfpMpvROGR6rIWZm1mKG1PgIcVyxN8LQtHsDFa4/Gy8LW99PO9SnWanAsuIUURVHt/3tH04rF0f6baJGvNBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=m8ljL+Rd; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="m8ljL+Rd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kQMvURqoQ7+9i7JdbPxxo7Ubpjb+WWbdog+4FuSf+kM=; b=m8ljL+RdE4HKB3VkY+k8sTcZc4 kIoz2vyPLvHBCySwv6KlX//CoOKgjNaR/XQ0xfrtCjxeHbzYB+DS9XnaTgzN0jJDeKhpVfSK7g+H+ cKNe4YlMnTZBNvMc9IkMX57n+LtaKei6c2l15mWF6hLMN7ovIY/00HebElvbOiMj4ksnMRHdi7paU sPWLeoDUWUFs1nYtFm9u+9dia9j8Hx9B1rCreiUF2HbXsDSfMYypIGFQKSlZ8F2hBOgL2t7nGQl/3 xuabWtv1R3ahVCGKgdyJrzjegAuxmq2ZDTS7U3lhjLU4hjiOMYhbYavRXJ7smssG+YtziHpjpGzLk od6J5m5w==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNcLi-00000007QxJ-1HmD; Mon, 24 Nov 2025 19:35:46 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id CC0FD3002A6; Mon, 24 Nov 2025 20:35:45 +0100 (CET) Date: Mon, 24 Nov 2025 20:35:45 +0100 From: Peter Zijlstra To: Alexandre Chartre Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jpoimboe@kernel.org, david.laight.linux@gmail.com Subject: Re: [PATCH v6 26/30 (mawk fix)] objtool: Add function to get the name of a CPU feature Message-ID: <20251124193545.GV3245006@noisy.programming.kicks-ass.net> References: <20251124164855.1036513-1-alexandre.chartre@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124164855.1036513-1-alexandre.chartre@oracle.com> On Mon, Nov 24, 2025 at 05:48:55PM +0100, Alexandre Chartre wrote: > diff --git a/tools/objtool/arch/x86/Build b/tools/objtool/arch/x86/Build > index 3dedb2fd8f3a0..b95448ee01ee4 100644 > --- a/tools/objtool/arch/x86/Build > +++ b/tools/objtool/arch/x86/Build > @@ -12,3 +12,13 @@ $(OUTPUT)arch/x86/lib/inat-tables.c: $(inat_tables_script) $(inat_tables_maps) > $(OUTPUT)arch/x86/decode.o: $(OUTPUT)arch/x86/lib/inat-tables.c > > CFLAGS_decode.o += -I$(OUTPUT)arch/x86/lib > + > +cpu_features = ../arch/x86/include/asm/cpufeatures.h > +cpu_features_script = ../arch/x86/tools/gen-cpu-feature-names-x86.awk > + > +$(OUTPUT)arch/x86/lib/cpu-feature-names.c: $(cpu_features_script) $(cpu_features) > + $(Q)$(call echo-cmd,gen)$(AWK) -f $(cpu_features_script) $(cpu_features) > $@ > + > +$(OUTPUT)arch/x86/special.o: $(OUTPUT)arch/x86/lib/cpu-feature-names.c > + > +CFLAGS_special.o := -I$(OUTPUT)arch/x86/lib If you'd been careful, you'd have taken the commit from tip and noticed its Build fragment is slightly different :-) You're now re-introducing a race in the build where if you build special.o before decode.o the lib directory isn't yet created and it goes sideways. Anyway, let me fold that awk delta into what I have. Thanks!