From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97E58329E6C for ; Mon, 24 Nov 2025 19:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764013535; cv=none; b=i255V8TqR7YBgG1Znp7DaiCknTVonWiXiqz1Q5BI49bPiAhk7J4447GIV6hd4K+13SVuvB2jSp6jf7Y0Ni4QzyD2OYY3titA5ZKhiYTiV+JNAtkFExaXTm2XsMqnIwuAJ4abHCxP7vZEUNNJJybdiwAZwt2YMB3ISEolHP1bCVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764013535; c=relaxed/simple; bh=mAJJVEMuYkI8L/8+DO2bz9ZmF1IbzA5AzEA7Px3+pdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ja2iSOnkeccCQVi1Vn8C1+Uon+WpYiA3z099G9FPTz6Jx/YFBm0FW/2WQP4u5lD4ByuZmC6K2zKP6LIVcJGY6Zj34uuesZiCunnIj5oHCmG7wrrNPjerv6SEuObJxcDJ8F7FqdxGKhT4MjYgM+Gojeb5LxNjsYHZyfbQdBHi1gk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Dsh3MsRI; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Dsh3MsRI" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yJzvDoSwjlV0qnSdV/hFJ5I4iQYzBv+cQXb3S6+w/js=; b=Dsh3MsRIHWcO/v8ubwrOzlJTkn xDNfiXPykIMZXUwZbfCRl23fk87gtUwhzyhvz2ppWy2zoznt66oLOdIvgQA7hNPvkGxQYgq6BFccH pmUeJVqwkCG0YK0ZLNXzpl0wJlROjzKGw6lr1NFCpIZ/JZQx2TxtX/PaAT/yPuvD4gBuFJ0vRBcOk kpS1J1heoiYTTQq77BAh0wtgvTekpliUGm1FZeYDfcVRt9qxUd/1HvamATf3MX9rsRSDLURSZ0IVx CJp/h+AFjLBgCNUDDx0zOhKT7SJQqZGf57FWcxWxz5GZeaQv3fM3kRSaphJXpdT2CIu/jkxFKlzEM s1PsyHWg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNbdW-00000004RfP-2rJy; Mon, 24 Nov 2025 18:50:06 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id BED53300230; Mon, 24 Nov 2025 20:45:28 +0100 (CET) Date: Mon, 24 Nov 2025 20:45:28 +0100 From: Peter Zijlstra To: Alexandre Chartre Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jpoimboe@kernel.org, david.laight.linux@gmail.com Subject: Re: [PATCH v6 26/30 (mawk fix)] objtool: Add function to get the name of a CPU feature Message-ID: <20251124194528.GN4068168@noisy.programming.kicks-ass.net> References: <20251124164855.1036513-1-alexandre.chartre@oracle.com> <20251124193545.GV3245006@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124193545.GV3245006@noisy.programming.kicks-ass.net> On Mon, Nov 24, 2025 at 08:35:45PM +0100, Peter Zijlstra wrote: > On Mon, Nov 24, 2025 at 05:48:55PM +0100, Alexandre Chartre wrote: > > diff --git a/tools/objtool/arch/x86/Build b/tools/objtool/arch/x86/Build > > index 3dedb2fd8f3a0..b95448ee01ee4 100644 > > --- a/tools/objtool/arch/x86/Build > > +++ b/tools/objtool/arch/x86/Build > > @@ -12,3 +12,13 @@ $(OUTPUT)arch/x86/lib/inat-tables.c: $(inat_tables_script) $(inat_tables_maps) > > $(OUTPUT)arch/x86/decode.o: $(OUTPUT)arch/x86/lib/inat-tables.c > > > > CFLAGS_decode.o += -I$(OUTPUT)arch/x86/lib > > + > > +cpu_features = ../arch/x86/include/asm/cpufeatures.h > > +cpu_features_script = ../arch/x86/tools/gen-cpu-feature-names-x86.awk > > + > > +$(OUTPUT)arch/x86/lib/cpu-feature-names.c: $(cpu_features_script) $(cpu_features) > > + $(Q)$(call echo-cmd,gen)$(AWK) -f $(cpu_features_script) $(cpu_features) > $@ > > + > > +$(OUTPUT)arch/x86/special.o: $(OUTPUT)arch/x86/lib/cpu-feature-names.c > > + > > +CFLAGS_special.o := -I$(OUTPUT)arch/x86/lib > > If you'd been careful, you'd have taken the commit from tip and noticed > its Build fragment is slightly different :-) > > You're now re-introducing a race in the build where if you build > special.o before decode.o the lib directory isn't yet created and it > goes sideways. > > Anyway, let me fold that awk delta into what I have. OK, pushed out a new tip/objtool/core, lets hope its all good now :-)