From: Jonas Gorski <jonas.gorski@gmail.com>
To: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/7] net: dsa: b53: fix ARL accesses for BCM5325/65 and allow VID 0
Date: Tue, 25 Nov 2025 08:51:43 +0100 [thread overview]
Message-ID: <20251125075150.13879-1-jonas.gorski@gmail.com> (raw)
ARL entries on BCM5325 and BCM5365 were broken significantly in two
ways:
- Entries for the CPU port were using the wrong port id, pointing to a
non existing port.
- Setting the VLAN ID for entries was not done, adding them all to VLAN
0 instead.
While the former technically broke any communication to the CPU port,
with the latter they were added to the currently unused VID 0, so they
never became effective. Presumably the default PVID was set to 1 because
of these issues 0 was broken (and the root cause not found).
So fix writing and reading entries on BCM5325/65 by first fixing the CPU
port entries, then fixing setting the VLAN ID for entries.
Finally, re-allow VID 0 for BCM5325/65 to allow the whole 1-15 VLAN ID
range to be available to users, and align VLAN handling with all other
switch chips.
Sent to net-next as it would cause an ugly, non trivial merge conflict
with net-next when added to net, and I don't want to subject the
maintainers to that. I will take care of sending adapted versions to
stable once it hit linus' tree.
Jonas Gorski (7):
net: dsa: b53: fix VLAN_ID_IDX write size for BCM5325/65
net: dsa: b53: fix extracting VID from entry for BCM5325/65
net: dsa: b53: use same ARL search result offset for BCM5325/65
net: dsa: b53: fix CPU port unicast ARL entries for BCM5325/65
net: dsa: b53: fix BCM5325/65 ARL entry multicast port masks
net: dsa: b53: fix BCM5325/65 ARL entry VIDs
net: dsa: b53: allow VID 0 for BCM5325/65
drivers/net/dsa/b53/b53_common.c | 88 ++++++++++++--------------------
drivers/net/dsa/b53/b53_priv.h | 40 +++++++++++----
drivers/net/dsa/b53/b53_regs.h | 19 ++++---
3 files changed, 78 insertions(+), 69 deletions(-)
base-commit: cc1b62512abf19c635fe304e253953ca3b33ffa2
--
2.43.0
next reply other threads:[~2025-11-25 7:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 7:51 Jonas Gorski [this message]
2025-11-25 7:51 ` [PATCH net-next 1/7] net: dsa: b53: fix VLAN_ID_IDX write size for BCM5325/65 Jonas Gorski
2025-11-26 18:10 ` Florian Fainelli
2025-11-25 7:51 ` [PATCH net-next 2/7] net: dsa: b53: fix extracting VID from entry " Jonas Gorski
2025-11-26 18:11 ` Florian Fainelli
2025-11-25 7:51 ` [PATCH net-next 3/7] net: dsa: b53: use same ARL search result offset " Jonas Gorski
2025-11-26 18:23 ` Florian Fainelli
2025-11-25 7:51 ` [PATCH net-next 4/7] net: dsa: b53: fix CPU port unicast ARL entries " Jonas Gorski
2025-11-25 20:42 ` Vladimir Oltean
2025-11-26 9:07 ` Jonas Gorski
2025-11-25 7:51 ` [PATCH net-next 5/7] net: dsa: b53: fix BCM5325/65 ARL entry multicast port masks Jonas Gorski
2025-11-26 18:26 ` Florian Fainelli
2025-11-25 7:51 ` [PATCH net-next 6/7] net: dsa: b53: fix BCM5325/65 ARL entry VIDs Jonas Gorski
2025-11-25 7:51 ` [PATCH net-next 7/7] net: dsa: b53: allow VID 0 for BCM5325/65 Jonas Gorski
2025-11-25 11:45 ` Álvaro Fernández Rojas
2025-11-25 20:31 ` Vladimir Oltean
2025-11-27 7:42 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125075150.13879-1-jonas.gorski@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox