From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DECF13271E4 for ; Tue, 25 Nov 2025 15:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764082934; cv=none; b=PWBQlnXoefVPaVv+HQAA0QY+zLP8gJFllTuBNdTswAcZ+r8N0rdnbkWjbRRW9S02kye8sIPiySOzA0qQF0apelMxo/Ku/iJOySLgc+u7FvNYLsT1110qJpSmTHMFE5YUhzr37bcb14dj84tCANr9oLXkmYSEic+raiVbJRCm25I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764082934; c=relaxed/simple; bh=MA9QsTVtWgsvfIublM08n8V07qfNyZI6ksmu7VUM+Z4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DReC934YGx4a7t0x/YK36TJTW/6ZF2hX2tMMnIYbxKgnMIalVFbhQwjwwNihBB64BdJwsDxxb3+WyEvg9jL9tHv05WshpTfiAlcL6tvGhsMAimFTEuczjvRzzZEaBozWQMHZFT6y4ZbKLw7nFVjdOwFCwXc5wHPts5BiAKMKTaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hz0LjDdt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lkynn7SE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hz0LjDdt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lkynn7SE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764082931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=09KqEaOP5fl8HujAjQhdvyXU7ffK0wmWeHz1wD48GE4=; b=hz0LjDdtcgUbK4Wl9Tif+R3NwgPu7ZnPMYOWyYMeAt+rUQ8B+bHMcwdRFjJoQL7aLV4pYB WScMFPXK6ExeOmcbsJwtxNkcP3aWupCdijNCEMu7aYzZaxeDhLqKs+O9kg8oK+VL6e72cn Ceoc+5rivvKIeIUn1aszNcLs4e63kgM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-B0q_ZfaaPu2xKsh-QQNOXg-1; Tue, 25 Nov 2025 10:02:09 -0500 X-MC-Unique: B0q_ZfaaPu2xKsh-QQNOXg-1 X-Mimecast-MFC-AGG-ID: B0q_ZfaaPu2xKsh-QQNOXg_1764082928 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779ecc3cc8so26789495e9.3 for ; Tue, 25 Nov 2025 07:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764082928; x=1764687728; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=09KqEaOP5fl8HujAjQhdvyXU7ffK0wmWeHz1wD48GE4=; b=Lkynn7SE/3ruweqJBfFq7A+7lTs76gz+y5ekMknO7skOmKuhzx1o2ler6mJAkSsLcJ Nm1WsVnU2Ptrjyq58f3DG9gZSn8hxar0a5tAkN2LPd6ReP8bW6WtieyU583mfhs6FF9Y 2M/Yz958yneZKAL5bsQQDBdlBL6HhtB5bC8hWe/ghcdywH0Wefj7ZSTw0pAvGVXxpe+w MQVr5tqHoFCnGjYtqmRQY21nD6Ja/R5vFs9+HvVUe3wvg4SIUd+ev33nYwwePDRkG1mF kfWSbPy5KOhEGua1kWZX2TYukF61XEgvaR9jVBo4B1Rz/GBVVmyD7pnHKUZNp0tnBY32 ZkBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764082928; x=1764687728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=09KqEaOP5fl8HujAjQhdvyXU7ffK0wmWeHz1wD48GE4=; b=QdM3eSGU4HF0/XQnGvyE5QeYTqElf6ZZHETiMz4yD8t2kU8FTHoU6gHWaZ9vPw5XLZ TPSFSO5Ibfwa/1s2CaspYklF8N/8sz9U5yAI0/Oj9NPVS2QosyWT9sv5KoLtT3AtItJl OAbV927AlIrYqh9h4t3JBC/c2BAMoi/u/JCTUoK3KQhzOupU51ltG5IPDNeIo5dvzIRs IDtP6mMOBYvAwh5jQWDE7yAG4LAKoph8mob1iIN0WjfbmyWmB4aUNDN+Wn+7A35M0q8n Cvn44R7dYjGSjl7wewZALgl72xE+j3Ed92HtJW8DjVF3wMRQDC2FlZirOc6ttF2cn+D5 mfIw== X-Forwarded-Encrypted: i=1; AJvYcCVsaqUsSQunNR7Tv51+ksRjnxahaPSMzhkuSbmcmCzoDM6FYcMPFeQG3m5gz8uBQixYlea+GL+yacuIIZI=@vger.kernel.org X-Gm-Message-State: AOJu0YyN4NnIGSMROxQz77eIxLcwe6BCzLwHjyTT7MXooFtSZ35zyJ25 WKh1a6VkPb+EAFBxmt+5xFonk8+zSex/1tHH4CUyY76eKwRr4CiOmQbQuuOqh5TPW5eBoaLXSVP FftjDaPxBHsqlb2nrVPIkBblOo13RCNLVRR5CYD13YOIORo3TovNQO6LihbRsBt+ttg== X-Gm-Gg: ASbGnctP2Qtnay7LRRC/qN2gTG3H9I0S9j41kRrKnlM28ecXyb3IXlzkNq5KEeKm8X6 R6fgSjnveo+CO6lmxCIaIlRUUoS9pqOpKZUmaELC5WssuldAw44k1QxZVtkBSjP2WIA7KtCl/c1 WuN44Q1FdcTtZQveXEdpXyq5PAhYvBvcwnGfbKPBThXZvXAj0khpjYTThtyXWjqs4TvL7um5/xO NPqZ49jJfF+cAaLUzLLbpG3vRU6nXC8w4ByQcAQVN/c77sjTRMS6UGeVp0G5CP8+JOnhWxrPHrq ski1UDUUUo/sMcDuVeMy0J3G+ygTBhAfpQ5sQlCsdgozoksu+CUR8uhetefxDG0/LCl1u+jcvMY xZR1FLOh+Na/LTs8= X-Received: by 2002:a05:600c:4fce:b0:477:9aeb:6a8f with SMTP id 5b1f17b1804b1-47904ad9438mr24886185e9.9.1764082926350; Tue, 25 Nov 2025 07:02:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnxhF4yC89mPigrHkbVw1gVjo8TuRM3hL5MAajbA1OA7AnNYZFSuV4PRGzcMPXZxxaMN4l+A== X-Received: by 2002:a05:600c:4fce:b0:477:9aeb:6a8f with SMTP id 5b1f17b1804b1-47904ad9438mr24884925e9.9.1764082924414; Tue, 25 Nov 2025 07:02:04 -0800 (PST) Received: from redhat.com (IGLD-80-230-39-63.inter.net.il. [80.230.39.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf226bf7sm273353425e9.11.2025.11.25.07.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 07:02:03 -0800 (PST) Date: Tue, 25 Nov 2025 10:01:58 -0500 From: "Michael S. Tsirkin" To: Simon Schippers Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eperezma@redhat.com, jon@nutanix.com, tim.gebauer@tu-dortmund.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH net-next v6 2/8] ptr_ring: add helper to check if consume created space Message-ID: <20251125095650-mutt-send-email-mst@kernel.org> References: <20251120152914.1127975-1-simon.schippers@tu-dortmund.de> <20251120152914.1127975-3-simon.schippers@tu-dortmund.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251120152914.1127975-3-simon.schippers@tu-dortmund.de> On Thu, Nov 20, 2025 at 04:29:07PM +0100, Simon Schippers wrote: > Add __ptr_ring_consume_created_space() to check whether the previous > __ptr_ring_consume() call successfully consumed an element and created > space in the ring buffer. This enables callers to conditionally notify > producers when space becomes available. > > The function is only valid immediately after a single consume operation > and should not be used after calling __ptr_ring_consume_batched(). > > Co-developed-by: Tim Gebauer > Signed-off-by: Tim Gebauer > Co-developed by: Jon Kohler > Signed-off-by: Jon Kohler > Signed-off-by: Simon Schippers > --- > include/linux/ptr_ring.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h > index da141cc8b075..76d6840b45a3 100644 > --- a/include/linux/ptr_ring.h > +++ b/include/linux/ptr_ring.h > @@ -453,6 +453,23 @@ static inline int ptr_ring_consume_batched_bh(struct ptr_ring *r, > return ret; > } > > +/* > + * Check if the previous consume operation created space space? what does this mean? > + * > + * Returns true if the last call to __ptr_ring_consume() has created > + * space in the ring buffer (i.e., an element was consumed). > + * > + * Note: This function is only valid immediately after a single call to > + * __ptr_ring_consume(). If multiple calls to ptr_ring_consume*() have > + * been made, this check must be performed after each call individually. > + * Likewise, do not use this function after calling > + * __ptr_ring_consume_batched(). API-wise, it is a really weird function. So is { p = __ptr_ring_consume return !!p } guaranteed to be equivalent to { p = __ptr_ring_consume return !!__ptr_ring_consume_created_space } > + */ > +static inline bool __ptr_ring_consume_created_space(struct ptr_ring *r) > +{ > + return r->consumer_tail >= r->consumer_head; > +} > + > /* Cast to structure type and call a function without discarding from FIFO. > * Function must return a value. > * Callers must take consumer_lock. > -- > 2.43.0