From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4199E4C9D for ; Wed, 26 Nov 2025 00:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764115425; cv=none; b=ROIbRSOzE0efhyA+FZMM77XJ8wKorYkgFn5XBJkATdTGX/dQQwmkr+VhqGp95Nd9qOPnjQYpPDtgJ0CJ0gq0475byEPD1g9rw2J0lNhULwfdxfD91bNVEJpVIJPqEE6nkzLXbsnaWYeJjCXpY1vNQTt5oiyOq/eImBbTyUs88nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764115425; c=relaxed/simple; bh=Zm86rbf4ViZ/eAdZ8KwSBeinjex6AZ0RQ+kgPGLr94c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KJhb693ARW1NrNzDzIIIvjyAkME6ZRyp5VY9WUINA+HGplQyC5BGV2gN7J5HQea4bzNtKm/IdYvb5aMF6Ao40frLFrruNWWmYdlRc4D1P6drHobmJh5FPeIxAVpy6PTP17JRtlQrwy2dsdJS1WLOTz0tOYspXt83S/E8BXJdTL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MnafOhVk; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bk4u5VBW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MnafOhVk"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bk4u5VBW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764115422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vKRmZiEMk1to2WJzzrJwnxFSNJVHABWSWDpvrtN4fR4=; b=MnafOhVkjS3D+WodypZ4R1xInY95tf7OWGD3kcDhOMfoVjthyYrPb6CXSYI/vcW4PnnCYt yDAwcJjqDzJk9ifgy/EKImDGCbiK6Abi2tPRlbHEHYqnrWPVEA0ASv6qV7AWmkkoJxsEir C++e4dzNPUzrf30J2COC1iXVA16eCKc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-RXn3Si7hOKax9Fk-j5vbng-1; Tue, 25 Nov 2025 19:03:40 -0500 X-MC-Unique: RXn3Si7hOKax9Fk-j5vbng-1 X-Mimecast-MFC-AGG-ID: RXn3Si7hOKax9Fk-j5vbng_1764115420 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-429cceeeb96so3679493f8f.1 for ; Tue, 25 Nov 2025 16:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764115420; x=1764720220; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=vKRmZiEMk1to2WJzzrJwnxFSNJVHABWSWDpvrtN4fR4=; b=bk4u5VBWOCvOHJ0m6jfJBIgDB5TMnnm0hm0L4YjzF18dT8qqPmpHSdJ6Z2kY9iLAm5 0w3s9HHpAwDaleFMPSOIoE6/xtlL3qbFpxhnyCNTiTKd0hnrhQMYa+d8tUBui0wgMvj8 diK4EPQJivPynawfcBp2HgT+s2e4zR3TA1yLuEbYxbNCxc+37UGEUfEGYAzhNXK+05sh olFW1060QpdnvTA5JfEOEvGwVBrq9MZ8nRYdYJG7b3/R9xvkp2cQhE8JFd9duNGHsa4y 1drBTMIXNqv1WjfqDDyXCIA7Ym99F1jch4TqvHaTApQ+jyeOKVE0eChZeEq/9oKj2RZ7 s6ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764115420; x=1764720220; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vKRmZiEMk1to2WJzzrJwnxFSNJVHABWSWDpvrtN4fR4=; b=POD28pTJP3tPLGQP9TWGESffMw8EN7RekmnfJXNjKlaFdeJBqDT3dw9QwpeH8Ew/HJ E58mKXbGT4ONz35NYDkkgIs0WX5fMobq7ltnMmS2AIHtlq9MzR05h04Fm3frTeLPwtXz NFT5DTjUfb89aeEDJQ7yuEDAhf6koTG7UHviMxztrO5bz/CkWPsUfuSLE8om7epsLRR6 rXzGnUSZIYBevfzruB5Pi3AdrGXzqpzet4+JlsQ6+0NKuVeKZk55Y/sPrsSVayJheAb6 lZux4oDLu4KvifSkZywrbPnUOrKmYaFNam3FMaNhZEmqIkF2tqoNXi6Qr6aavJMy6BIM OI3g== X-Forwarded-Encrypted: i=1; AJvYcCVLVZ07izJq9OeSkGoh7yFbk6Fv4n6fjdWEobePCOmvQzSUIGJfMnWJZe1BF7G1D2t19pt8XjqnX0H+/dY=@vger.kernel.org X-Gm-Message-State: AOJu0YxCFMCialPq5I0vPtnCZHuVRQ4Hw1xWmtjtACWyPORJYUFXfmpt 0QtjDCNva3gSzy/15F3HRpTgohevgo2+JKRshWyWRsdlAEdGMOQFgaUY62rqbPY57ntFER9Cs3Q QgSRH4rL93xM69x+IWVWOmOGYw8DkGP5jArTep9l2NPNf2xqNrxGY1bKGDAtjr9+t7g== X-Gm-Gg: ASbGncuG7+915oupBbF0pqIwiz6He5LdfX6kgBkxaTHYWxl0A5C0v+YA4OS2aNqFxVU Rt1/vKP+ItuNOZyZW2KO12EsmAVHUZnYBGpMVyP/damzMxsAGSofVWqtNDuQ0ZiaEY7mWLgo4QJ DS7aaYh3Da9yOPpxgoR+JT91whMdSTU778zms7VE0lb++s1OzocsgzOeLTHJ6jNVQy/L8+FZ/fw bTkFb1mkztuBLG0iO1lhMzCuepFLZyNTqfGuWHgZvPpm31PuAMM9ZrBxtIrrm4R4c10++XMCTPa JEy9NzMtNM6fXfoaZRGS9b78YyEusFEoKLaBwOT4L1+Ma/t55L7++hFIKMC6+QrukKPVn5f3TZz 2Dl8LQSpSKHT1iueFVPvzEuJSy31apA== X-Received: by 2002:a05:6000:24c3:b0:429:c450:8fad with SMTP id ffacd0b85a97d-42cc1d196a9mr18800456f8f.53.1764115419523; Tue, 25 Nov 2025 16:03:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBR55J7x3MTf+kofKm9ivnzfPRH5t94S9N5E/qvOiFWaJNtYDvbjL54tC9IkLOFKqnZLIwfA== X-Received: by 2002:a05:6000:24c3:b0:429:c450:8fad with SMTP id ffacd0b85a97d-42cc1d196a9mr18800423f8f.53.1764115418994; Tue, 25 Nov 2025 16:03:38 -0800 (PST) Received: from redhat.com (IGLD-80-230-39-63.inter.net.il. [80.230.39.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fa35c2sm36014357f8f.25.2025.11.25.16.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 16:03:38 -0800 (PST) Date: Tue, 25 Nov 2025 19:03:34 -0500 From: "Michael S. Tsirkin" To: Jon Kohler Cc: Paolo Abeni , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , "virtualization@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] virtio-net: avoid unnecessary checksum calculation on guest RX Message-ID: <20251125190207-mutt-send-email-mst@kernel.org> References: <20251125175117.995179-1-jon@nutanix.com> <276828c5-72cb-4f5c-bc6f-7937aa6b6303@redhat.com> <3ED1B031-7C20-45F9-AB47-8FCDB68B448E@nutanix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ED1B031-7C20-45F9-AB47-8FCDB68B448E@nutanix.com> On Tue, Nov 25, 2025 at 08:00:55PM +0000, Jon Kohler wrote: > > > > On Nov 25, 2025, at 12:57 PM, Paolo Abeni wrote: > > > > CC netdev > > Thats odd, I used git send-email --to-cmd='./scripts/get_maintainer.pl, > but it looks like in MAINTAINERS, that only would have hit > VIRTIO CORE AND NET DRIVERS, which does not include netdev@ > > Should that have ? > L: netdev@vger.kernel.org > > Said another way, should all changes to include/linux/virtio_net.h > be cc’d to netdev DL? > > I suspect the answer is yes, I’ll send a patch for that in the > interest of not having this issue again :) I think yes. But only virtio net not core. I guess we should split net from core then. > > > > On 11/25/25 6:51 PM, Jon Kohler wrote: > >> Commit a2fb4bc4e2a6 ("net: implement virtio helpers to handle UDP > >> GSO tunneling.") inadvertently altered checksum offload behavior > >> for guests not using UDP GSO tunneling. > >> > >> Before, tun_put_user called tun_vnet_hdr_from_skb, which passed > >> has_data_valid = true to virtio_net_hdr_from_skb. > >> > >> After, tun_put_user began calling tun_vnet_hdr_tnl_from_skb instead, > >> which passes has_data_valid = false into both call sites. > >> > >> This caused virtio hdr flags to not include VIRTIO_NET_HDR_F_DATA_VALID > >> for SKBs where skb->ip_summed == CHECKSUM_UNNECESSARY. As a result, > >> guests are forced to recalculate checksums unnecessarily. > >> > >> Restore the previous behavior by ensuring has_data_valid = true is > >> passed in the !tnl_gso_type case. > >> > >> Cc: Paolo Abeni > >> Fixes: a2fb4bc4e2a6 ("net: implement virtio helpers to handle UDP GSO tunneling.") > >> Signed-off-by: Jon Kohler > >> --- > >> include/linux/virtio_net.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > >> index b673c31569f3..570c6dd1666d 100644 > >> --- a/include/linux/virtio_net.h > >> +++ b/include/linux/virtio_net.h > >> @@ -394,7 +394,7 @@ virtio_net_hdr_tnl_from_skb(const struct sk_buff *skb, > >> tnl_gso_type = skb_shinfo(skb)->gso_type & (SKB_GSO_UDP_TUNNEL | > >> SKB_GSO_UDP_TUNNEL_CSUM); > >> if (!tnl_gso_type) > >> - return virtio_net_hdr_from_skb(skb, hdr, little_endian, false, > >> + return virtio_net_hdr_from_skb(skb, hdr, little_endian, true, > >> vlan_hlen); > >> > >> /* Tunnel support not negotiated but skb ask for it. */ > > > > virtio_net_hdr_tnl_from_skb() is used also by the virtio_net driver, > > which in turn must not use VIRTIO_NET_HDR_F_DATA_VALID on tx. > > Ah! Good eye, I’ll see what trouble I can get into and send a v2 > > > > I think you need to add another argument to > > virtio_net_hdr_tnl_from_skb(), or possibly implement a separate helper > > to take care of csum offload - the symmetric of > > virtio_net_handle_csum_offload(). > > > > Also you need to CC netdev, otherwise the patch will not be processed by > > patchwork. > > > > /P > > No problems on cc’ing netdev, just didn’t realize this one header didn’t > auto cc the list. Will keep an eye on that, and happy to send a patch to > MAINTAINERS file for discussion.