From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Prajna Rajendra Kumar <prajna.rajendrakumar@microchip.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>
Subject: [PATCH v1 5/7] spi: microchip-core: Utilise temporary variable for struct device
Date: Tue, 25 Nov 2025 21:15:35 +0100 [thread overview]
Message-ID: <20251125201700.1901959-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251125201700.1901959-1-andriy.shevchenko@linux.intel.com>
We have a temporary variable to keep a pointer to struct device.
Utilise it where it makes sense.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-microchip-core-spi.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microchip-core-spi.c
index dbbfb395c272..68b136157fac 100644
--- a/drivers/spi/spi-microchip-core-spi.c
+++ b/drivers/spi/spi-microchip-core-spi.c
@@ -293,7 +293,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
bool assert_ssel;
int ret = 0;
- host = devm_spi_alloc_host(&pdev->dev, sizeof(*spi));
+ host = devm_spi_alloc_host(dev, sizeof(*spi));
if (!host)
return -ENOMEM;
@@ -322,7 +322,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
if (ret)
mode = MCHP_CORESPI_DEFAULT_MOTOROLA_MODE;
else if (mode > 3)
- return dev_err_probe(&pdev->dev, -EINVAL,
+ return dev_err_probe(dev, -EINVAL,
"invalid 'microchip,motorola-mode' value %u\n", mode);
/*
@@ -332,7 +332,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
*/
ret = device_property_read_u32(dev, "microchip,frame-size", &frame_size);
if (!ret && frame_size != 8)
- return dev_err_probe(&pdev->dev, -EINVAL,
+ return dev_err_probe(dev, -EINVAL,
"CoreSPI: frame size %u not supported by this driver\n",
frame_size);
@@ -344,7 +344,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
*/
assert_ssel = device_property_read_bool(dev, "microchip,ssel-active");
if (!assert_ssel)
- return dev_err_probe(&pdev->dev, -EINVAL,
+ return dev_err_probe(dev, -EINVAL,
"hardware must enable 'microchip,ssel-active' to keep CS asserted for the SPI transfer\n");
spi = spi_controller_get_devdata(host);
@@ -371,24 +371,21 @@ static int mchp_corespi_probe(struct platform_device *pdev)
if (spi->irq < 0)
return spi->irq;
- ret = devm_request_irq(&pdev->dev, spi->irq, mchp_corespi_interrupt,
- IRQF_SHARED, dev_name(&pdev->dev), host);
+ ret = devm_request_irq(dev, spi->irq, mchp_corespi_interrupt, IRQF_SHARED,
+ dev_name(dev), host);
if (ret)
- return dev_err_probe(&pdev->dev, ret,
- "could not request irq\n");
+ return dev_err_probe(dev, ret, "could not request irq\n");
- spi->clk = devm_clk_get_enabled(&pdev->dev, NULL);
+ spi->clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(spi->clk))
- return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk),
- "could not get clk\n");
+ return dev_err_probe(dev, PTR_ERR(spi->clk), "could not get clk\n");
mchp_corespi_init(host, spi);
- ret = devm_spi_register_controller(&pdev->dev, host);
+ ret = devm_spi_register_controller(dev, host);
if (ret) {
mchp_corespi_disable(spi);
- return dev_err_probe(&pdev->dev, ret,
- "unable to register host for CoreSPI controller\n");
+ return dev_err_probe(dev, ret, "unable to register host for CoreSPI controller\n");
}
return 0;
--
2.50.1
next prev parent reply other threads:[~2025-11-25 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 20:15 [PATCH v1 0/7] spi: microchip-core: Code improvements Andy Shevchenko
2025-11-25 20:15 ` [PATCH v1 1/7] spi: microchip-core: use min() instead of min_t() Andy Shevchenko
2025-11-25 20:15 ` [PATCH v1 2/7] spi: microchip-core: Make use of device properties Andy Shevchenko
2025-11-25 22:42 ` Mark Brown
2025-11-25 23:00 ` Conor Dooley
2025-11-25 23:19 ` Mark Brown
2025-11-26 6:35 ` Andy Shevchenko
2025-11-26 12:03 ` Mark Brown
2025-11-26 16:27 ` Andy Shevchenko
2025-11-26 17:24 ` Mark Brown
2025-11-26 17:29 ` Conor Dooley
2025-11-26 17:45 ` Andy Shevchenko
2025-11-25 20:15 ` [PATCH v1 3/7] spi: microchip-core: Refactor FIFO read and write handlers Andy Shevchenko
2025-11-25 20:15 ` [PATCH v1 4/7] spi: microchip-core: Replace dead code (-ENOMEM error message) Andy Shevchenko
2025-11-25 20:15 ` Andy Shevchenko [this message]
2025-11-25 20:15 ` [PATCH v1 6/7] spi: microchip-core: Use SPI_MODE_X_MASK Andy Shevchenko
2025-11-25 20:15 ` [PATCH v1 7/7] spi: microchip-core: Remove unneeded PM related macro Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125201700.1901959-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=prajna.rajendrakumar@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox