From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83D4D252900 for ; Tue, 25 Nov 2025 22:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111389; cv=none; b=KT309nMXJwsL3K5vNqdFiSo7h8XlrjxlJEmXUzMsYKJOxhl9NaTPqOs2U5Ht6euESlAmYK1hUO7hewx44jORzhm11+GaaLQSd2QqWaaoN9pd8kSMtdrZgUSzsKzf5aBeY1mJFVUnmIIOrfKNKGu0zMocCFpfwkIZGOWbfVOyz80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111389; c=relaxed/simple; bh=AK+BcklxHz/n0s157yXYc1X4X9YELa/zUDA/PZmkRw8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=noaQSLBY0G6U6fFyXrHu2BhEFaBfcL5nk2oznGJse2fVkivRs7bh66JrQBREQjdHTJ8+wb1IThkZpmPwQJ7MOORabJlVvv2t3P4EPl+uL8XSJ2SyDo1yN3d6u35JGbt5vf9PGQg1sHeUQ5ZkPU9ThqIbiN2IulpeoTc3cJ9QjCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j7eSVIXw; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j7eSVIXw" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-297d4a56f97so90034625ad.1 for ; Tue, 25 Nov 2025 14:56:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764111388; x=1764716188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JUymcOI9xHtRON6CUcKqa1VF8txmKZFaaWw6pHQ2mGY=; b=j7eSVIXwIyYJYdtua5GkC0m9PiQQI/WXbfwU3udN8KnyYFBfhLgHJM/pcLpyLnpfo9 1YDIXWTuDGC5nezu6cKJ6FC/GbjyunkI+eMy3INfOZ8dCOvgBDPisBI0DkzdIOlmCEcf JSOLRwSERSOtcsc1Td5F+5nOP2TiLl4pZO6LHh/taO8g02oiATUIpHljLbkOkGeykzKE BrMAt+p3xGKytoHIRAzd4ERkQF19a1mVLkGgHGRccZ7QFFBDLMdBe/0PECpIkJ+B4Hno EJ0/lTGPBrAok0DhL2cwQHBP/0nyP45KnmefvxohtgQI3XrZrtmzrK/mJ14yo72iZ8u6 4icg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764111388; x=1764716188; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JUymcOI9xHtRON6CUcKqa1VF8txmKZFaaWw6pHQ2mGY=; b=DHm7ElJkTO+vbqR/lqUfbtZlYWWR+Iipmhp1xSK1KgylXqF4M43R5cqEg1Mf4Orsgq ov8sIDs9QgXy+CS9kjiPBO6aLDbXXo050j7XL1UoDzIY+rXDE36u1QGRoxqmg8UMnb72 ROuBvetjv/pPWmAwhQmC27MspeNkjjCfdsyOYfcoOM4Nagqrdukc7A6KnPhXgJU6TYEe 3+LLIvALWnq4QZYUrSHpf1SH0RgE3az3G4boaK+Y1HfMeEkrERZOuhAoa1p0aXe4NoCY Wab4cPZUe9vIbWjzaQO/vhSFptjSVul5H5eSq5YMMay+fXKIp0RSRh6dnAkjdR8orNsj YQyA== X-Forwarded-Encrypted: i=1; AJvYcCUhhPHt+vV1lWO/ZYSF5gLUuV/1+LZyyeN7WodFOJAKQUtjtpk+FIG30RU5gm5wvNqYc6/NmcTEQZoyjhA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4SUVQWrhMW8gu13h8zbnh9BMlGLttyAlMg1aNMrxtWtqiu/oE obzC6sdHHIETRvEHbCcK753P1tVoKCYnPhLfswcLlBaPOEZ9bf2SfxnW X-Gm-Gg: ASbGnct/mRkzEz3DvIp1+/WT+G9n9R2TpGCbh6tYa7CeEw2BUfthX/XSFgI3bG5ujq/ kAci+uvX9Zy6P4uvWIlkRMkTLKMv3QEOfz9u6c45XS+XDJcJ4WRufKnhyAfbkDURiUJWF7GtG6p jYOT9H3to1dR+Ly614yAORXb/IvSQ6KTUNBta7IxVzt9MzskPTfsqg/c4W+c9pQwAB5pPpzCxES MjPMIIeijNv/hoiuaRvzBYCZ44NnaJ++eMvgk1ULhjbfXSlyvr4loy5lJwuTqWGA+x+U5qvjVAC BIcX2QDWmyC7CNo5PSMRxRFDMQKvL6JsgMXuESMzaE1uqvJgKBc1j8EAy3yQClDkoTKrzlN1AcM y2IZJ6Ssy64MGX9RACLU2c7BT3xPx0qbpJD3UL2Xum6q7YUMOAYtUcuVcAYQWlOsNCLRJFn0wCr 22zMc6YlUSmHDnPsekBbK1T0SdGuBUCW1lV/h4dRphrGkCehTYYgwiGkhT6duNeIv79t6dQw+3o +/RnQESPFrhVJJxjU12/bcL4N638mWFAdX8HmP5vISWQGoXe8IIh+FFejwkUwADwQG30rgqSe0V RxrOp4P85Mb/Dxp2eMEMjmuzNNpFJCR3OQ== X-Google-Smtp-Source: AGHT+IE07r8Bq07/RqXBLiC3oykdev8SWTJLZzLiYuPJLdGWN94mcaB6IVS6MU6ipnXWsd3H2nqv+w== X-Received: by 2002:a17:903:28e:b0:298:648a:f96a with SMTP id d9443c01a7336-29b6c6f1817mr185366685ad.61.1764111387585; Tue, 25 Nov 2025 14:56:27 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a546ed0sm471842a91.3.2025.11.25.14.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 14:56:27 -0800 (PST) From: Navaneeth K To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Navaneeth K Subject: [PATCH v2 0/2] most: core: fix resource leak in most_register_interface error paths Date: Tue, 25 Nov 2025 22:56:04 +0000 Message-ID: <20251125225606.70719-1-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes a resource leak in most_register_interface() where early errors (allocation failures) would return without releasing the device, leaking memory. It switches to the split device_initialize() + device_add() pattern to ensure put_device() can be safely called on all error paths. It also updates the most_usb driver to remove manual error handling that would otherwise cause a double-free with the new core logic. Changes in v2: - Replaced the previous single-driver fix ("staging: most: dim2: fix missing cleanup...") which was NACKed because it introduced a double-free risk. - Moved the fix to the Core (core.c) to handle cleanup centrally via put_device(). - Updated most_usb.c to remove conflicting manual cleanup. - Dropped the dim2.c patch as the upstream code is already correct for this new core logic (it relies on the release callback, which core now triggers). Navaneeth K (2): most: core: fix resource leak in most_register_interface error paths most: usb: remove double cleanup of interface on registration failure drivers/most/core.c | 9 +++++++-- drivers/most/most_usb.c | 11 +++-------- 2 files changed, 10 insertions(+), 10 deletions(-)