From: Nathan Chancellor <nathan@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: "Nicolas Schier" <nicolas.schier@linux.dev>,
"Simon Glass" <sjg@chromium.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2 0/2] kbuild: add target to build a cpio containing modules
Date: Tue, 25 Nov 2025 16:56:17 -0700 [thread overview]
Message-ID: <20251125235617.GA296211@ax162> (raw)
In-Reply-To: <20251125-cpio-modules-pkg-v2-0-aa8277d89682@pengutronix.de>
On Tue, Nov 25, 2025 at 02:18:18PM +0100, Ahmad Fatoum wrote:
>
> ---
> Changes in v2:
> - Add Simon's Tested-by and Reviewed-by
> - rename to modules-cpio-pkg (Nathan)
> - add separator/doc comment heading (Thomas)
> - Make temp directory ignoring and cleanup automatic (Thomas)
> - Use CONFIG_SHELL instead of shebang (Thomas)
> - Use -o instead of redirecting stdout when creating cpio (Thomas)
> - Drop superfluous -f as $(build)= overrides it (Thomas)
> - Add extra preparatory patch that makes hostprogs := gen_init_cpio
> unconditional
> - Link to v1: https://lore.kernel.org/r/20251115-cpio-modules-pkg-v1-1-01d5a0748442@pengutronix.de
>
> ---
> Ahmad Fatoum (1):
> initramfs: add gen_init_cpio to hostprogs unconditionally
>
> Sascha Hauer (1):
> kbuild: add target to build a cpio containing modules
>
> scripts/Makefile.package | 20 ++++++++++++++++++++
> usr/Makefile | 4 ++--
> 2 files changed, 22 insertions(+), 2 deletions(-)
> ---
> base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c
> change-id: 20251115-cpio-modules-pkg-70d85a69892b
>
> Best regards,
> --
> Ahmad Fatoum <a.fatoum@pengutronix.de>
>
Thanks a lot for implementing all of Thomas's suggestions (and thanks to
him for providing them). This series looks good to me and I can imagine
this being quite useful for testing.
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Cheers,
Nathan
next prev parent reply other threads:[~2025-11-25 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 13:18 [PATCH v2 0/2] kbuild: add target to build a cpio containing modules Ahmad Fatoum
2025-11-25 13:18 ` [PATCH v2 1/2] initramfs: add gen_init_cpio to hostprogs unconditionally Ahmad Fatoum
2025-11-25 22:15 ` Simon Glass
2025-11-25 13:18 ` [PATCH v2 2/2] kbuild: add target to build a cpio containing modules Ahmad Fatoum
2025-11-26 20:48 ` Nicolas Schier
2025-11-25 23:56 ` Nathan Chancellor [this message]
2025-11-26 7:06 ` [PATCH v2 0/2] " Thomas Weißschuh
2025-11-28 21:42 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125235617.GA296211@ax162 \
--to=nathan@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=sjg@chromium.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox