Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

David Heidelberg
2025-11-29T12:08:41Z

On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
>> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
>>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>>>> From: Robert Eckelmann <longnoserob@gmail.com>
>>>>
>>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>>>
>>>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> index 785006a15e97..0fb1d7e724c4 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>>> cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>>> };
>>>> +&slpi_pas {
>>>> + firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
>>>
>>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
>>
>> Could be this change done for all the firmware files at once but later?
>>
>> Currently all the firmwares using this legacy path.
>
> I'd rather see the patch fixing firmware paths first and then the patch
> adding SLPI with the correct path from the day 0 (I feel sorry for
> causing pain to PmOS maintainers). Of course both patches can come as a
> part of the same series.

Would it make sense as a follow up, I would changed "the whole sdm845"
to the new paths, so distros maintainers can update paths everywhere
with 6.19?

David

>
>>
>> David
>>
>> [...]
>

--
David Heidelberg