From: Francesco Dolcini <francesco@dolcini.it>
To: jassisinghbrar@gmail.com, Beleswar Padhi <b-padhi@ti.com>
Cc: linux-kernel@vger.kernel.org, hiago.franco@toradex.com,
francesco.dolcini@toradex.com, afd@ti.com, hnagalla@ti.com,
u-kumar1@ti.com, nm@ti.com, vigneshr@ti.com
Subject: Re: [PATCH v2] mailbox: omap-mailbox: Check for pending msgs only when mbox is exclusive
Date: Wed, 26 Nov 2025 10:51:16 +0100 [thread overview]
Message-ID: <20251126095116.GA6168@francesco-nb> (raw)
In-Reply-To: <20251103201111.1417785-1-b-padhi@ti.com>
Hello Jassi,
On Tue, Nov 04, 2025 at 01:41:11AM +0530, Beleswar Padhi wrote:
> On TI K3 devices, the mailbox resides in the Always-On power domain
> (LPSC_main_alwayson) and is shared among multiple processors. The
> mailbox is not solely exclusive to Linux.
>
> Currently, the suspend path checks all FIFO queues for pending messages
> and blocks suspend if any are present. This behavior is unnecessary for
> K3 devices, since some of the FIFOs are used for RTOS<->RTOS
> communication and are independent of Linux.
>
> For FIFOs used in Linux<->RTOS communication, any pending message would
> trigger an interrupt, which naturally prevents suspend from completing.
> Hence, there is no need for the mailbox driver to explicitly check for
> pending messages on K3 platforms.
>
> Introduce a device match flag to indicate whether the mailbox instance
> is exclusive to Linux, and skip the pending message check for
> non-exclusive instances (such as in K3).
>
> Fixes: a49f991e740f ("arm64: dts: ti: k3-am62-verdin: Add missing cfg for TI IPC Firmware")
> Closes: https://lore.kernel.org/all/sid7gtg5vay5qgicsl6smnzwg5mnneoa35cempt5ddwjvedaio@hzsgcx6oo74l/
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
What's the status of this? It's fixing a real issue, and it has been
tested and reviewed. Any blocker to merge it?
Thanks
Francesco
next prev parent reply other threads:[~2025-11-26 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 20:11 [PATCH v2] mailbox: omap-mailbox: Check for pending msgs only when mbox is exclusive Beleswar Padhi
2025-11-03 22:10 ` Andrew Davis
2025-11-04 4:28 ` Beleswar Prasad Padhi
2025-11-26 9:51 ` Francesco Dolcini [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-03 20:47 Hiago De Franco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126095116.GA6168@francesco-nb \
--to=francesco@dolcini.it \
--cc=afd@ti.com \
--cc=b-padhi@ti.com \
--cc=francesco.dolcini@toradex.com \
--cc=hiago.franco@toradex.com \
--cc=hnagalla@ti.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox