From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA3422874F6 for ; Wed, 26 Nov 2025 10:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764151256; cv=none; b=c6BeKK5sGEoIEh9K9H8DweUYixnh2p3EzikQHL8JNOAVIUGoeMCgVbhGh6/pltl+nJRp1Vcr/Y2hQXUNh9dTtZf0jPQIWwGl95oYWRTpQ10Mt1xiWjbPbUGO6rr6Dp86QWqmNPJXed1xLFxhuJPJrVsCVcGcplBCd2RZXIk0rN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764151256; c=relaxed/simple; bh=EUDq/Gnmk628ed8mOX+iBqbZcOk1+V33cWvQsPXbELQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ojNCyUe9oFWQRRegIUwDJkaJ3qPR60Sw9WtwfRoM29jdJroZOkLwW7gCIUJ/0E4F/v5z3FdmZHYBc94BtK1NccttxFF5FSohDoA/4ytBS9FTyyoH62sJJq/WY4qF8riI0InLKvF9B4y+IlaOxzVIxvPhatVH2O097nCBKZ4DNpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Uip/oCx2; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Uip/oCx2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZGi/+Uh5lDFZEhGEXz/lT5gZ9uzEuzrgWwQOIQcoUNI=; b=Uip/oCx2kvM3p2KjNCLg46t5/y nxmZeSVqMJPnvOMkJATPO74nOUD7D+1GoFCPx6h+LxXLODNsYk32/h06r641loNDmyMGwhR5AoT2z SdhGtm3g6nhaSSMdpEcn38qxWUu2TJyQown14G2gsvb1OYt1IkXWls8jWJLVJz16HoYNMhDPzrp10 CNOkL+RWWea2MTz6fMnyj0/4ppuWNVUYhutsTyQLHkXOD9QITkulcMeRwAdys3V7BQN7WDHwXfmVO 8LB7jnnCvCFv8BIAzcRIhHIuzFjGvLOf2zR7HrgQ+fnOglkRqHmi6nnsqWoiw1LWeofVZUYKZdP4g e4C90QoQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOBSq-00000007f6d-3oIa; Wed, 26 Nov 2025 09:05:29 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 3C611302F79; Wed, 26 Nov 2025 11:00:50 +0100 (CET) Date: Wed, 26 Nov 2025 11:00:50 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] objtool: Improve code generation for annotation macros Message-ID: <20251126100050.GT4067720@noisy.programming.kicks-ass.net> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 25, 2025 at 10:06:56PM -0800, Josh Poimboeuf wrote: > For tip/objtool/core. > > As much as possible, undo the code generation damage introduced by > ANNOTATE_DATA_SPECIAL: > > - Remove its usage in favor of SHF_MERGE + sh_entsize, where possible > > - Print the annotation on a single line: > > 912: .pushsection ".discard.annotate_data", "M", @progbits, 8; .long 912b - .; .long 1; .popsection > > - Remove the trailing newline/tab; let the invoking code decide on the > appropriate separator for the given context > > Josh Poimboeuf (4): > x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage > x86/asm: Remove ANNOTATE_DATA_SPECIAL usage > objtool: Consolidate annotation macros > objtool: Remove newlines and tabs from annotation macros Durr, this will conflict with tip/core/bugs. Let me ponder this a bit.