From: david laight <david.laight@runbox.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
LKML <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
x86@kernel.org
Subject: Re: [PATCH] x86/cpu/amd: Correct the microcode table for Zenbleed
Date: Wed, 26 Nov 2025 14:42:58 +0000 [thread overview]
Message-ID: <20251126144258.6dd61af7@pumpkin> (raw)
In-Reply-To: <20251126124453.GAaSb2Ra95ELFXMvJN@fat_crate.local>
On Wed, 26 Nov 2025 13:44:53 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Nov 26, 2025 at 11:33:43AM +0000, Andrew Cooper wrote:
> > Sorry, this needs a {} terminator to be correct. I'll send out a v2 in
> > a bit, assuming there are no other comments.
>
> I'm just glad that I'm not the only one to fall for this no-terminator shit.
Could you add an #define wrapper, eg
#define x86_match_min_microcode_rev(table) \
x86_match_min_microcode_rev(table, ARRAY_COUNT(table))
to pass the count into the function?
Then the terminator can be made optional.
The data will be smaller, the code slightly larger.
So a net size gain since the performance can't be critical.
David
next prev parent reply other threads:[~2025-11-26 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 11:26 [PATCH] x86/cpu/amd: Correct the microcode table for Zenbleed Andrew Cooper
2025-11-26 11:33 ` Andrew Cooper
2025-11-26 12:44 ` Borislav Petkov
2025-11-26 13:00 ` Andrew Cooper
2025-11-26 14:42 ` david laight [this message]
2025-11-26 13:03 ` [PATCH v2] " Andrew Cooper
2025-12-15 7:18 ` [tip: x86/cpu] " tip-bot2 for Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126144258.6dd61af7@pumpkin \
--to=david.laight@runbox.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox