From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [185.226.149.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274AA21E087 for ; Wed, 26 Nov 2025 14:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.226.149.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168205; cv=none; b=BK12Xf5SguQQUvpFuwxak+j0EPW3CQkSjKYef560fzM2DnDs9ddqV/5eVFzFGENIuLMFnSpiqZGziYUJa0fOtWot6escx6PcOqvjzPYOWCM4O+j/SNzOjjjnEtQJeSWd8C+2yPVoafKFCPd2OkO0N6Qd3wc5Q4lRAfdb179EQnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168205; c=relaxed/simple; bh=eOudOIWnm0vNUTVCptGMfHR6EKV6zu6MjRY/Ptdv++w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PoEzPq5vm6npgt5UQ9UwSSL5+paHCewyJbvWGwZuNK+edACttSwCFacTDJw8gI8qLUY/Uls8zV03XxgQwJM6RiG3VGRMO8cW8WITKCCFBGz4VXkxcQHS8mJuP+DlLHFKrBQVSeeuL+nQLptkbGG5mOOq4UvthfUAZAnWA/MQwI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=runbox.com; spf=pass smtp.mailfrom=runbox.com; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b=Gin0xjfR; arc=none smtp.client-ip=185.226.149.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=runbox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=runbox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b="Gin0xjfR" Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1vOGjo-009jfb-4G; Wed, 26 Nov 2025 15:43:20 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=bfGE66AGo4aaz6b8Mg+exZZy/hg9zqRqDJnSHNTnslc=; b=Gin0xjfRGG2RRcVN/4dV5gTEUb QsU8f/GJKtUz8rIIKC+AkTltSrqZg9b7+vr8jAGhmivt6yORF7DfqVIam5wHTX0qvROqiU3yFlFZk aneMS3kIV/mQQmMbtNGB3VQ0XfiA60wia01D2+eTC5hzlzmdIQIfbwliwb5ZW5StenqQ/d+Xa42h3 hQwrMX23kmHBC0LlyKw4Ca/eqHeKrLgdvAdx4YioNHA+nTODdL8cZ3HLqEAk2GBdOWhD1iyWtHDvl 2PTdE8fnyNWKQ2dX4IEEvDCZZVpbcv3kjQ5GieOmD4LnlyDHorFrn4OWE1gNAJW74j7/eyYJHAwUO nhDQk68w==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1vOGjn-00022b-Ii; Wed, 26 Nov 2025 15:43:19 +0100 Received: by submission01.runbox with esmtpsa [Authenticated ID (1493616)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1vOGjV-00Dh2h-0P; Wed, 26 Nov 2025 15:43:01 +0100 Date: Wed, 26 Nov 2025 14:42:58 +0000 From: david laight To: Borislav Petkov Cc: Andrew Cooper , LKML , Mario Limonciello , x86@kernel.org Subject: Re: [PATCH] x86/cpu/amd: Correct the microcode table for Zenbleed Message-ID: <20251126144258.6dd61af7@pumpkin> In-Reply-To: <20251126124453.GAaSb2Ra95ELFXMvJN@fat_crate.local> References: <20251126112655.874792-1-andrew.cooper3@citrix.com> <133ac0c0-8cbb-4c75-a81f-5e2823e1b9dc@citrix.com> <20251126124453.GAaSb2Ra95ELFXMvJN@fat_crate.local> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 26 Nov 2025 13:44:53 +0100 Borislav Petkov wrote: > On Wed, Nov 26, 2025 at 11:33:43AM +0000, Andrew Cooper wrote: > > Sorry, this needs a {} terminator to be correct.=C2=A0 I'll send out a = v2 in > > a bit, assuming there are no other comments. =20 >=20 > I'm just glad that I'm not the only one to fall for this no-terminator sh= it. Could you add an #define wrapper, eg #define x86_match_min_microcode_rev(table) \ x86_match_min_microcode_rev(table, ARRAY_COUNT(table)) to pass the count into the function? Then the terminator can be made optional. The data will be smaller, the code slightly larger. So a net size gain since the performance can't be critical. David