From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB262FF672 for ; Thu, 27 Nov 2025 10:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764237929; cv=none; b=Rl9ih7itpmUglwD0uvdsam4ZLDtArDGevMYLVTao4gX4kPmrkpJ8/hp6tfzYBNK/4cRec0yPPzsDt4xaCckTeZ266r9aQZHxegPZ4oTvtym2S4zPVijdvapHqEUFp3TmZcroj/XKE2scSBJBU/cC5uet9+TrQ0kDUqbpf4vPHg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764237929; c=relaxed/simple; bh=uLSY3q/nIN+A1BLNLSXg2qNd5UXp7rrrcm4lzKY+/aw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H6q0bIYwrH0557+nGQheZE3CdJ9dPdljclkSYtankjEhe+kGvadWmKoFwC2W58pN5VeRQgc+3tMJ8oGwa3Zp3oS+LCLs/6l9VUVS98VpqmV/L4Qbb6/GogjjgETeNQ1hAmrY+TUsYZNeSegKg/cDV3iqRnx4JqxvgCVrHqzvr3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UFj3MLKg; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UFj3MLKg" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so7147505e9.2 for ; Thu, 27 Nov 2025 02:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764237926; x=1764842726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YZgSdDqX071DIvawW7UIpDWp4rfSyH6l1bXthLT7X5s=; b=UFj3MLKgUoxQ095uLLwHOOXmoEjZK9UVnyXoiZal75MOXPuj02Z2uLpbg286j5kjZl JBgAcWqUUKTIUL9HkfnVwyfH7s1z3Am5G7Z1Gd3PMT5hd8sB6d8EfPDRvlLVTjecX57Z 5yDAgVJ4l5cVJe2JgsT+0/2TJgtre9Yz+yeymzgWZOnXAjT7fZoU/905SzM3TPyKR4CV Chiki2qI6DIviHiVxm2QQqzrh00ZM5oSKJc+r3bcQ9ta0aXrTq1Y0++RfUYPJSZCDtGm bi9qkmqpMKBmAp+jXMiMc55/9Q5d42HUr8DYykFR+2J2yVpnBPYxQGyRYXY4CtSVTahW HR/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764237926; x=1764842726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YZgSdDqX071DIvawW7UIpDWp4rfSyH6l1bXthLT7X5s=; b=lHGW8uDIhDktmS0wtTvm5arzSxSzk0/xMQLybeq9N1YPwZi39gLaQz3merCf/8yirU Dq5k5Bsw+Njz/OoGjYyCC7QeDaskpiA8J+GhYp54UbuK8cxC7Cx0aDe1XUppUgICjFts OJjXtl8uGIBn1knIRQssTztnDIgEZ6Ch+4rQWcYKsXcZuENmVDcQtzIobTSh65JHXA0L mRAsAOe55nPn8uFzQPKq/vuBtRCAchC+88LUbZ8h2jhzUFvyn8E1j4o3TpqERUGp1ZXy QotHqZLoXmnwJ6iwWL55XZy3cX2QLpdC6OkpV3pWlmxGLYDPuZw2nOaTbg2FkblSG9/u I0gQ== X-Forwarded-Encrypted: i=1; AJvYcCW8iSCvEWt/HNcycDK1e29N2cmxVTDjUqeojpmG/HJTf0D9h1QwqhohYtF+jYwQ2VbTQLK/GI8PbYcjmI4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9caz17QyBIkfWyB5yGEihn1yhJlGLuO96K9dscuwRmJOO6Fqo EYgFWVOFQvEb0VRx0EosDYf1umTJjRZDRGhvjFe8+8O2QzDYh1OzwBt9 X-Gm-Gg: ASbGncs7CIvkF2/xhYcjEiP+AI3aAnR43cGQgP1eEphncvX5SMj1SX+yD0Ve9wHJMaR OJpKXsKrIQZyoqG1LNxBdqVp799EJWMmHrlgbBHGvxb7fs9wQ1Yh6B7X0iNofSEo5sndQ9rYVi3 Kg9IP3QlLNJRJfvBHRwEYxKoi0ENlsDGFkfnq0i8FaCXIHQQf8Be3p0ZK3eQeAKLEasN1GpAgzB RdkGaYGQMHLSGWD+YqQUX/Sfi/DC/mSH+2GbGIeRfrSvBTe3dmpxSbNC9oTbbZCH6ufFvnqU3IY DUoXCT/ozoMoeZwutXrLDKIGU1YhxHZWfqLtFhkFYKO2MrWxUArgYQVoCTk7eXISqc0tz8PaX9D eTTSQ1/BKdcviXa57E1/X5cUrDN1uYhhupqPO6ZiuqoWu1mPCecOwcrZ8FapWzzV+dgebMdlbEv DsYcpIcm/Z6h8V45g6ptK+fAJ/LNWZPMamYhZieRANLb9FPgFv/nti2eN9P7deJ84= X-Google-Smtp-Source: AGHT+IFY1jgwUDgPqtcZLYuxy0Lcq2WWkQyCPLjZ3gLgZDSUq9NcRpum4zTpdYkH75hax8j7XjTKfg== X-Received: by 2002:a05:600c:1c24:b0:477:aed0:f40a with SMTP id 5b1f17b1804b1-47904b1af90mr119607205e9.19.1764237926224; Thu, 27 Nov 2025 02:05:26 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1caae37esm2522835f8f.40.2025.11.27.02.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 02:05:25 -0800 (PST) Date: Thu, 27 Nov 2025 10:05:23 +0000 From: David Laight To: Sahil Chandna Cc: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@kernel.org, Matthew Wilcox Subject: Re: [PATCH v3 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Message-ID: <20251127100523.6c6f79c6@pumpkin> In-Reply-To: <1e01c12f7666ade41f5f34ada24ad3de1087454f.1764177933.git.chandna.sahil@gmail.com> References: <1e01c12f7666ade41f5f34ada24ad3de1087454f.1764177933.git.chandna.sahil@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 27 Nov 2025 10:41:28 +0530 Sahil Chandna wrote: > Use the min() macro to compute the minimum value instead of an explicit > ternary expression. This improves readability and matches common kernel > style. Also change the return hugepage boundary expression for better > clarity. > >... > { > - unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h); > - return boundary < end ? boundary : end; > + return min(ALIGN(addr, huge_page_size(h)), end); > } > > static int walk_hugetlb_range(unsigned long addr, unsigned long end, The commit message doesn't really match the patch. The biggest part is not open-coding the equivalent of ALIGN(), not using min(). David