From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B181D9346 for ; Fri, 28 Nov 2025 09:31:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764322304; cv=none; b=N/BmNo3a0eKmmUpTC405UY83P22xkimIHQbzeDAl6NNE0RfIex2V64JgFSTH5R75rOjdNam4tInuBv72LBBa+y4mHrfLf3XrGVjWZkNoqYwSn8t4K3pgwLuyhUxfZ3D7Uer37fQAF1u/4yzu4OSI3pDBJanIODp00eiRdhUQMRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764322304; c=relaxed/simple; bh=cVeWVw39Sni5L8P6mjq/RTyvS9TwdpChiV2Csa6OZu8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XfBlCfGBGCZUcLQhk4w5bdXD7g2cFmwZLkKeGy27eNac+8vIgSTzmt3XWBMut0/9BTeOko1+NDfn/qh4cG0g5tdA586JOrX4sN/S/sJNPd7VC0BnJog51vtYbdnPxk80XhFgFeND8DP8rTn3L65MPLp6Ac6VUTyjbMH58tmWf/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=PKPBjcOm; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PKPBjcOm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qKFyNBFbVm8OniUDmIUC5bG/HWDIIyvVJ/JPHgM5KfM=; b=PKPBjcOmbfMrFd2Oq6TAgIyrjw dsHFZ8bdQ9hhFwegT1BJx2g/T4kJ+LEemcNYxAyNP2KAiacrFJt6y/5On1WT3lgMTFxpx7Ndlg9Gg ct41/0Na9XZGGcsefKdvMxFgafqrYTAfxxOLdV5NIvNWVUtBP3zrc35nFHb3VvAXDe9gv/MtxTjVb MaGTU8HrRmLM960ZuDJ9HH0eo3UdKp729EWXnuq/JDQPdlYyuJWaFc0v1lkviqFK2KXegGSAD1Tmh UDUJsb9G0TYSOg+Zu6r93yKXB8gkcQia7K5Tmw/4U8diXGjkjtHhCpcf/pC02bZO2w4uhvnZkWtPk XnqDxslQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOtxY-0000000BdV8-0L5N; Fri, 28 Nov 2025 08:36:08 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 78C78300230; Fri, 28 Nov 2025 10:31:29 +0100 (CET) Date: Fri, 28 Nov 2025 10:31:29 +0100 From: Peter Zijlstra To: Huang Shijie Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, patches@amperecomputing.com, cl@linux.com, Shubhang@os.amperecomputing.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, vschneid@redhat.com, vineethr@linux.ibm.com, kprateek.nayak@amd.com Subject: Re: [PATCH v4 1/2] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Message-ID: <20251128093129.GD3245006@noisy.programming.kicks-ass.net> References: <20251128075454.676765-1-shijie@os.amperecomputing.com> <20251128075454.676765-2-shijie@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251128075454.676765-2-shijie@os.amperecomputing.com> On Fri, Nov 28, 2025 at 03:54:53PM +0800, Huang Shijie wrote: > Save the idle_stamp at the beginning of sched_balance_newidle(), > if it cannot pull any task, set it for rq->idle_stamp. > This changelog tells me what the patch does, something I can see from reading the patch itself. However, it completely fails at the purpose of a changelog, which is to elucidate the reader as to the reasons for doing so.