From: Peter Zijlstra <peterz@infradead.org>
To: Fernand Sieber <sieberf@amazon.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, dwmw@amazon.co.uk, jschoenh@amazon.de,
liuyuxua@amazon.com, abusse@amazon.com, gmazz@amazon.com,
rkagan@amazon.com
Subject: Re: [PATCH] sched/fair: Force idle aware load balancing
Date: Fri, 28 Nov 2025 12:14:27 +0100 [thread overview]
Message-ID: <20251128111427.GJ3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251127202719.963766-1-sieberf@amazon.com>
On Thu, Nov 27, 2025 at 10:27:17PM +0200, Fernand Sieber wrote:
> @@ -11123,7 +11136,8 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> return;
> }
>
> - if (busiest->group_type == group_smt_balance) {
> + if (busiest->group_type == group_smt_balance ||
> + busiest->forceidle_weight) {
Should we not instead make it so that we select group_smt_balance in
this case?
Anyway, the patch doesn't seem horrible to me. Vincent?
> /* Reduce number of tasks sharing CPU capacity */
> env->migration_type = migrate_task;
> env->imbalance = 1;
next prev parent reply other threads:[~2025-11-28 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 20:27 [PATCH] sched/fair: Force idle aware load balancing Fernand Sieber
2025-11-28 11:14 ` Peter Zijlstra [this message]
2025-11-28 13:50 ` Vincent Guittot
2025-12-01 12:58 ` Fernand Sieber
2025-11-28 13:55 ` Vincent Guittot
2025-11-28 13:58 ` Peter Zijlstra
2025-12-01 13:02 ` Fernand Sieber
2025-12-01 12:42 ` [PATCH v2] " Fernand Sieber
2026-02-26 15:47 ` Fernand Sieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128111427.GJ3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=abusse@amazon.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dwmw@amazon.co.uk \
--cc=gmazz@amazon.com \
--cc=jschoenh@amazon.de \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyuxua@amazon.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rkagan@amazon.com \
--cc=rostedt@goodmis.org \
--cc=sieberf@amazon.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox