From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C7023373D for ; Sat, 29 Nov 2025 17:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435812; cv=none; b=m5xNhH0Ib2yNN+m1+gfYs8/v9afs+ctz+qXk30gUup5Q6dbMRUCNNFsnZFBWuc/tA1VUab9qmtzy6TV6YOnhQ5zg122onkKwkwBbYQhuu6evEmT+HB8QbpSdNa1745UmWi6+qDY0Lyu/VZeT1ra3hNFR4mPBZF1ewI5BK881jdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435812; c=relaxed/simple; bh=UG6BImwAw0rc1V/PYQuBi08tBpQDy0BcQj18aGudhAk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BNEG7mu8kuRrDhB+UNwNARkIPnD+h/wL3H608qcwL6DrUgguNarTRuuo5UIumKXJfAj8iNElLLDNd1sZk1ViD4VzQ3Hrue4FQDSObftybgeoFsy8F5BNS4SSx7gaL/e5HiNBK3uIsIlBFKpJKFuA357Ix5BK8Zoffr3bnhRDGyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=sGNMbO6T; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="sGNMbO6T" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47790b080e4so12571885e9.3 for ; Sat, 29 Nov 2025 09:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1764435807; x=1765040607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=w3NL6lljZUIz80S32y8CRSrRW0oz1aLxnHtOot0GJL8=; b=sGNMbO6TC1zfTEnv9YZTlU8jCQMwJJOof4Y5aII5rOvEikVlxvRPRg3i4tunktHly/ 8C5cdHIf67TmcIqjyyHlsfGUXGOdIUVMa2V8M4ElJQFeaCWOgvl5Nmsw/hyXIDHAuPAg 0x1tdXYhNDNAgS+CVJ8pHmwkrped1tAiaZdS7xnuRocNKBLR8aIV9mz2xMZwDdHhSDHC Hxgm2xolQkJx/mB3rG1K8Pt73YC4cTkcQJO2boDcadK6j6PoPhIR0ctQ4GcPwhJjuioV oZiKhgPcylo3JvZ5EBlNwGWipSoS0ADZuSfrKBPeV1Jf2XpaJrzdQDJ0iuSjIGfXUXAs 8SvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435807; x=1765040607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w3NL6lljZUIz80S32y8CRSrRW0oz1aLxnHtOot0GJL8=; b=n8MhbSEDZpmqMGR+gkKP3RZs0jMwnNw7zasHy+oZPXddte62F1f7anIY5NOGHN3pyt gNi3vUSODzP3DjGpXRFjEdBSjpfKd8wHwnHCaBvRSNH8yQKf//4BUstW97eyrNRAg6cB xxSH6P2v5KkPyWGSeDf9Lafm43xt8rNGoDN7vJBVNHGlN8wzS2iWySVWyvFpG+Ji1kXJ nzxPcyAwiLlCWLXx9CHEDp6qz2uru/0NDHNthoqU7xC9aViNlqzAuo5lrM8/sIk118iR DM8SO1Vz4Q8KOJusi4gKJlP+YIl5O/FcsaeZrnS8A0bGKF1XgA7onk8Ub71PVgLiqYuA pPXA== X-Forwarded-Encrypted: i=1; AJvYcCXD46NQLUM0Hhe+grsr3j7+4vUnI432fOo9HuRiOyUQqH3qpvT40fwNi328SEJbDl1i3IyAdMzcwmvet4M=@vger.kernel.org X-Gm-Message-State: AOJu0YwmgchiZtOaPbkXdxUBdiWiOHL1H0BPqnxLYJpHWYoPNLIumpz5 XNC0y0jl0nWH7kaZHcJtwIdNIYhAndW66XXOrlf/Fwqlqsfi9AbxUEIBo7duqwHHkfA= X-Gm-Gg: ASbGncshs3ZxdQKaT/jeNICeq0mo5+9JFp274Pj7SSnSX59FiqrY3DKanD11dJwbc40 qrANRgz3TBjzLDCbZ3ckisQAZsllgLZwEOk9apYuYiVDSRfZ+c4cK/HP6UAAtI8iadzpaAXXXJu Ngm9Kf2JlZ4k89/Asfkr9wKkUrg92db74fumCH3yiSm6X3QS8YV4UjayCegUoA4eZPqjVtUhHub tnUq3z7Xk5MGeb8iSWA2pufy0NIWPbcti5XmFC+45Tr8rQ+YzxNj0ZI69IrtzX/BF+9LVJu0PI0 p9miwi3M6J3U7R5FdHw8zhxY+JIC5AocTK+8ikWjQK3k6Oiu3wEEatQRyRjNnLw10V3xZNe3Sur VUDHsu1cmbW14PXrG/TXk6ZB1RguhJz0TeUwJD8xGb/4KnXg0VXASZrw0BTcOqVBAXYrK099Avw Aqzz7qFbpY3eSdYxbuRzFU4i7g+uBjSNE+iAcUnndS75mYybUccc6IzxVbwi3voQ8= X-Google-Smtp-Source: AGHT+IFMyGWGn1s47jdw8AjAdihGCO1Ca1kpb9N1dRAunGwTYi03BItPfZ0L/KhrSR6N1PNV/cWbNg== X-Received: by 2002:a05:600c:5249:b0:477:5897:a0c4 with SMTP id 5b1f17b1804b1-477c10c858bmr314859575e9.4.1764435806589; Sat, 29 Nov 2025 09:03:26 -0800 (PST) Received: from phoenix.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca8e00fsm16251408f8f.34.2025.11.29.09.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 09:03:26 -0800 (PST) Date: Sat, 29 Nov 2025 09:03:20 -0800 From: Stephen Hemminger To: Vincent Mailhol Cc: netdev@vger.kernel.org, Marc Kleine-Budde , Oliver Hartkopp , David Ahern , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org Subject: Re: [PATCH 4/7] iplink_can: add the "restricted" option Message-ID: <20251129090320.594aa81a@phoenix.local> In-Reply-To: <20251129-canxl-netlink-v1-4-96f2c0c54011@kernel.org> References: <20251129-canxl-netlink-v1-0-96f2c0c54011@kernel.org> <20251129-canxl-netlink-v1-4-96f2c0c54011@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 29 Nov 2025 16:29:09 +0100 Vincent Mailhol wrote: > @@ -257,6 +259,9 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv, > invarg("\"tdc-mode\" must be either of \"auto\", \"manual\" or \"off\"", > *argv); > } > + } else if (matches(*argv, "restricted") == 0) { > + NEXT_ARG(); > + set_ctrlmode("restricted", *argv, &cm, CAN_CTRLMODE_RESTRICTED); > } else if (matches(*argv, "restart") == 0) { > __u32 val = 1; Good example of iproute2 has banned use of matches. Because usage like the (think of what happens when user was previously using 'r')