From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95984224AF1 for ; Sat, 29 Nov 2025 17:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435852; cv=none; b=IETOdTx58ATKYkTRSLn9PhvkxG7sKFWVR3W/g9syGrQ3YK9cTGeRE5TQ5qSPGBljozNp1UOytQ+tR7dJU7latVN9gaLxQEqg+waQnspuukrXB5I+2B7n4B7ZK6ghTuTSh8KXAgvbgIgEoObI8X8FhQUTfoWVQK208UtYp8ZWiM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764435852; c=relaxed/simple; bh=1ofg9EbWX3TxmwN9MuMZWoXX9LDX+R4phsPu3w2Jy7c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KUL79OogwQBBU109Esn7VvZ6VE0SmOwC/jpxt7nD7/5xIYXnjC21+nup5DWI2zAGJdcFGw6MsQDJgSe6Ijbaj32cVoYRj9L4XDoIoTs+BK48gHRJi8Z7c2OH7NM8i6qu/wITWXeW2pHR6g5ueRNkZo3QuY22Tf1EEbgDr8degKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=jAHcuCL7; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="jAHcuCL7" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8826b83e405so38564736d6.0 for ; Sat, 29 Nov 2025 09:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1764435847; x=1765040647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=e0JrUY6rvuTDOtsRxKK87/+s+sI+ekupf3sIqBsYK/M=; b=jAHcuCL7uwpZnl40rR2bXPZRfEbNhO7WD6ASwTW58LSD05Lhk+gOiwKWSThKUsCpq8 OOgStgmS42YMV1t6dPSJ5I7khNpvx96odfvOJOOj6Rs9HWlBQtJdh1oM5DvZTwgkNdh/ 6Ags8VhexSN4/tO5OF5RT2Uje8bjdq5HHhXTP7fqr0vWNVkyNFWIKR2/Q8QlsI+IPTqz 16LXjQOOrrunN1xevzuaPEHJ8a21ubbXh3p3LYCM/svD80s2HlvPg1ucw7or7wElpZAM Fpjmd1CA6HhA7WS0X+nEDLgUn9Z2S+msQZgAhkWBvPKaRhb2B3134CotX3x3yI+EPn4X Y9jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764435847; x=1765040647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e0JrUY6rvuTDOtsRxKK87/+s+sI+ekupf3sIqBsYK/M=; b=F9TE82LvZQTQFqMB2aLQ3ZvTPrLH4WkY8+kzuxf7AdMylp9z1J6NlHoHUXPm08DbS9 YPlAnl/U+W10C5PkvIRGngnfzpG7IbVE58e87ZtAv5Qr31YoPLJIxk8NcD+97Nwg3T+Z xj/X6ky2ev8XMLGPIMQH91H3O7Bre0EEKu4QkNfxvusbWakiJyiBlupYwZrcJkhUaawx rOgPRGc+o7OvBxrmhxdP4SZCAjirTKv/eiSCcdsfb0KLo3NuIgpXCkYTBCaoOxJCg98g LCPltoSrK8m4gXct9AzGUDdQYvc/+Fl4FkdfOn6VdZ5BtRO9TdpNSQrVS8PPU1yQ17M/ yA3Q== X-Forwarded-Encrypted: i=1; AJvYcCUSc8Fsz7nKIESHwBxTOr4/6QdyeM+B6G7H7wAK/YbJo8qcY/IApGzusiX+RIzAXVNkFPydfNBdJ7DAS8M=@vger.kernel.org X-Gm-Message-State: AOJu0YwWzZ8jZhAb4h7Eb4J05x1ilnq8xYUei4WjFlxNBCXdOaQsArY+ aCyRgQ1QJX+Tc5s1pb7DDtM1YiwGnq2o2SBiFHqzekXmhcMoHo0W8CAdeLKQBEiWKiE= X-Gm-Gg: ASbGncvzVUB97afT42ZRZlNwhwCXyboqDq/2gXHTA5K55315Tn597w4CYBE65R86Ugr OVt9N0sLVLQPKF+F+U9S4estqq5liyNtU0dTIV7ZIGX0DaHxD5lIew2QWbpz8mFuwIQLhahejJr ynd/amqiKhD5yv/6te6uKfWV+jS7E0D1gvAjqN/QIfoufuNuvsWn9e0ZNueHlyfQK1he9mqdmTk OJeH7XaCUi1YprvEyeqNiu991sM4FZ7vN0p5tvxB/5nSNQEHFqy1SSzpfQYcMoeZL6ip+cK21wA Uy/TfscqkkoXfWtpy+g6BCEZvXJp1BY6v5z5S3I8zkXBA86Gc6GB0Bk62fx9Y6WwqrzD/v1PhY1 E6iT83wSB+MGUR7URe5YMP5YfCbTBhRWNMe3Vw9stSegryqZGoq54BNgSWU1De3sdtk5O7DzuyY d5wQAGDWr2y6Dr6koOTjyyeHForJw3WuO3SHi9qJzrAc7UcB7D25cq X-Google-Smtp-Source: AGHT+IEsSYkJd/FdkKfzHFclbNhdV73ou4fwyHJU3DgvCYF8sNlh+2gMj51qTXwK/lGbmiBeIwi1Zw== X-Received: by 2002:ad4:5c68:0:b0:882:4976:5eda with SMTP id 6a1803df08f44-8847c49c7b2mr465642206d6.4.1764435847467; Sat, 29 Nov 2025 09:04:07 -0800 (PST) Received: from phoenix.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-886524e5cfcsm51008366d6.19.2025.11.29.09.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 09:04:07 -0800 (PST) Date: Sat, 29 Nov 2025 09:04:03 -0800 From: Stephen Hemminger To: Vincent Mailhol Cc: netdev@vger.kernel.org, Marc Kleine-Budde , Oliver Hartkopp , David Ahern , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org Subject: Re: [PATCH 5/7] iplink_can: add initial CAN XL support Message-ID: <20251129090403.5185f2ee@phoenix.local> In-Reply-To: <20251129-canxl-netlink-v1-5-96f2c0c54011@kernel.org> References: <20251129-canxl-netlink-v1-0-96f2c0c54011@kernel.org> <20251129-canxl-netlink-v1-5-96f2c0c54011@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 29 Nov 2025 16:29:10 +0100 Vincent Mailhol wrote: > + } else if (matches(*argv, "xl") == 0) { > + NEXT_ARG(); > + set_ctrlmode("xl", *argv, &cm, CAN_CTRLMODE_XL); > + } else if (matches(*argv, "xbitrate") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.bitrate, *argv, 0)) > + invarg("invalid \"xbitrate\" value", *argv); > + } else if (matches(*argv, "xsample-point") == 0) { > + float sp; > + > + NEXT_ARG(); > + if (get_float(&sp, *argv)) > + invarg("invalid \"xsample-point\" value", *argv); > + xl_dbt.sample_point = (__u32)(sp * 1000); > + } else if (matches(*argv, "xtq") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.tq, *argv, 0)) > + invarg("invalid \"xtq\" value", *argv); > + } else if (matches(*argv, "xprop-seg") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.prop_seg, *argv, 0)) > + invarg("invalid \"xprop-seg\" value", *argv); > + } else if (matches(*argv, "xphase-seg1") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.phase_seg1, *argv, 0)) > + invarg("invalid \"xphase-seg1\" value", *argv); > + } else if (matches(*argv, "xphase-seg2") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.phase_seg2, *argv, 0)) > + invarg("invalid \"xphase-seg2\" value", *argv); > + } else if (matches(*argv, "xsjw") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl_dbt.sjw, *argv, 0)) > + invarg("invalid \"xsjw\" value", *argv); > + } else if (matches(*argv, "xtdcv") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl.tdcv, *argv, 0)) > + invarg("invalid \"xtdcv\" value", *argv); > + } else if (matches(*argv, "xtdco") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl.tdco, *argv, 0)) > + invarg("invalid \"xtdco\" value", *argv); > + } else if (matches(*argv, "xtdcf") == 0) { > + NEXT_ARG(); > + if (get_u32(&xl.tdcf, *argv, 0)) > + invarg("invalid \"xtdcf\" value", *argv); > } else if (matches(*argv, "loopback") == 0) { > NEXT_ARG(); not accepting any new code with matches()