From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC26320B7ED for ; Sat, 29 Nov 2025 23:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764459985; cv=none; b=YimHoJQ9qqZ+WGakip1xtxyZY5KQCAC+1F/BC2E+JdaBwO3CNGtHNCFyN1KXGIx+kNFtowj25TnjYVUo+NOsTeHfSfMYv0i0GoL+V7/eFIhUtQv/WlFWwFcl3VuAGvd/jxntow5MpZC7Z0wpJPdqPo3cOId7uRUwWU5xmMBtyRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764459985; c=relaxed/simple; bh=Y0efvnYW+eSM394k4UkkYLAlJJqaQa7sEuGtHbXQwzk=; h=From:To:Cc:Subject:Date:Message-Id; b=i1RRN11oG4tvQmSk1pUpi33d+tQNLflyzr7OG1QI4E1x9UUE4xbme4gWCSSz0Tg/kcjjca0olpAb1WZ20l+4JaR12Bo22KChgyZo5FWIg8crXW7X3bLOmRqx5TXtzByKcDwqx6CVA1i7Z2jzJEoa64Deq23b+f8mYF2XIUuQY8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RuFCVSg8; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RuFCVSg8" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7bc248dc16aso2427540b3a.0 for ; Sat, 29 Nov 2025 15:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764459983; x=1765064783; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Oic4BVwh+qFMk9xigP8owFPlA2EeqW1hA7c8LL97tvU=; b=RuFCVSg8pa/vf8zXBiblhxq+0/OTwVvXT89iMIYNnfW7Dlx5xtbBTeD8P+GrNm5qKN 985FB9D0yUcyxrhYqSmHd04Q3XlFjh6EaYvOkiD1SQiRPI4Y5NDz2skf7yITkscQmyc6 CmS/SB3ehlCgqU1OaIdC0mLlwHXrr4h04iLVkb6pCksKbpy/Nj8MMpOiSi3Dyj+tvmAJ Dc7ImHG027EZelt+ZdYrjqJHGnAHfGPhSjmLYMjaslp3OIQGXdv/YkiCP1Gl+ajJCSoO QsPAlpCndo4NDYyXBO5VsN1GxcI0/n3a5QpKsNHgbyw2eO3z1/O+khSfsut0NOowxayq eZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764459983; x=1765064783; h=message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Oic4BVwh+qFMk9xigP8owFPlA2EeqW1hA7c8LL97tvU=; b=N0hI+VT6vtvdjxsOw6o+20UvqGPqd2jUEn+1hetWVttWPl/xiGFPiThDv6f0QN/4sH QrA8xMDw5Ijra+fpLxNe7442HhUNniN7EOEr7Iv2oYHm94AZvxIveRQZHP5XrScErJ9e Fs5YFVfxPajvkr+4APokkqR+Eju+EKPRDzyw/U90FdPdCxPlMxBMd9xq1yisNSvO1yn/ RUicFYSx8in2v8xe2JtOnW7vBUsHkdzvhJJ7YvwLht4E9rBkejG+mj8Woz8xepDlUW3j uQ8JLiQAsAMwvkHS5SU4UAOWd9kYKIS+ejIQPOs0gYPH87x4Smle7oZ99kZ2u+k0oZQc 0h1Q== X-Gm-Message-State: AOJu0YxBlDlYezbpj1J2iUQQSnoeAxZzBGvjlqgsEpaVmWOvZmjpldRi A0izE9L4VG5PIIsd/wfNrD4u2U9iZT1QYrZ4yv1pmpZ44wvYhpIEAsc6 X-Gm-Gg: ASbGncuVpyjjPUEoqyDJvA2/So9UPhZNhR9imiUaQQCtWK0oi9OTLmSU02C8MUwifvq 5zq8CL+KzAuzx7fvGAIG+KgLeW/8S5PnBvotoJb9McskN9FFaQJ5PGTg2yX5ezmXOX+iit0zMXs F5GqtLamJGldtJmhMcaarZdEgPDHac19ih4hMKDE/oZYULEcvbzRltpC1V1/0XYuGdJB+ZsNaIr 3Tx1QkEIyP1gpQmCIY1QCTiEnOYGWwMA4a1DkeOCv/IW6vzR0rKqmamydw/ZFgKT7ReVUKtExPk PJit3oryzwKrpvivo8y9zo75vIEvd074jmPE98TtcqhN1cZxQs3MKpoQKOPLFcJgrau/wAuZDhx B8+Rbwvh+/ltecK8YOZndjfcFBJ3uuUjxy924po4Qd/8ZziihdpC/EvBZApqAPkcVWLEJkFQuxP GWT3OE4mmDgpokSg1J5c6nExnuXg== X-Google-Smtp-Source: AGHT+IG1ssiyNwGsFp5F+wk0jylpdPRdZeUSnJ9+OhyOhmGPlt2Dzx5MOnNqeZxTuc6PCZk9MVCk1w== X-Received: by 2002:a05:6a00:2389:b0:7aa:bd80:f4db with SMTP id d2e1a72fcca58-7ca8740ec4cmr18933879b3a.5.1764459982924; Sat, 29 Nov 2025 15:46:22 -0800 (PST) Received: from SC-GAME.lan ([104.28.201.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15fc08bd1sm8921049b3a.63.2025.11.29.15.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 15:46:22 -0800 (PST) From: Chen Minqiang To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Chen Minqiang Subject: [PATCH v3 1/2] ARM64: dts: mediatek: fix MT7531 reset GPIO polarity on multiple boards Date: Sun, 30 Nov 2025 07:46:02 +0800 Message-Id: <20251129234603.2544-1-ptpt52@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The MT7531 reset pin is active-low, but several DTS files configured the reset-gpios property without GPIO_ACTIVE_LOW. This causes the reset GPIO to behave as active-high and prevents the switch from being properly reset. Update all affected DTS files to correctly use GPIO_ACTIVE_LOW so that the reset polarity matches the hardware design. Boards fixed: - mt7622-bananapi-bpi-r64 - mt7622-rfb1 - mt7986a-bananapi-bpi-r3 - mt7986a-rfb - mt7986b-rfb Note: the previous DTS description used the wrong polarity but the driver also assumed the opposite polarity, resulting in a matched pair of bugs that worked together. Updating the DTS requires updating the driver at the same time; old kernels will not reset the switch correctly when used with this DTS. Compatibility ------------- Correcting the polarity creates intentional incompatibility: * New kernel + old DTS: The driver now expects active-low, but out-of-tree DTS still marks active-high, causing the reset sequence to invert. * Old kernel + new DTS: The old driver toggles reset assuming active-high, which now conflicts with the corrected active-low DTS. This was unavoidable because the original DTS was factually wrong. Out-of-tree DTS users must update their DTS together with the kernel. Signed-off-by: Chen Minqiang --- arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +- arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts index 9f100b18a676..6f29ce828fdb 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts @@ -155,7 +155,7 @@ interrupt-controller; #interrupt-cells = <1>; interrupts-extended = <&pio 53 IRQ_TYPE_LEVEL_HIGH>; - reset-gpios = <&pio 54 0>; + reset-gpios = <&pio 54 GPIO_ACTIVE_LOW>; ports { #address-cells = <1>; diff --git a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts index 8c3e2e2578bc..6600f06ccebf 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts +++ b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts @@ -137,7 +137,7 @@ switch@0 { compatible = "mediatek,mt7531"; reg = <0>; - reset-gpios = <&pio 54 0>; + reset-gpios = <&pio 54 GPIO_ACTIVE_LOW>; ports { #address-cells = <1>; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index e7654dc9a1c9..8ec2ec78ee46 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -203,7 +203,7 @@ interrupt-parent = <&pio>; interrupts = <66 IRQ_TYPE_LEVEL_HIGH>; #interrupt-cells = <1>; - reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 5 GPIO_ACTIVE_LOW>; }; }; diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts index 5d8e3d3f6c20..958ce291336b 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts @@ -87,7 +87,7 @@ switch: switch@0 { compatible = "mediatek,mt7531"; reg = <31>; - reset-gpios = <&pio 5 0>; + reset-gpios = <&pio 5 1>; }; }; diff --git a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts index 58f77d932429..0780b5a36259 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts @@ -64,7 +64,7 @@ switch@0 { compatible = "mediatek,mt7531"; reg = <31>; - reset-gpios = <&pio 5 0>; + reset-gpios = <&pio 5 1>; ports { #address-cells = <1>; -- 2.17.1