Re: [PATCH 3/4] block: add IOC_PR_READ_KEYS ioctl

Krzysztof Kozlowski
2025-11-29T14:32:40Z

On 27/11/2025 08:07, Hannes Reinecke wrote:
>
>> + size_t keys_info_len = struct_size(keys_info, keys, inout.num_keys);
>> +
>> + keys_info = kzalloc(keys_info_len, GFP_KERNEL);
>> + if (!keys_info)
>> + return -ENOMEM;
>> +
>> + keys_info->num_keys = inout.num_keys;
>> +
>> + ret = ops->pr_read_keys(bdev, keys_info);
>> + if (ret)
>> + return ret;
>> +
>> + /* Copy out individual keys */
>> + u64 __user *keys_ptr = u64_to_user_ptr(inout.keys_ptr);
>> + u32 num_copy_keys = min(inout.num_keys, keys_info->num_keys);
>> + size_t keys_copy_len = num_copy_keys * sizeof(keys_info->keys[0]);
>
> We just had the discussion about variable declarations on the ksummit
> lists; I really would prefer to have all declarations at the start of
> the scope (read: at the start of the function here).

Then also cleanup.h should not be used here.

Best regards,
Krzysztof