From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9831429BDBC for ; Tue, 2 Dec 2025 18:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699524; cv=none; b=j3PKn4Kf259V20wVz6VvLIEiSzHnW+luK5msFETg+hiMZWLEyCUIs6RlsE/Sl3a3Icd/PLhiwAhHn/8b+7gRRHoewJjgQF4TdLFseg5TOkl6vybs2F8Fetrdwsj4pIcZx0yGdy3r/qx5DkR5x+9qntKY4S4hEAYYh5vWBxB+idc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699524; c=relaxed/simple; bh=tzmtCptD7yAtacgQMx8Kaqwh1eETLR40s0EYMNAoub8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qB2rNwc7S3y++dV+tM5YOzEtx0FYfIkmX4ClVNCzCFS1WdzPIyPCayZf5q4NvsKihVPFYN4E8KV/nTn5BX9/JruFWQ6DuEwcmJM2rD9v5j3DLHjh023u8wzIHbV7/dMOEJOcKbPYrzWL82YirxOKqiWA4lrNLAKSoSOJrGNGAsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QU/W9I2C; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QU/W9I2C" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso702505e9.1 for ; Tue, 02 Dec 2025 10:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764699521; x=1765304321; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oMaGaxh0YRUd9QK48pCWqjlS6PxlgAD8GrQ1+JyqkxA=; b=QU/W9I2Czbb7kqUEJ5YG0CXEMRA8Xx1l9cECbQDVB2htLmhpEKCg5YlJ4w0KA2yCDc k+MOxFX2AO3qglnLmxyykFvtgKkXiXB718eVlf89bLNuA02NDsJ6db5pr5tC/20Y+Vt9 945QrCtDcejweCtMLra9oG1Kb89N1y2+6AFBh8Y85OZlBrteK/rD2A+YBc+Kr4i3jZll kNFeOpjbSG7bq72ELcDBf4xkv3UOw05nmh3zTCdfMHNxL/au5vx9XGRe44xksZftQbx1 B5bKFHIbR7gYZZfy1aY6C3e1yvtNJ0PQ7edD6DjDGe+Cxd9ss4oWTwJYoRgxZl+ljMFj 2+Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764699521; x=1765304321; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oMaGaxh0YRUd9QK48pCWqjlS6PxlgAD8GrQ1+JyqkxA=; b=VpflN8kjrLxbihuYQTx5hqKVIApMkxtPmeCTfd9XF/Lp4+OCXYfWZUXKuFcUFvRX8Q ROwFuYdfF2fVbahbIGaUyk9tE3T+k1AEisOEH5ZRgnnGXGgySVPlAedqBWQyfVwH5wgr 85DQc8aw+rwjbNPR71tnC2lYXwvdvVVxNVaI7HBOGsevCT7Jy+Fu12Dm2pTAVJD6rUJA Ki4T+DMjlKEB/pvZnplPzIJUwOd/JLrKalcLVC3l7b0Sy5Js5NF/lo1agpyXgh3FtWCY hA4JRd45tZXyoPf5KgyB6UR86O/+wTDkUkzl2qMUoHjYx4J5GH6FTWcmYFNLaPyHArlK PaOw== X-Forwarded-Encrypted: i=1; AJvYcCWAuuUGKFUXQa9p6LaTQv/w/g0VcF9u8HgjzORyIv00j/E2t1SdRqUhtEJi1RAtAwVEpbKDAK/9D6lbsM8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9Zgkm4cCHbjazS1fmnVybabgVwbuJTDWh9QsT6a0fLWVl/ZUo ZRaHonz7/ANjiv/3Lhy0cO4GxQd2kQBAkG0jxY1pyObornxneoy2dkVh X-Gm-Gg: ASbGncvWeLPG1+JbccjN3Qo6htwDGT9WAuwKSEOR69UUa6xkBRhrs4CZG3izzZS8VGs d0HgP7bSyEp86swMKWhXHq23VzWPqp3mO7IzVDY+My+9Lka+pim+ua6oNOtGq8deVOjR2swob38 Q6EBlVHxggPBiWVj8A+/w9dmRkBaqQBKKd1vzW3oZU+OSnl2xcMNFVtbndaqYwK01XOIpg2eypj 0sT+AtqLU0Han25qUKpLxJx8ytLdE62nY+Ryud4Heqi8M0cWXuGCC8LgtNT3M0wJZwys9f+1kxA 8rOVxyIzGu1TqElD4vucnF7seBP1K3hWZsvezEUugdBdVMWmS8lQOWeb6+0KHHU5Y5J+DF61rfC uUqOKURxZo0Qizkal9H4BskkLPiFVe/OWjG5vWLOByUSDKu4gud4C1BVVqryQI8GAH7G0Le8I7d 2uXA8X47MZ X-Google-Smtp-Source: AGHT+IFpqsraLWCCHwhEXFKi4e3WsR3FPFZwmAKdbIMf3+2pgCt4nyGOLKosPrFEDzC4HROyjCVXIA== X-Received: by 2002:a05:600c:5614:b0:475:de06:dbaf with SMTP id 5b1f17b1804b1-47926fdf387mr26345085e9.17.1764699520620; Tue, 02 Dec 2025 10:18:40 -0800 (PST) Received: from legfed1 ([2a00:79c0:6fc:d500:22ea:3d6a:5919:85f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792a79ec06sm3224615e9.5.2025.12.02.10.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 10:18:40 -0800 (PST) Date: Tue, 2 Dec 2025 19:18:38 +0100 From: Dimitri Fedrau To: Thorsten Blum Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Guenter Roeck , stable@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: marvell-88q2xxx: Fix clamped value in mv88q2xxx_hwmon_write Message-ID: <20251202181838.GA3355779@legfed1> References: <20251202172743.453055-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202172743.453055-3-thorsten.blum@linux.dev> Hi Thorsten, thanks for the fix. Reviewed-by: Dimitri Fedrau Am Tue, Dec 02, 2025 at 06:27:44PM +0100 schrieb Thorsten Blum: > The local variable 'val' was never clamped to -75000 or 180000 because > the return value of clamp_val() was not used. Fix this by assigning the > clamped value back to 'val', and use clamp() instead of clamp_val(). > > Cc: stable@vger.kernel.org > Fixes: a557a92e6881 ("net: phy: marvell-88q2xxx: add support for temperature sensor") > Signed-off-by: Thorsten Blum > --- > drivers/net/phy/marvell-88q2xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c > index f3d83b04c953..201dee1a1698 100644 > --- a/drivers/net/phy/marvell-88q2xxx.c > +++ b/drivers/net/phy/marvell-88q2xxx.c > @@ -698,7 +698,7 @@ static int mv88q2xxx_hwmon_write(struct device *dev, > > switch (attr) { > case hwmon_temp_max: > - clamp_val(val, -75000, 180000); > + val = clamp(val, -75000, 180000); > val = (val / 1000) + 75; > val = FIELD_PREP(MDIO_MMD_PCS_MV_TEMP_SENSOR3_INT_THRESH_MASK, > val); > -- > Thorsten Blum > GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4 >