From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E172D24B8 for ; Tue, 2 Dec 2025 19:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764702549; cv=none; b=T7nCBZmYHX5yQuFDo0a94pWSxZZahsircDIeV/2i///7AXmrt3gpw6oodmGrLXt+UjBaP1aY2POsj32AWnpMVD1gu89nTER+11/+I7SabjWiAPuH0hpLBSBV/e+HAd5P4iCWr6eanUeM7zqlQTy1M1pt/p69xciXaMrBTrugy2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764702549; c=relaxed/simple; bh=wQ2Q1bYuGpPDFmUhq9r5xNJXmVin/Q0cttq22S6x+0U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sPd6i2rJRCo1fg2TInk584be4UsHZYbCPHvm0qrR/kBvoRUmy7efQsy92aA/xMqe3ttwOifWuL+qCRVvzaaxoAh2rTOkRkkh2pP5WpfOABCx1jr7S8eYPKnUvkGpkpeNsekGm5PCVRBafDOxR7ckrN4yeK5WPWLENQbbj1lTYxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ze0dkdeG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ze0dkdeG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47789cd2083so35143345e9.2 for ; Tue, 02 Dec 2025 11:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764702546; x=1765307346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=A/dj2hPQG6+B9AxmgFXbvm/Feu7VMS9EdlNKmCT8+Y4=; b=Ze0dkdeG1JubEnwRQaUYFp/NYZZlzazUTTotPLJvahkM87xoWpUJ3ECEekWXVT9QW9 lsAxkAUXtFhOAputq4o7mumNpfffHeWUgIio7M21mOVuevr94O1Z+avM/qOceVqpBftN fpj9ChShBlRF4wsNNtk1wa4Mh5wUqC84DnSRYzGztRnLtU/HhcFZ4qRivMpKrz/BxWIe nB+E+v39Mj3Q764P/ZlBPz0kdr7Wx12o2CQIixpLC90cUrjd8ObVriSHii5AWVV1NRJA u9EY4Y4bElwmMXdVCqoHhZB7xnRV0FaSQNDA3upTscAS9YVANGZKLbaTF7mN2StmcnzX Sn6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764702546; x=1765307346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A/dj2hPQG6+B9AxmgFXbvm/Feu7VMS9EdlNKmCT8+Y4=; b=Pd8DpHz5HcIhRXjAvbm1W/wSvrE9lnCZX9vZGrkbfexTxTy3Pi8V0CqY4P1lbJxULJ ZfT2bySVN+EIywAMl5XI50cUY2sEY00gDKywi3m+HAvVl4X67kOp56EzhoX4wUCw3Qyl hcRpQw0l5Tuqkii2sugdEPwhCILrkb1pKT3svFrxIRG576LzLG7IbtjZE6yZKOb/g7+6 v/p55sVX9lW9SdAhyQ4quqi8ypa28AkHJx1GujzROvZ6j1TRG1Grie/gKZfFRPOIbwox 7JSnl+PXSPjLynOxBQllCZH+pS7dmF1r4efqjrRbgixyxOSD/1Z6BH+yBXD4rLYkv6/8 ApxQ== X-Forwarded-Encrypted: i=1; AJvYcCV1wL7t1u/jIuhvTtAzv/MWoYDjPnRC3FsuxSdB63O7/ElunxHOsf4oZx6vEoxYYrDvjYTT5pmtbzDOFSg=@vger.kernel.org X-Gm-Message-State: AOJu0YxrYFRg6p7GjxjbmR/zH+e2nuZcOW/rcA7FsfRw/zVaX/Z0B4p1 4mvS5JVMR5A/ZiGGlRjDRyZhklcPswTK9RAx/eGQ5ls9a+P5hLXrh/bE X-Gm-Gg: ASbGncsDoxjoDa06EuWy9QgnUjJrWI5K2wrFl0cjVsAFvE4yEbLAap+zzdljPOYRunH OVzPsYe5oStuFCQpweAlad5IOTwKMPG2rBDOEjnZyACibsUFK/iMd4BoBbag+9w6piFGtBzpY3e 2zgvd70KD91Vy9DBUEtXDcBKxqyKI88iaMD0pQBVpfjYS1iL26Fc7GTu/7x7MtqFnnx8+AF0g/A BEX+UfAgArwF49679QL6wAEmNg5Mw85N3EyZIqAyDbodm9sS6/HHb5q3vkxeshbMnQ0h5mSTChG FBGDill6z/Nbz22MfiYwSNsrKyqanaBB+6slNSsymh7wll20ftL3Jci3Sx21YoIlSxYGdBF842I y8DzjIlTa8uY63W3yRYdrxgbkVY1Nx00IYM2dAfMf+BQAhubSdQQlK6MqRlgSSwhLyI7eGmeTeN ckxEPFNKKmH3vxD234+7/ZI+AVmePUo6glAJgSzpR8kmJ8hGzsyuKQ X-Google-Smtp-Source: AGHT+IEtzByVDUpfRwdPJhgEZAkt4IcyAqDRpceCKifmprijqsNezKq/3tRdzvxL2j+KRrl1ctujJA== X-Received: by 2002:a05:600c:8b16:b0:477:9e10:3e63 with SMTP id 5b1f17b1804b1-4792a4c0738mr6652335e9.35.1764702546145; Tue, 02 Dec 2025 11:09:06 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792a4bd422sm3406265e9.2.2025.12.02.11.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 11:09:05 -0800 (PST) Date: Tue, 2 Dec 2025 19:09:04 +0000 From: David Laight To: Thorsten Blum Cc: "Rafael J. Wysocki" , Viresh Kumar , Thomas Renninger , Borislav Petkov , Jacob Shin , stable@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: amd_freq_sensitivity: Fix sensitivity clamping in amd_powersave_bias_target Message-ID: <20251202190904.27c9bc06@pumpkin> In-Reply-To: <20251202124427.418165-2-thorsten.blum@linux.dev> References: <20251202124427.418165-2-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Dec 2025 13:44:28 +0100 Thorsten Blum wrote: > The local variable 'sensitivity' was never clamped to 0 or > POWERSAVE_BIAS_MAX because the return value of clamp() was not used. Fix > this by assigning the clamped value back to 'sensitivity'. This actually makes no difference (assuming od_tuners->powersave_bias <= POWERSAVE_BIAS_MAX). The only use of 'sensitivity' is the test at the end of the diff. So I think you could just delete the line. David > > Cc: stable@vger.kernel.org > Fixes: 9c5320c8ea8b ("cpufreq: AMD "frequency sensitivity feedback" powersave bias for ondemand governor") > Signed-off-by: Thorsten Blum > --- > drivers/cpufreq/amd_freq_sensitivity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/amd_freq_sensitivity.c b/drivers/cpufreq/amd_freq_sensitivity.c > index 13fed4b9e02b..713ccf24c97d 100644 > --- a/drivers/cpufreq/amd_freq_sensitivity.c > +++ b/drivers/cpufreq/amd_freq_sensitivity.c > @@ -76,7 +76,7 @@ static unsigned int amd_powersave_bias_target(struct cpufreq_policy *policy, > sensitivity = POWERSAVE_BIAS_MAX - > (POWERSAVE_BIAS_MAX * (d_reference - d_actual) / d_reference); > > - clamp(sensitivity, 0, POWERSAVE_BIAS_MAX); > + sensitivity = clamp(sensitivity, 0, POWERSAVE_BIAS_MAX); > > /* this workload is not CPU bound, so choose a lower freq */ > if (sensitivity < od_tuners->powersave_bias) {