From: David Laight <david.laight.linux@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] objtool: Fix stack overflow in validate_branch()
Date: Wed, 3 Dec 2025 19:37:41 +0000 [thread overview]
Message-ID: <20251203193741.2be672de@pumpkin> (raw)
In-Reply-To: <aTCMR-7K34UNuxDe@gmail.com>
On Wed, 3 Dec 2025 20:15:19 +0100
Ingo Molnar <mingo@kernel.org> wrote:
> * Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>
> > On Wed, Dec 03, 2025 at 10:54:19AM -0800, Josh Poimboeuf wrote:
> > > Keep in mind this is a worst case function for objtool: KASAN with tons
> > > of memory accesses. The vast majority of functions won't come anywhere
> > > near that level of recursion.
> >
> > And BTW, supporting that further, the max recursion depth on vmlinux.o
> > on a defconfig kernel is showing 162.
>
> That's mostly immaterial - 'make allmodconfig' is not some esoteric
> test, it's one of the most common testing methods by developers and CI
> projects ... For example I use allmodconfig builds for every commit I
> write or apply.
Both allmodconfig and allyesconfig should probably manage to disable KASAN.
Apart from building faster, the object files will be more realistic.
I'm not sure how to make that work though.
Could you have an ALLYESCONFIG config option that only 'all yes' will set and
then make KASAN depend on !ALLYESCONFIG
David
>
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2025-12-03 19:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 16:16 [PATCH] objtool: Fix stack overflow in validate_branch() Josh Poimboeuf
2025-12-02 16:20 ` Ingo Molnar
2025-12-02 16:49 ` Josh Poimboeuf
2025-12-02 17:03 ` Ingo Molnar
2025-12-02 17:11 ` Josh Poimboeuf
2025-12-02 19:56 ` Josh Poimboeuf
2025-12-02 20:20 ` Ingo Molnar
2025-12-02 22:05 ` David Laight
2025-12-02 23:01 ` Josh Poimboeuf
2025-12-03 11:02 ` David Laight
2025-12-03 16:11 ` Ingo Molnar
2025-12-03 16:40 ` [tip: objtool/urgent] objtool: Add more robust signal error handling, detect and warn about stack overflows tip-bot2 for Josh Poimboeuf
2025-12-03 18:48 ` tip-bot2 for Josh Poimboeuf
2025-12-03 9:25 ` [PATCH] objtool: Fix stack overflow in validate_branch() Ingo Molnar
2025-12-03 18:54 ` Josh Poimboeuf
2025-12-03 18:58 ` Josh Poimboeuf
2025-12-03 19:15 ` Ingo Molnar
2025-12-03 19:37 ` David Laight [this message]
2025-12-03 20:30 ` Linus Torvalds
2025-12-03 23:53 ` Josh Poimboeuf
2025-12-03 19:11 ` Ingo Molnar
2025-12-04 2:47 ` Josh Poimboeuf
2025-12-02 16:27 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-02 16:28 ` [PATCH] " Josh Poimboeuf
2025-12-02 16:41 ` Ingo Molnar
2025-12-02 16:44 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203193741.2be672de@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=alexandre.chartre@oracle.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox