From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE46F2727FA for ; Wed, 3 Dec 2025 19:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764790669; cv=none; b=jagmutiGkcHvQF72Mm1aLg9MXdcrmPyyocpyo+6Hk+at6nSIMedp/xCyzwAh6EC6CoVpV7IAjTCQ33Vqnh7J4eELVh8FYdVcrRd+73gGXBWbgswhd8UEpAwp3L4uV9B6mFv6RrtT6+qKC6KyS9XfI+0bcssCKPVXlp5W/7E5bpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764790669; c=relaxed/simple; bh=kfGE6ZxOH7BpvnTyYRDZJwEn8isoG8OtW8UvyBB6vNI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=afvpYtqq8x/vgp1+qu/sgPqbRhEGT1ava7KJLKzOBskzx1ntFxMeokezLU9mt5GGBaGzfs7vZX2g5Ec1CCmqrfwb6jp3nJdq/3mRdIyJ/46MdWKMTBPrxoVxujVQuCWnHEwBEvUmmCCFgDT1eCB/+vZfgxfP+0UTSJK5+PXcuwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9kI4GG6; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9kI4GG6" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47778b23f64so927255e9.0 for ; Wed, 03 Dec 2025 11:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764790664; x=1765395464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wzOK9/Ru3Ud2BkDbftbeNa/SrsDQBmPJKQuvYZJFfHE=; b=Z9kI4GG6ZegUjKJ6FMRJv+CzPpOLYIU2SowQOyRo72N+c3MYV9j1QClsIQHsmArdrm 8yQw9osIB2aNiE9dRWE8ajHj9W/ZXJ6qLq6CuhWiJoLLyyjqUiNj1Gz9e9xuwNg4zQ6Y TZFz6mjGnrlM3N47Hf8zSK/sIEcUbTQXDtDh9DQNUWxooptFS41ZLCEeXOwxWqN0h/Cw 4K4oHQOgxACZPiGpKhOKiNXdvLjD3g7j50Nr6fHmeUt7WdR2pd9pzpHgeIF1CYXDpUtV TlhFr+IWlO8HmFVXYzoDer0o1G3YbKS4fq5Gt16KoWOyHUbov9PSHBBFj1h33MbD8e+V DwYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764790664; x=1765395464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wzOK9/Ru3Ud2BkDbftbeNa/SrsDQBmPJKQuvYZJFfHE=; b=trhgSsyrvg0gQmlBpKz+p1GlJBtoN0xQkepTFuzFIy0TsMU0olpBnEXNjrv2BcsYZu oCIdSbK+Z5hnDNk0goisIraYRTf13LEULcdSnC5JPFTzl2b5Zrd0+eR5ViFl2qrlGPNy Phf9cpFow9OOECx2/r+0vS/0GkahLLkz4DaQPM3bW10F8x9o6cTBtv+capCmiln3iB6z 59IWZM2PbpslcnCB4dAq3ba98IjAArD2rpMYTkiEoBrLLxlp71MMiD4tf7SH031QIinI GZ7EJlUvdUL2/Aw2JQc0mRx8VXOhG0YA+k7hFgwSCgpbYmg1B+OMArcop1Z+X336J1TX 6Wig== X-Forwarded-Encrypted: i=1; AJvYcCXB0ylu54ARm8pe8wCDHLOebs005BYPLAct54fuj8xBFB/lzjaTrnmgOAU4gHcouhgef7fPD7HJ+ln4q7w=@vger.kernel.org X-Gm-Message-State: AOJu0YxjQxKGTmSn4ZWRAb57JNrL7z2GzAXvzYnwAwbujvRugGWGRnrR gvrVV3ajt7yOWAuMpIQOhsmoIMjGhUUghju4fpo8+vmpCEhlbSN2uxpU X-Gm-Gg: ASbGnct0h6GGzExUMSgUggWpaJzk+hCUW1j5CZb1/VRh4oQ6GG5Wp3Lk4yR3raPax3v fh7sD6gEfpM+ugreWvEkZ8qFPJqdqkgPd87/e034z+6KH4bKGpEGATwsPKAs48i7oItSCYcB1Nm iFr1qnOu4VLE63zrIK/ZSF1RP87hgtD4Nu0X5plC/x4tR2tEUu0n+qbQ/xQMgwst5cmd42FrApF cVyLSdryWobN10ftc6M0VACfZlmbclVxSjMRWLwoRpxVgrxQZLP/SnuZhh1pnJ37gz0ffZ+kBfq kDQqNhh+Vp4zMIOkoyHyK9AbQwdkBasqfWLG3xDROlHezMtn22E85DFzs4TE59L0LU9PK3MPegi lkARR9LdWx6mcSCknLPFqGqfHoGMzjYc9EsM7KbRtmNJtwAq9hhld6/jSnouSNX0Bjd5AU2K+Gc /F2vJ8eMqxjJyq3ujtBQ7SEA6D1tm6FaSe1+u4aPeEK/IVI7hm3qIG X-Google-Smtp-Source: AGHT+IGRTC2U5xAet3NBdmAutAsDFj8LpkGn2cNoVWWnrI48PC1egmGHbbWx2HRvUWZm5yyCbI1e6A== X-Received: by 2002:a05:600c:4507:b0:477:1bb6:17e5 with SMTP id 5b1f17b1804b1-4792af41456mr39441325e9.30.1764790663627; Wed, 03 Dec 2025 11:37:43 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792a79dcfdsm62276295e9.5.2025.12.03.11.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 11:37:43 -0800 (PST) Date: Wed, 3 Dec 2025 19:37:41 +0000 From: David Laight To: Ingo Molnar Cc: Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Peter Zijlstra , Alexandre Chartre , Linus Torvalds Subject: Re: [PATCH] objtool: Fix stack overflow in validate_branch() Message-ID: <20251203193741.2be672de@pumpkin> In-Reply-To: References: <21bb161c23ca0d8c942a960505c0d327ca2dc7dc.1764691895.git.jpoimboe@kernel.org> <7i2v6lkl7pd2jzk57omos6pqkgwooewrrztsvi5weibvod2f5b@3mkwqwzslyl4> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Dec 2025 20:15:19 +0100 Ingo Molnar wrote: > * Josh Poimboeuf wrote: > > > On Wed, Dec 03, 2025 at 10:54:19AM -0800, Josh Poimboeuf wrote: > > > Keep in mind this is a worst case function for objtool: KASAN with tons > > > of memory accesses. The vast majority of functions won't come anywhere > > > near that level of recursion. > > > > And BTW, supporting that further, the max recursion depth on vmlinux.o > > on a defconfig kernel is showing 162. > > That's mostly immaterial - 'make allmodconfig' is not some esoteric > test, it's one of the most common testing methods by developers and CI > projects ... For example I use allmodconfig builds for every commit I > write or apply. Both allmodconfig and allyesconfig should probably manage to disable KASAN. Apart from building faster, the object files will be more realistic. I'm not sure how to make that work though. Could you have an ALLYESCONFIG config option that only 'all yes' will set and then make KASAN depend on !ALLYESCONFIG David > > Thanks, > > Ingo