From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72F2E136672 for ; Thu, 4 Dec 2025 01:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764812459; cv=none; b=SjPGm1GBMZbE1syGhLJOFFA6KrktOHpIVsIofrxG+Iq+v0/iya+g2ObDMdyrSZsDlJ4+RLxx9hm3adyDvUaj0m3jvjMJGncuu54KEYonJ5aKnW9/c8w8bxGV87cvtgMiVvBYL7abeStTEunH2yiQ5UTZZPuKBn0pKaakmeKPN9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764812459; c=relaxed/simple; bh=BM99yA5zKxdKG26bL4c4KmFejVDQUbVH43COraIGd8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cV7PVsPfWENI5QSXfGBh7y8l7vXWDmakCRrwpY32H2IrxD11UgPY1V7wRktW5URD7+RSA/H5U8/8gE0k9/ZFNtfyIcyiffpFUIyV/FCtfFuNlG2pqLOHyohWb4/YJ1oASSTfdM4tHB8s6x+NsSxLEadsLHD/NK5IQPQUG674gX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=ItWbvHj2; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="ItWbvHj2" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-647a3bca834so490427a12.2 for ; Wed, 03 Dec 2025 17:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1764812456; x=1765417256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usCVZbWwv9v8DM+VA7vraEXPn/PrzYHVW6BELku9usQ=; b=ItWbvHj2XKNJ4cj3LloXOXDRuwpyjjVNC/OfMovOWqOaZOcJbVA7idkL1KRx550e7q zO/F5ZlH6XKjkjNW7eSeQvY/BT2JItibpGrOzAxiLNYDTHK58yebXLaQLhcC/DGNDX5S i3ireRa/fvbN0N3dPSvUYRcnOlHXrqHAd0MH1gbtFW1TVQYgEclJ3ISdsU9C957spbZB B05XxbNwIqJ8B5QacCNwBObU5n6CjYqNtbNVdVLggWbgi4SSVO4cp/Cx88SOARuF64rD 5dT+X5owsHjteIsOU2ua4zbjQKxCd4TtIa0ChI8ErlBJUK9CbgWaMYuM5jmZLP9EkU07 iBJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764812456; x=1765417256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=usCVZbWwv9v8DM+VA7vraEXPn/PrzYHVW6BELku9usQ=; b=ulpFKhB9ZJEyi+NwP7+ULFC/7zR41nG9EpNvZRduiTyQDwLZN+Ww1TJpKat6c8Cgl4 ssKu3U3ux/iU3luVKG4P2BAOGTrHx8D4wh9qkoMMMqKzH1eeZLgIkXSlP72EWFeI8sao itoCsttjFacgvPofiQJ1vAhOogQitSulel3uUT8R401+2myTk55GQwqoLW7YRlY2aih2 7c71AbXWZSNpWKGo07wIpmXBr6ZfWqv5hq6aIeTlPNjnTZdT2T43r5SE1Khsw0DK7zze 2kWWrY19qTNfjFbFSB8uBGNFvLyl/9t/I0fqSCtywaVoGwF7LRY/M6/39ZAWFPpYY7gY T/8g== X-Forwarded-Encrypted: i=1; AJvYcCUnANhWJBEwJOnMWX/bXmqdBRQRjKVsvgzviFl6VXkznWV9Des1yzT93xJBEgbwA+WgttbgWB7Oa5ZqmSc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2oVczxX4XXNgYgrVxcCxs4FqmpUt+vPZa1CiZhvRpyKGKUkCK 269/0V2NxZUDnQx1sPxhVOWGpkQv4OqDf77dvmnhyp62f+ALW3phVYzhUhnNQ5J7K1M= X-Gm-Gg: ASbGnctVkM7Ezc4qfNCUIM6igre2cFS+DX3mjgxcOuni5yokpqIXoB4tz7GV8MjXIWj ESdM+lTH5GTsN4bTGrxrpSn8dom91k9djepodjUDbTlrN1RCl26ysvC/NJAOyksBsNOQU5wChby XUI8C9trnsEi8o7+vdRwyc9w7BQ+qSX1KLgcEZqDp2QTgCIUzGZWUd5R1f8SLrdDykCh0UdUv1u dfmhU2c99X1RlH1Lqo0r9ty86Ocjz9SW1xyDVBMwb8hr6ApKjFpVfWAwHi6qTvZ1WTpvDExp9GY bJFBRcCvLaza32BxrLJccpFezg92m8FS27IGXMAOKu2vnGn80fRPeX42ykQ9AL6+aQ5xkROzN9S DP28JQ7lW5Hg+CM08aqkk3vtDFN+S90Ffla8e6qmarSGFcl51Vhe5pbwkDNNBEk1Ln7XehemRCv k/AyHFQOKDFQnAArx8y6ZCKZy1xkwYB7vhD5x+A1U3dOL5x/U= X-Google-Smtp-Source: AGHT+IGfRE0y5OoQoEAxk9F/9R4hL3hkUmJWKifR9VWkvr8jbHYDQJhShb60/e1UsyObLpRQHJd9SQ== X-Received: by 2002:a05:6402:2749:b0:63b:f22d:9254 with SMTP id 4fb4d7f45d1cf-6479c516959mr3524977a12.23.1764812455779; Wed, 03 Dec 2025 17:40:55 -0800 (PST) Received: from dev-mattc2.dev.purestorage.com ([208.88.159.129]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-647b2ec3019sm80170a12.4.2025.12.03.17.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 17:40:54 -0800 (PST) From: Matthew W Carlis To: macro@orcam.me.uk Cc: ahuang12@lenovo.com, alok.a.tiwari@oracle.com, ashishk@purestorage.com, bamstadt@purestorage.com, bhelgaas@google.com, guojinhui.liam@bytedance.com, ilpo.jarvinen@linux.intel.com, jiwei.sun.bj@qq.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lukas@wunner.de, mattc@purestorage.com, msaggi@purestorage.com, sconnor@purestorage.com, sunjw10@lenovo.com Subject: Re: [PATCH 2/2] PCI: Fix the PCIe bridge decreasing to Gen 1 during hotplug testing Date: Wed, 3 Dec 2025 18:40:20 -0700 Message-ID: <20251204014020.1426-1-mattc@purestorage.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 1 Dec 2025, Maciej W. Rozycki wrote: > Discard Vendor:Device ID matching in the PCIe failed link retraining > quirk and ignore the link status for the removal of the 2.5GT/s speed > clamp, whether applied by the quirk itself or the firmware earlier on. > Revert to the original target link speed if this final link retraining > has failed. I think we should either remove the quirk or only execute the quirk when the downstream port is the specific ASMedia 0x2824. Hardware companies that develop PCIe devices rely on the linux kernel for a significant amount of their testing & the action taken by this quirk is going to introduce noise into those tests by initiating unexpected speed changes etc. As long as we have this quirk messing with link speeds we'll just continue to see issue reports over time in my opinion.