public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Shuah Khan <shuah@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
	Elizabeth Figura <zfigura@codeweavers.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Kees Cook <kees@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	wine-devel@winehq.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
	Amir Goldstein <amir73il@gmail.com>
Subject: [PATCH 12/13] selftests/fs/mount-notify-ns: Fix build failures seen with -Werror
Date: Thu,  4 Dec 2025 08:17:26 -0800	[thread overview]
Message-ID: <20251204161729.2448052-13-linux@roeck-us.net> (raw)
In-Reply-To: <20251204161729.2448052-1-linux@roeck-us.net>

Fix

mount-notify_test_ns.c: In function ‘fanotify_rmdir’:
mount-notify_test_ns.c:494:17: error:
	ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’

by checking and then ignoring the return value of chdir().

Fixes: 781091f3f5945 ("selftests/fs/mount-notify: add a test variant running inside userns")
Cc: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 .../selftests/filesystems/mount-notify/mount-notify_test_ns.c  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
index 9f57ca46e3af..949c76797f92 100644
--- a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
+++ b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test_ns.c
@@ -491,7 +491,8 @@ TEST_F(fanotify, rmdir)
 	ASSERT_GE(ret, 0);
 
 	if (ret == 0) {
-		chdir("/");
+		if (chdir("/"))
+			;
 		unshare(CLONE_NEWNS);
 		mount("", "/", NULL, MS_REC|MS_PRIVATE, NULL);
 		umount2("/a", MNT_DETACH);
-- 
2.43.0


  parent reply	other threads:[~2025-12-04 16:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 16:17 [PATCH 00/13] selftests: Fix problems seen when building with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 01/13] clone3: clone3_cap_checkpoint_restore: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 02/13] selftests: ntsync: Fix build errors -seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 03/13] selftests/filesystems: fclog: Fix build errors seen " Guenter Roeck
2025-12-04 16:17 ` [PATCH 04/13] selftests/filesystems: file_stressor: Fix build error " Guenter Roeck
2025-12-04 16:17 ` [PATCH 05/13] selftests/filesystems: anon_inode_test: " Guenter Roeck
2025-12-04 16:17 ` [PATCH 06/13] selftest: af_unix: Support compilers without flex-array-member-not-at-end support Guenter Roeck
2025-12-04 17:40   ` Jakub Kicinski
2025-12-04 17:58     ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 07/13] selftest/futex: Comment out test_futex_mpol Guenter Roeck
2025-12-04 16:17 ` [PATCH 08/13] selftests: net: netlink-dumps: Avoid uninitialized variable error Guenter Roeck
2025-12-04 16:17 ` [PATCH 09/13] selftests/seccomp: Fix build error seen with -Werror Guenter Roeck
2025-12-04 16:17 ` [PATCH 10/13] selftests: net: Work around " Guenter Roeck
2025-12-04 16:30   ` Jakub Kicinski
2025-12-04 17:21     ` Guenter Roeck
2025-12-04 16:17 ` [PATCH 11/13] selftests/fs/mount-notify: Fix build failure " Guenter Roeck
2025-12-04 16:17 ` Guenter Roeck [this message]
2025-12-04 16:17 ` [PATCH 13/13] selftests: net: tfo: Fix build error " Guenter Roeck
2025-12-04 16:27 ` [PATCH 00/13] selftests: Fix problems seen when building " Jakub Kicinski
2025-12-04 17:16   ` Guenter Roeck
2025-12-04 17:43     ` Jakub Kicinski
2025-12-04 17:56       ` Guenter Roeck
2025-12-04 20:03     ` Kees Cook
2025-12-04 20:07       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204161729.2448052-13-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=amir73il@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=edumazet@google.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wine-devel@winehq.org \
    --cc=zfigura@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox