Re: [PATCH bpf-next v2 1/5] crypto: Add BPF hash algorithm type registration module

bot+bpf-ci
2025-12-05T18:05:44Z

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

> diff --git a/crypto/Makefile b/crypto/Makefile
> index 16a35649dd91..853dff375906 100644
> --- a/crypto/Makefile
> +++ b/crypto/Makefile

[ ... ]

> diff --git a/crypto/bpf_crypto_shash.c b/crypto/bpf_crypto_shash.c
> new file mode 100644
> index 000000000000..39032e7dd602
> --- /dev/null
> +++ b/crypto/bpf_crypto_shash.c

[ ... ]

> +static const struct bpf_crypto_type bpf_crypto_shash_type = {
> + .alloc_tfm = bpf_crypto_shash_alloc_tfm,
> + .free_tfm = bpf_crypto_shash_free_tfm,
> + .has_algo = bpf_crypto_shash_has_algo,
> + .hash = bpf_crypto_shash_hash,
> + .digestsize = bpf_crypto_shash_digestsize,
> + .get_flags = bpf_crypto_shash_get_flags,
> + .owner = THIS_MODULE,
> + .name = "hash",
> +};

Does this code compile? The struct bpf_crypto_type definition in
include/linux/bpf_crypto.h doesn't have .hash or .digestsize fields at
this commit. The commit message says "Update the bpf_crypto_type
interface with hash-specific callbacks" but the interface wasn't
actually updated in this commit.

Looking forward in the git history, commit 51e5f5be27dc adds these
fields to the interface. Should that commit come before this one for
bisectability?

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/19971392632