From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1AD73522D2 for ; Fri, 5 Dec 2025 19:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964216; cv=none; b=TH9Qf1PJFXLjxWu/l/J1JDTWdg7ltOMuW/mJh43XuSaEiiZCKBYodXbHDC7ieAgMZ3p0at/D1CT3/r/Yz8SQDxEe//efHSdXLrhHTR9s8QcrVsBtnFHLnVFkWQNsbKD11NBTCz0cEadac4/TNc9M8rIJAcZ/DmC9fyVvv9LM/v8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764964216; c=relaxed/simple; bh=2qehvIyxcQgdG2r4Lq1PdhJk+p1KTlod1C1KRZ0s8Eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SazCGb1JDTdu//vJwCzFHWfgCS+Y62jdez41Sy7HAP8s1FXyXl/v/szHpJ9fALPOVQCzOeLjSGCBR2pPlydk4lNDKAYvQU4M8rc3WmeEX1J7vH7vTzxR5bAEKLXohoGdbM64G0n1QkbCf2QH7AwWT0dABZ3Jq/5I9TkB24tK9Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=l0XSQrBn; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="l0XSQrBn" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-88246676008so26963296d6.3 for ; Fri, 05 Dec 2025 11:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1764964211; x=1765569011; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3RQExzcfqwYlyekZ+KLVqUTRdy0TqxFDRhSxkhvJOBs=; b=l0XSQrBn0Bg/nPg56+wIeyaM01uppEclZacA39vD7NoNnb6wmBDZpMQsL207zXFY1x wVxGSz2apKZ6Y2UUw23oQjtoBzja8GzqBuyWTgrIAnFBIiHHvlzObRc1O4+SGZojTM2A iXnObOJ2S5O/r4vqjt1zPw/tbrvZTqRGc3ppYZtXyZyJxEJT0xceu0d4fM0n0Jdg94kf n62mOEohw9WKjtT78Sz1tuxzIFSuRbKOxfN8J5VdCN+qBlL/ePpr4Mllcrf8hhajC3/k Mq2AwGpxgn2Opiak++M+HsgM+fOMYoe/LaieNKLKUggt0vaVRAPt4YsTu8FT6KhGbCBI wEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764964211; x=1765569011; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3RQExzcfqwYlyekZ+KLVqUTRdy0TqxFDRhSxkhvJOBs=; b=k57jh4visxw0tT1Wbv9ALqsD/gJsoevFc+IiGy3Q7S7aTijfvIn/iAGWP3TfuXkRbL xPneBqV+nqKDf+y14XLCjVlzhfZbnrz9SW6Kt/Smp1OAzGUR5twdle9N2fvE11nQdiS/ 9nSrvlxCHTuDnYtggKYQHWxsAcNLzC8LqirX5kWDWMRY4Ic1re/+fk7Y6xnTq/rjFmy8 4waWMUOnC5aN+Anm9Vaub7HPLEjKEcQJfVGtf5QGvgCGO1g72eYDeaw1bi8UXzBk7kdd p6Ojj3NQGfnckCYgCN+oClalJA+xFp/Cqwh0Ea7+GOCgyQ5uUlEIc9xvZfAh8wVFHjq4 LV2g== X-Forwarded-Encrypted: i=1; AJvYcCVI6CHHwzKrlQdDkDIqqmkkyV8mnXy4jDteqibNSwg1PjJ1Ij2PWfoZlpsBAbOiHmqVD7APkh7t52H8c6Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy171im+zriuNvJ5wMn9wdh+0hNPapNJY3LQqN+G9KJTUP6N3x9 yKr1o6KHgE+Pe9gOwQIIZNWJWb90KvgIONXsHrE2BUzJnlDc9bguKOojH646y6C3phI= X-Gm-Gg: ASbGnctj7RaNu1bVL9qHyeLnmY/vKhmhJYi0O6+wLPEESr5hHTAJkFoFERd+Bbds+Og 29igcUC+f6QW16+KjPKwsPCWYTk2qoHKQA7wMTojF78ZDbMi7DTS88mW/EwHicT04bprtbXpgvK A8Jd+36NVSUYlOqlEKWEPMvbPuODguGz118RPnThCf2X3alsFe05UU72sU8b3vx5/oYdhoZWYGe mgB3dXX9CaICUg+pYP+f5UF/TB+3jDUPPqOUYfomhaTYCJ1miThQ8B815d4Ocu31vqs+qPTCfIa QAsBV7rshrSVRgjAl5/h3UNXHERcurQUd666wqMrSid8C2ML4QJLAWV5vIQoQqFdx12QGeviRFZ 57J7DdmOITiO3IBFzRuBftANSchtH6SpWKQ5CwmOyGcBj0fjLHgmbR6UovBVmpX/Ffl01shoFWg CJEh7PoMZNf5Ql9TPD9x8TuZSEjQxoevPeXwwPq+JiTGEkuNYHHWZu4e8S X-Google-Smtp-Source: AGHT+IEhNQzl6hnLnvBGiNFZqavEi9gf+2ka/7WFT3C4ElHJ2NM/0b+SbU12SVUuzIi8xfaOQ1uqlA== X-Received: by 2002:a05:6214:5090:b0:880:4ef7:ce77 with SMTP id 6a1803df08f44-8883dbef91bmr3494316d6.49.1764964210765; Fri, 05 Dec 2025 11:50:10 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-888286aed31sm40901866d6.37.2025.12.05.11.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 11:50:09 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vRbof-00000005vY6-1Pjz; Fri, 05 Dec 2025 15:50:09 -0400 Date: Fri, 5 Dec 2025 15:50:09 -0400 From: Jason Gunthorpe To: Arnd Bergmann Cc: Kevin Tian , Joerg Roedel , Will Deacon , Nicolin Chen , Arnd Bergmann , Robin Murphy , Lu Baolu , Alex Mastro , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommufd: fix building without dmabuf Message-ID: <20251205195009.GN812105@ziepe.ca> References: <20251204100333.1034767-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204100333.1034767-1-arnd@kernel.org> On Thu, Dec 04, 2025 at 11:03:29AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When DMABUF is disabled, trying to use it causes a link failure: > > x86_64-linux-ld: drivers/iommu/iommufd/io_pagetable.o: in function `iopt_map_file_pages': > io_pagetable.c:(.text+0x1735): undefined reference to `dma_buf_get' > x86_64-linux-ld: io_pagetable.c:(.text+0x1775): undefined reference to `dma_buf_put' > > Fixes: 44ebaa1744fd ("iommufd: Accept a DMABUF through IOMMU_IOAS_MAP_FILE") > Signed-off-by: Arnd Bergmann > --- > drivers/iommu/iommufd/io_pagetable.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) I picked this up anyhow since it looked like adding #ifdef stubs to dma_buf.h was going to be a bigger thing > + if (IS_ENABLED(CONFIG_DMABUF_HEAPS)) > + dmabuf = dma_buf_get(fd); But this needs to be: if (IS_ENABLED(CONFIG_DMA_SHARED_BUFFER)) dmabuf = dma_buf_get(fd); I fixed it Thanks, Jason