From: Wei Liu <wei.liu@kernel.org>
To: Praveen K Paladugu <prapal@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, arnd@arndb.de, anbelski@linux.microsoft.com,
easwar.hariharan@linux.microsoft.com,
nunodasneves@linux.microsoft.com,
skinsburskii@linux.microsoft.com
Subject: Re: [PATCH v7 1/4] fixup! Drivers: hv: Introduce mshv_vtl driver
Date: Fri, 5 Dec 2025 23:06:24 +0000 [thread overview]
Message-ID: <20251205230624.GA1942423@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <20251205201721.7253-2-prapal@linux.microsoft.com>
Please provide a proper commit subject.
On Fri, Dec 05, 2025 at 02:17:05PM -0600, Praveen K Paladugu wrote:
> Drop the spurios "space" character in Makefile condition check
> that causes mshv_common.o to be built regardless of the CONFIG settings.
>
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> Suggested-by: Michael Kelley <mhklinux@outlook.com>
This should come with a Fixes: tag.
> ---
> drivers/hv/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> index 58b8d07639f3..6d929fb0e13d 100644
> --- a/drivers/hv/Makefile
> +++ b/drivers/hv/Makefile
> @@ -20,6 +20,6 @@ mshv_vtl-y := mshv_vtl_main.o
> # Code that must be built-in
> obj-$(CONFIG_HYPERV) += hv_common.o
> obj-$(subst m,y,$(CONFIG_MSHV_ROOT)) += hv_proc.o
> -ifneq ($(CONFIG_MSHV_ROOT) $(CONFIG_MSHV_VTL),)
> +ifneq ($(CONFIG_MSHV_ROOT)$(CONFIG_MSHV_VTL),)
> obj-y += mshv_common.o
> endif
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-12-05 23:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 20:17 [PATCH v7 0/4] Add support for clean shutdown with MSHV Praveen K Paladugu
2025-12-05 20:17 ` [PATCH v7 1/4] fixup! Drivers: hv: Introduce mshv_vtl driver Praveen K Paladugu
2025-12-05 23:06 ` Wei Liu [this message]
2025-12-05 23:08 ` Wei Liu
2025-12-05 23:11 ` Wei Liu
2025-12-05 20:17 ` [PATCH v7 2/4] hyperv: Add definitions for MSHV sleep state configuration Praveen K Paladugu
2025-12-05 20:17 ` [PATCH v7 3/4] hyperv: Use reboot notifier to configure sleep state Praveen K Paladugu
2025-12-05 20:17 ` [PATCH v7 4/4] hyperv: Cleanly shutdown root partition with MSHV Praveen K Paladugu
2025-12-05 23:26 ` [PATCH v7 0/4] Add support for clean shutdown " Wei Liu
2025-12-10 8:14 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205230624.GA1942423@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=anbelski@linux.microsoft.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=easwar.hariharan@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=prapal@linux.microsoft.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox