From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E3230F80B for ; Mon, 8 Dec 2025 08:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765184333; cv=none; b=mBXda/A4a6vU1hcB7zDACYWp5j3bpMFcRa1liOU/3czUGGkWFqq4jOUo9bVmOFZho8PKlRCTy3moE07hDlo6eV+QdMpY/D9Yr+DUIS7CtVt4VZ2Okqo5b0A6gS7okAbaNPKgUz1MfA/m+CoY0/LIMTAhP5uuLG3+1lEa3cV0S58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765184333; c=relaxed/simple; bh=M81ySC1vyJlVYV5cst133dGf9og1VBuqvlwEWWo33LY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NHCpXSoUGq0ZudeH+T3SLBNreN5boEEFc+LFhXZRNTtSWqxM1u8lg/mREwHkgcPThufH0Vsh1RY/qaYt8SUgTCclND/bsxgwkJiTGpC+d0YRryBmYu5ms3uLWmSIjzVjA+t8GsZ/Qsh6hyVPh/1IVUIiNAJSq448PAth56cZ+No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=HpcSiDWc; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HpcSiDWc" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=x8X9KW3i/mdyRKQ3Sw3jZ3zs/YEsjxhxOaT1CLoQOfM=; b=HpcSiDWcBGJTbXKSBVoaKyL5Hj nFfjTmyDHLio+bCA8dFk84L8RU+YoFsjqY82XTQqjm8myBXsdZvcrK94CeeQZp5eHgI1vqrXQvl22 mHj/3j82KTjpjgZv4OpsxxwahIG5NDNghdBmc4P6tZ1XVpYFRrM8pJzGbuI1zKBvxvoiIMsSeBfOU BUWwI0DddZP3VXNUyA3qAlbhhi0izKV083aU5vyksU6EiPenKE2R8HhzMRlBP+HpTBNS/50mgprY2 OYqC3cd64aindIRWfUnjovwOLKy/HFiUVoZ6kNM8lvY+C/kID39SD7THwOll2E1f0FAlc12EpZFjN eUcS4OpA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSX4x-00000009Ykq-1ZOH; Mon, 08 Dec 2025 08:58:47 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id E988030301A; Mon, 08 Dec 2025 09:58:46 +0100 (CET) Date: Mon, 8 Dec 2025 09:58:46 +0100 From: Peter Zijlstra To: Brendan Jackman Cc: Andrew Morton , linux-kernel@vger.kernel.org, kees@kernel.org, acarmina@redhat.com, jpoimboe@kernel.org, mark.rutland@arm.com, maciej.wieczor-retman@intel.com Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf() Message-ID: <20251208085846.GB3707837@noisy.programming.kicks-ass.net> References: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com> <20251208083857.GA3707837@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Dec 08, 2025 at 08:50:17AM +0000, Brendan Jackman wrote: > On Mon Dec 8, 2025 at 8:38 AM UTC, Peter Zijlstra wrote: > > On Sun, Dec 07, 2025 at 03:53:18AM +0000, Brendan Jackman wrote: > >> Recent additions to this function cause GCC 14.3.0 to get excited and > >> suggest a missing attribute: > >> > >> lib/bug.c: In function ‘__warn_printf’: > >> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] > >> 187 | vprintk(fmt, *args); > >> | ^~~~~~~ > >> > >> Disable the diagnostic locally, following the pattern used for stuff > >> like va_format(). > > > > No real objection, but why haven't I seen this in my own builds? Most of > > my machines are on gcc-14 / gcc-15. > > Ah, yeah, apparently it only shows up with W=1. *sigh*, one of them. Ok, thanks!